From nobody Fri Mar 20 12:44:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fcj1c3J2Nz6Vw1f for ; Fri, 20 Mar 2026 12:44:20 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fcj1Z5RDfz3pvS for ; Fri, 20 Mar 2026 12:44:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486fe36cfabso5043785e9.1 for ; Fri, 20 Mar 2026 05:44:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774010657; x=1774615457; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m+GB6CMbjFbnWkVs1fZkP0ppiz+F0VO8NMqI9/X4QsA=; b=QEhE7IEMJCejkqR/lKTAXACzEkHs8QDV/3/WRqXEhhEHs7TfYo5QBR7Q8FrF/ZNycL hU7VfzCM3GRKMpeifvfxBzaZddqQ10ssx8teBxTz3ReKyLX0YhRJWQzcGjY1FlcAHyXb +A79+AlwU3nAUCghb7PPR34bNrkrgKCljmqaNXN4j7cID4LgSCPRYeWGzr78uQyk1xwP UH1gKOF4sypVeXzY77st8Z0kJZEODxm4uA1/yLN2TjkZUP0zWJqS4SW5MNqZw97B1ZQx 4BcWdbHFQ6kyGCJdOzp0luMUgG0y1rKrqhjxFetvFOAHA/zRfxwNvswZf4dHnaFB03yj sA7g== X-Forwarded-Encrypted: i=1; AJvYcCUfDiYC064jHctLoyS1QSXQrCH0USrqIOplQ3QPRDPDEubq9cSrg3WXzmw5+twNZoSiTRwX244hvBQ6kdh+eNoPnD/n@freebsd.org X-Gm-Message-State: AOJu0Yzhkn6PLJBZW0FgY+lrjv0aI3fdcb4BIURQ0v7q0z62vCiuywS8 aBLwJsud+2BeuBUqJvAs9z1LlU59JyLNZRMiYEnvV665jIIlSE4TzU3y2BPZkxN2DLs= X-Gm-Gg: ATEYQzxZTtsjEg85ZxH5ZYCU1H8SjoBA2t8b+kvEKx649dXGdMcZhN/oIZoerb+ETLC 41wujQmqv8fHyfIz7s+S9woLEjNkGC3wbEepRxZ0p+BtVt+o3PcTDyxMmJ4i/JmE7JHEiHWcTRy 3yyUtg8g6UF5r8Kqxg2kQx5kzqUIJBv0QQuISGb0rO2QNXcmXEeo7okg2s/R86ttT2TPLHwL3aU VMF6ZbJzpIlBYcI4jZ4MCjvTcUs+KDdYFbnXoRAUrhmsNL5UU2FWNvUJky+GZtLiy57nRUjhTEb WBNqHk/9hEeXYfnewQ8ta6DapM7Fi0bbi6f0Ln59vt/WfSDmo2gWl5c6Z/uGncHq1tDgRFKzkIH TfHvfGCLNuAzs93BcP8JN8QSaiXAb3IDpge/64SKXtOzW9S5weH7MibGA62GtlrrTwX+GNDnKEI xBa25eoBYuSHOPAiZh7Tzy/sz8OIZu8Vcc01ZjBG+jmhQWdqO1LluawYzEp2JLde4Z X-Received: by 2002:a05:600c:8b84:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-486fe8e3facmr48246755e9.9.1774010656526; Fri, 20 Mar 2026 05:44:16 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8ba4a74sm132520555e9.12.2026.03.20.05.44.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2026 05:44:15 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 1d13d938fe6c - main - virtio: Ensure power-of-two alignment for indirect queue From: Jessica Clarke In-Reply-To: <8F587FE2-CF54-4605-9CD6-581FC1D98D34@freebsd.org> Date: Fri, 20 Mar 2026 12:44:04 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Sarah Walker Content-Transfer-Encoding: quoted-printable Message-Id: <52B83EF2-4427-44ED-8486-B513189DA4AA@freebsd.org> References: <69b939d7.26113.1aca36de@gitrepo.freebsd.org> <8F587FE2-CF54-4605-9CD6-581FC1D98D34@freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.3864.400.21) X-Spamd-Result: default: False [-2.88 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.976]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.53:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.53:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4fcj1Z5RDfz3pvS X-Spamd-Bar: -- On 17 Mar 2026, at 11:34, Jessica Clarke wrote: >=20 > On 17 Mar 2026, at 11:24, Andrew Turner wrote: >>=20 >> The branch main has been updated by andrew: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D1d13d938fe6c7639d2bb4cb5248a1f81= 275b6891 >>=20 >> commit 1d13d938fe6c7639d2bb4cb5248a1f81275b6891 >> Author: Sarah Walker >> AuthorDate: 2026-03-17 10:54:30 +0000 >> Commit: Andrew Turner >> CommitDate: 2026-03-17 10:56:27 +0000 >>=20 >> virtio: Ensure power-of-two alignment for indirect queue >>=20 >> Some platforms enforce power-of-two alignment for bus_dma tags. = Rounding up >> the natural size may result in over-alignment, but should be safe. >>=20 >> PR: 293770 >> Reviewed by: andrew >> Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and = indirect buffer allocations") >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D55843 >> --- >> sys/dev/virtio/virtqueue.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c >> index b7fdb4703ccb..10b5179bd3d5 100644 >> --- a/sys/dev/virtio/virtqueue.c >> +++ b/sys/dev/virtio/virtqueue.c >> @@ -341,7 +341,7 @@ virtqueue_init_indirect(struct virtqueue *vq, int = indirect_size) >> align =3D size; >=20 > Why is this the alignment in the first place? Pre-busdma it just used > malloc with no explicit alignment. Given: >=20 > size =3D indirect_size * sizeof(struct vring_desc); >=20 > can=E2=80=99t this get quite large? Except VIRTIO_MAX_INDIRECT looks = to be > rather stale, tied to the malloc rather than busdma world=E2=80=A6 Ping? Jessica