From nobody Wed Mar 18 23:43:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fbllR4KNyz6VHwW for ; Wed, 18 Mar 2026 23:43:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fbllR3n3bz3ms5 for ; Wed, 18 Mar 2026 23:43:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773877427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUW3dC7k+aH5bXxwIpwBLR+17DQSSsFjbTg63qWG/jA=; b=Es4DKD6nnb6w0BfDIlVSAbAn7eUiDwS28FtPpRLOK0QIGcPyRsuBia6SLPWBxFGcBd8w3i dTB2jUpmB9LWwrP4nvnWwBCiON1BTY3bfkmL+4euFFuyamPZ85ROcvWkb34PlWQNdm09Nd CGgxnmvaYVwYi07a0aO3AxJuGTKBm/mVnmD6oI+R6P7NxkFFsFSJqhd0YQFsRN4R0ZlmUB rP0x83vjTdGBVudhdFxb1i5oKoIAZQOwaRZVx8ufslI+Z+FrDCaWGttdtImXLm8GBgwsc8 ub5f9SVtwVjXlMHBpMz1cTlM19yysi7bv3Yt8qwaz714+LqY5DYnhFveplyIHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773877427; a=rsa-sha256; cv=none; b=KCuhgcK8K3SeD+hN63VGcVaK3ippLEUNsimogj0EZ3+peIZCXEzmbAlBy+lelFSukCAtp/ MvdMHw7+5tOAeQPd8q8weRatpKNmiGf51jn2BKkd5MSG+PwB11/LDg0IrGk8t/y7oO+y5c tbK725XNOPTdl6q1O5thBYpdXKv637FGj5A4PetMAGd/BeDcMXSxozp728t0xGrQ/kClsd RX55tvc8tCl36bT+Jy7dY/6+CwLZSNf27trt6Xx0zwIJRZnmirsu9ae7AXeugCRd7J5Oep A4APRFsLU9JKtFBjCLqbWjLgXUQlcLYiJQwUJ06sIqcVkDxxSxu52qfA1DfRkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773877427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUW3dC7k+aH5bXxwIpwBLR+17DQSSsFjbTg63qWG/jA=; b=CCIcnkhJS2hoqMjAiU+jQB4YOF9dltW5es4ckRwFHZ9lJJUa2V8PlzAr5oYTSuenmGBA1e fCTKYq4M/LII6tgA8A44MN79evz1oKDD9ztzrwKxsWnDLsryZJkqSoWOLo2UN6DcbZ3nwQ jR09HO67z3MIVM1OlOlMB4KcrVib3DcJ+CdJXM32d7N3WlkfKBHzsxWYNNk9L8kn/RyN8Q dboB9Sv3AZqzT/eueUOkg8WpLYsWLV5eGSAXhV4s+KRgsBY5ZEg+jMDB6CqWlewrnNIXgj uroztiNF9GaAyD8S0tKpy2CtRdVfKpEGXHTQgRpVfRrRU2yhc7oIcth45G3kJA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fbllR3N2PzTl5 for ; Wed, 18 Mar 2026 23:43:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3342a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 18 Mar 2026 23:43:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 63171222540e - main - cxgbe(4): adjustments to the output of the slow interrupt handler List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 63171222540e10a58f3acacf65a412f44043f511 Auto-Submitted: auto-generated Date: Wed, 18 Mar 2026 23:43:47 +0000 Message-Id: <69bb38b3.3342a.4abd9d71@gitrepo.freebsd.org> The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=63171222540e10a58f3acacf65a412f44043f511 commit 63171222540e10a58f3acacf65a412f44043f511 Author: Navdeep Parhar AuthorDate: 2026-03-18 21:56:37 +0000 Commit: Navdeep Parhar CommitDate: 2026-03-18 21:56:37 +0000 cxgbe(4): adjustments to the output of the slow interrupt handler - Display an appropriate alert character instead of a question mark for unknown bits. - Display all fatal bits for a register and not just the ones that are currently set. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/common/t4_hw.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c index 494f83a47135..24ac018cc49c 100644 --- a/sys/dev/cxgbe/common/t4_hw.c +++ b/sys/dev/cxgbe/common/t4_hw.c @@ -4797,7 +4797,6 @@ struct intr_info { static inline char intr_alert_char(u32 cause, u32 enable, u32 fatal) { - if (cause & fatal) return ('!'); if (cause & enable) @@ -4817,7 +4816,7 @@ show_intr_info(struct adapter *sc, const struct intr_info *ii, uint32_t cause, if (verbose || ucause != 0 || flags & IHF_RUN_ALL_ACTIONS) { alert = intr_alert_char(cause, enabled, fatal); CH_ALERT(sc, "%c %s 0x%x = 0x%08x, E 0x%08x, F 0x%08x\n", alert, - ii->name, ii->cause_reg, cause, enabled, fatal); + ii->name, ii->cause_reg, cause, enabled, ii->fatal); } leftover = verbose ? cause : ucause; @@ -4829,8 +4828,10 @@ show_intr_info(struct adapter *sc, const struct intr_info *ii, uint32_t cause, CH_ALERT(sc, " %c [0x%08x] %s\n", alert, msgbits, details->msg); leftover &= ~msgbits; } - if (leftover != 0 && leftover != (verbose ? cause : ucause)) - CH_ALERT(sc, " ? [0x%08x]\n", leftover); + if (leftover != 0 && leftover != (verbose ? cause : ucause)) { + alert = intr_alert_char(leftover, enabled, fatal); + CH_ALERT(sc, " %c [0x%08x]\n", alert, leftover); + } } /*