Re: git: ac5ff2813027 - main - sound: enforce MASTER volume mute during playback

From: Sean C. Farley <scf_at_FreeBSD.org>
Date: Thu, 12 Mar 2026 18:50:15 UTC 
On Thu, 12 Mar 2026, Christos Margiolis wrote:

> The branch main has been updated by christos:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=ac5ff2813027c385f9037b47b2b164d4c1bebd09
>
> commit ac5ff2813027c385f9037b47b2b164d4c1bebd09
> Author:     Sean Farley <scf@FreeBSD.org>
> AuthorDate: 2026-03-12 18:22:02 +0000
> Commit:     Christos Margiolis <christos@FreeBSD.org>
> CommitDate: 2026-03-12 18:22:02 +0000
>
>    sound: enforce MASTER volume mute during playback
>
>    MASTER mute (vol.mute) works while audio is playing. However, if a
>    stream is stopped and restarted (PCMTRIG_STOP -> PCMTRIG_START), the
>    audio will resume even though the mixer shows the MASTER volume as
>    muted. Other streams that are already playing remain silent. New streams
>    may also start playing audio regardless of the MASTER mute state.
>
>    The volume feeder now considers the MASTER mute when determining whether
>    a channel should be muted. This ensures MASTER mute is consistently
>    enforced for all streams and removes the dependency on trigger-driven
>    state propagation.
>
>    Tested with Creative Labs CA0132 card.
>
>    MFC after:      1 week
>    Reviewed by:    christos
>    Differential Revision:  https://reviews.freebsd.org/D55605

Thank you!

Sean
-- 
scf@FreeBSD.org