From nobody Mon Mar 09 18:25:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fV56Y1rf5z6TgKb; Mon, 09 Mar 2026 18:25:41 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fV56X4DBJz3kgv; Mon, 09 Mar 2026 18:25:40 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 2F802EC0D71; Mon, 9 Mar 2026 14:25:39 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Mon, 09 Mar 2026 14:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1773080739; x=1773167139; bh=ZF6gVt9Dia SAFaPaEj3oodOilyXef49HYC5+14JOrZc=; b=Y8O3dQwbL6l6LIHb7uhb8PJ21N yTZ4e94Cavsfqee/mGCvlbr0RtwW6uvfpTBsaD76P0oUvRBFiT48l4WDBVOPbsfQ A/MUTz4NEXxp3KZR4o6R5c+iv7UIjHp2UvK2veKIqJ3421uhsqr6Lauvs+tUZGuu Oh89pC4KRAGmfVuBx7wOOV2AhBEIq6QyVBLiD4ISMUSOPWtyZAK31mWhlMeEhFxp 4DfGV5Ibv/C+6Y4r1HJS4qhqUxH3E1YAMXNalDUbSDgasyVxk0+Xdc9R2Ve8rMo4 i8nNFmxh32QPGlQsgONGu6Lt+X/iZZzaFRO/fnkIYDU9a3u4YYlQIkZd9mdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773080739; x=1773167139; bh=ZF6gVt9DiaSAFaPaEj3oodOilyXef49HYC5 +14JOrZc=; b=oJP66tQLibj9Sc/FbUP0kXeGce8ALnc/0f2nGPMgDjLXL0CJdCK BYvYd/Z+rV9U7r5POcb2+d0P8+xZXHuA3ilrDZejNhJ86kBZiL+U4+kHh7OelRx3 tpH4aOzh74BVrOtBBem70YW7gPEqn3SJqVTxC4U5paDCBWQa4XaPuSP6FgbYwC0G FlrfeF3pKUTNk4w/7I/lBfr8NDnICKlmFpYp4WQpnZz8XRE56YfaJwkO7gViXWtf ndn/KGUxeuP2u1r3SBPWMRIVQa0SXQwdSBX6HBUUBrWBIcldjM1nYDD3Vw55XnjB ian6++e/GbqLRypYmMx7Bu33POD7qJoxAuw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvjeekkeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffkhffvvefujghffgggtgesthdtredttdervdenucfhrhhomhepfdfjvghrsggv rhhtucflrdcuufhkuhhhrhgrfdcuoehhvghrsggvrhhtsehgohhjihhrrgdrrghtqeenuc ggtffrrghtthgvrhhnpeefhfehffegvdehuedtuefgkeefieffieejhfeggeekgeevjeeg feffgeeglefhtdenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhvghrsggvrhhtsehgohhj ihhrrgdrrghtpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtph htthhopegrnhgurhgvfiesfhhrvggvsghsugdrohhrghdprhgtphhtthhopehsrhgtqdgt ohhmmhhithhtvghrshesfhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghvqdgtoh hmmhhithhsqdhsrhgtqdgrlhhlsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepuggv vhdqtghomhhmihhtshdqshhrtgdqmhgrihhnsehfrhgvvggsshgurdhorhhgpdhrtghpth htohepshgrrhgrhhdrfigrlhhkvghrvdesrghrmhdrtghomh X-ME-Proxy: Feedback-ID: i64fe486c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Mar 2026 14:25:37 -0400 (EDT) Date: Mon, 09 Mar 2026 19:25:32 +0100 Message-ID: <87pl5c5083.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Andrew Turner Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Sarah Walker Subject: Re: git: c499ad6f997c - main - virtio: Use bus_dma for ring and indirect buffer allocations In-Reply-To: References: <69a71c75.40215.43f39fc6@gitrepo.freebsd.org> <87ecludxuh.wl-herbert@gojira.at> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:151847, ipnet:103.168.172.0/24, country:AU] X-Rspamd-Queue-Id: 4fV56X4DBJz3kgv X-Spamd-Bar: ---- On Mon, 09 Mar 2026 17:38:24 +0100, Andrew Turner wrote: > > > > On 8 Mar 2026, at 17:39, Herbert J. Skuhra wrote: > > > > On Tue, 03 Mar 2026 18:37:57 +0100, Andrew Turner wrote: > >> > >> The branch main has been updated by andrew: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4 > >> > >> commit c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4 > >> Author: Sarah Walker > >> AuthorDate: 2026-03-03 16:08:11 +0000 > >> Commit: Andrew Turner > >> CommitDate: 2026-03-03 16:29:15 +0000 > >> > >> virtio: Use bus_dma for ring and indirect buffer allocations > >> > >> While the majority of virtio platforms will be fully coherent, some may > >> require cache maintenance or other specific device memory handling (eg for > >> secure partitioning). Using bus_dma allows for these usecases. > >> > >> The virtio buffers are marked as coherent; this should ensure that sync > >> calls are no-ops in the common cases. > >> > >> Reviewed by: andrew > >> Sponsored by: Arm Ltd > >> Differential Revision: https://reviews.freebsd.org/D54959 > >> --- > >> sys/dev/virtio/virtio_ring.h | 27 ++++-- > >> sys/dev/virtio/virtqueue.c | 216 +++++++++++++++++++++++++++++++++++++------ > >> 2 files changed, 209 insertions(+), 34 deletions(-) > > > > After this change I see a lot of "kernel: vtnet0: watchdog timeout on > > queue xx" errors on amd64 (arm64 seems to be OK). > > > > Reverting this commit resolves the issue. > > Can you try the change in https://reviews.freebsd.org/D55766? It re-adds memory barriers for amd64. Yes, the patch seems to resolve the issue. Thanks.