Re: git: 0616521adc35 - main - ndp: Simplify and breakdown nd6_ra_input()

From: Pouria Mousavizadeh Tehrani <pouria_at_FreeBSD.org>
Date: Fri, 06 Mar 2026 12:30:59 UTC
Hi,

This is probably because of DAD.
Please see sys/netinet6/nd6_nbr.c:1252
Why now?
Because 6feb16b77e7df470c635bc3af65d448fd37deb10 was committed 
immediately after my commit.
I spoke with Gleb last night and we're aware of it.
So FYI, I'm working on DAD too.

On 3/6/26 3:44 PM, Bjoern A. Zeeb wrote:
> On Thu, 5 Mar 2026, Pouria Mousavizadeh Tehrani wrote:
> 
>> The branch main has been updated by pouria:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/? 
>> id=0616521adc35cb252cb399f1147f103284f0f188
>>
>> commit 0616521adc35cb252cb399f1147f103284f0f188
>> Author:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
>> AuthorDate: 2026-03-05 18:01:30 +0000
>> Commit:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
>> CommitDate: 2026-03-05 18:04:32 +0000
>>
>>    ndp: Simplify and breakdown nd6_ra_input()
>>
>>    `nd6_ra_input()` is simplied to make it easier to add
>>    additional options.
>>
>>    Reviewed by: glebius
>>    Differential Revision: https://reviews.freebsd.org/D55267
>> ---
>> sys/netinet6/nd6.c     |   8 +-
>> sys/netinet6/nd6_rtr.c | 300 ++++++++++++++++++++++++ 
>> +------------------------
>> 2 files changed, 158 insertions(+), 150 deletions(-)
> 
> 
> I am not sure which change (this or GRAND) triggers it but this is new:
> 
> Invoking IPv6 network device address event may sleep with 1 sleep 
> inhibitors
> stack backtrace:
> #0 0xffffffff80c2e36c at witness_debugger+0x6c
> #1 0xffffffff80c2fc79 at witness_warn+0x4c9
> #2 0xffffffff80df7a57 at in6_update_ifa+0xc67
> #3 0xffffffff80e24f1f at in6_ifadd+0x30f
> #4 0xffffffff80e214d6 at nd6_ra_input+0x1066
> #5 0xffffffff80df1520 at icmp6_input+0x5b0
> #6 0xffffffff80e0be35 at ip6_input+0xbb5
> #7 0xffffffff80d219a4 at netisr_dispatch_src+0xb4
> #8 0xffffffff80d0376a at ether_demux+0x16a
> #9 0xffffffff80d04cde at ether_nh_input+0x3ce
> #10 0xffffffff80d219a4 at netisr_dispatch_src+0xb4
> #11 0xffffffff80d03bb5 at ether_input+0xd5
> #12 0xffffffff80d53d12 at ieee80211_vap_deliver_data+0x32
> #13 0xffffffff80d87cbd at sta_input+0xc6d
> #14 0xffffffff80d6132c at ieee80211_input_mimo+0x20c
> #15 0xffffffff82f0f155 at lkpi_80211_lhw_rxq_task+0x135
> #16 0xffffffff80c20042 at taskqueue_run_locked+0x1c2
> #17 0xffffffff80c20f33 at taskqueue_thread_loop+0xd3
> 
> 

-- 
Pouria