git: 858f53dd43ec - main - Makefile.inc1: Don't force LLVM_BINUTILS off for cross-tools
Date: Wed, 04 Mar 2026 19:12:19 UTC
The branch main has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=858f53dd43ecb84cf2597229e9dbda2f242d9dd6
commit 858f53dd43ecb84cf2597229e9dbda2f242d9dd6
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2026-03-04 15:06:26 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2026-03-04 19:10:48 +0000
Makefile.inc1: Don't force LLVM_BINUTILS off for cross-tools
Because of this setting we were still using ELF Tool Chain tools for
buildworld. The sets of binary utilities are largely equivalent and
this went unnoticed after commit 1cae7121c667 ("Enable LLVM_BINUTILS
by default").
This was discovered recently because ELF Tool Chain objcopy produces
standalone debug files without phdrs and this caused an issue with a
3rd party ELF parser [1]. Remove the forced setting so that we use
LLVM's binutils to build the system.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=33876
Reviewed by: imp, jhb
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55650
---
Makefile.inc1 | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.inc1 b/Makefile.inc1
index c4696abae8cd..8a1958902db5 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
@@ -808,7 +808,6 @@ XMAKE= ${BMAKE} \
TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} \
MK_CLANG=${MK_CLANG_BOOTSTRAP} \
MK_LLDB=no \
- MK_LLVM_BINUTILS=no \
MK_TESTS=no
# kernel-tools stage