From nobody Wed Mar 04 11:17:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQqsL06sXz6TMt0; Wed, 04 Mar 2026 11:17:58 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQqsK6dpYz4MZc; Wed, 04 Mar 2026 11:17:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772623077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mCVLD0r416Xwv/XRTOgcPnDyTl+Lemr1QRxDT08Z6PU=; b=UvrdarsIAfXNowVoj9kpPKBoHJkkGqa98MDA6kQkq2ytbeL/1JD4Lz/K66bPKjSTq3/vjB 4niYzzzHGv9A0hTZuNfi8fXgPxL0K1kG0gEh69xswguFOPQ0XCcjYmve6vC3KSuJ6aqNJW 4Gs1anHZcorPv+CsktR9UX3eYkwS9hCedNhn04fdHrLvvqomAULmSQY3Tpe8ZpZzBvVgZ4 BudcWmy6TGxwaXDd3+o4EdbhfLJnDUSkvpXaH9qksuKoenHYrzaNKnZL9RNYMSDKez657G +ijDNToNCdgZiyinqJ2gIYj6Hviv2UmHyDZpuBxOIAUIyVIZPl9bJQue/CT7MQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772623077; a=rsa-sha256; cv=none; b=x2lyrFmL8I+9F6trN6ZtpoirI5YdEqGPq8HBT2jFg/oqUrWL+5mWrhJT3CKiiuWnjFzAI9 kDIXxdBHoknkPb4lA+E1/Ts/pnaoIFaKkWhzxljF6g8UZWrU15AeMfctRswp02/jWklMgE caoTsa5oQsgA/eSYCVNOtFs8JhtGr9gLv2q0trfmzsPoeMNueTYMRbIi4tcDTEwK4NK1VD /3pOL9JBElHYz51nFaQKaLDFkxNpS+Fir/q6iUvEPmX2e7OGgFc+TdeC3CNTqkfqT/yrvU h1WRCOMXfwQTJwe2rPgJ7Xed7rfMUAAqaiym7u/qMZVD231AI9DuzIGnrF2Ukw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772623077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mCVLD0r416Xwv/XRTOgcPnDyTl+Lemr1QRxDT08Z6PU=; b=Zt1MHZtGpnIX9QmWHOj2BvFq/SXdPIMlhSaQp5BwNbO3xPLIOrT7QtanXldQ1eh3lw8ktN H6e4hB5o1i2FqbPqBk30q13/oIPBHbRsU4bTYqzq7mEtvw85InBYBoMKcAmvIPr6FWR6NZ QCK6ojxmPx5YmFAXMI0/h9oDEZlpHa2wDE6MI2EleDwRngXnZTda6zKVuVBoQQBSEXd67H srMx9l4opZ3uYQ0GYn2oh0huuKPixinBpkkfPFC+49Ha5P9ax4tKcfMFQWvTji4b4goWQ4 z2Kw1IsNsqMtPQRLXtASxaZcQrJh4dIp2c6SvVTC8Zn3WnfuDtI1IETX0N+xrQ== Received: from mx-01.divo.sbone.de (legacy1.sbone.de [80.151.10.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fQqsK56C5z15DX; Wed, 04 Mar 2026 11:17:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 9EF75A64806; Wed, 04 Mar 2026 11:17:36 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id C3EE62D029E7; Wed, 4 Mar 2026 11:17:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id u5TAqIanGlTM; Wed, 4 Mar 2026 11:17:54 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 8CA052D029D8; Wed, 4 Mar 2026 11:17:54 +0000 (UTC) Date: Wed, 4 Mar 2026 11:17:54 +0000 (UTC) From: "Bjoern A. Zeeb" To: Warner Losh cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, Ali Mashtizadeh Subject: Re: git: e51ef8ae490f - main - hwpmc: Initial support for AMD IBS In-Reply-To: <69a215ee.34056.b6b1ce8@gitrepo.freebsd.org> Message-ID: <4157s999-p3p-4622-1pq6-6n69pr67s824@mnoonqbm.arg> References: <69a215ee.34056.b6b1ce8@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 27 Feb 2026, Warner Losh wrote: Hi, > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e51ef8ae490fc9f73191f33e7ad388c2511c454a > > commit e51ef8ae490fc9f73191f33e7ad388c2511c454a > Author: Ali Mashtizadeh > AuthorDate: 2026-01-30 09:12:17 +0000 > Commit: Warner Losh > CommitDate: 2026-02-27 21:22:16 +0000 > > hwpmc: Initial support for AMD IBS > > This patch adds support for AMD IBS. It adds a new class of performance > counter that cotains two events: ibs-fetch and ibs-op events. Unlike > most existing sampled events, IBS events provide a number of values > containing extra information regarding the sample. To support this we > use the existing callchain event, and introduce a new flag for multipart > payloads. The first 8 bytes of the pc_sample contains a header that > defines up to four payloads. > > Sponsored by: Netflix > > Reviewed by: imp,mhorne > Pull Request: https://github.com/freebsd/freebsd-src/pull/2022 > --- > lib/libpmc/libpmc.c | 64 ++++- > sys/amd64/include/pmc_mdep.h | 5 + > sys/conf/files.x86 | 1 + > sys/dev/hwpmc/hwpmc_amd.c | 25 +- > sys/dev/hwpmc/hwpmc_ibs.c | 614 +++++++++++++++++++++++++++++++++++++++++ > sys/dev/hwpmc/hwpmc_ibs.h | 176 ++++++++++++ > sys/dev/hwpmc/hwpmc_mod.c | 96 ++++++- > sys/dev/hwpmc/pmc_events.h | 13 +- > sys/i386/include/pmc_mdep.h | 5 + > sys/modules/hwpmc/Makefile | 4 +- > sys/sys/pmc.h | 19 +- > sys/sys/pmclog.h | 14 + > sys/x86/x86/local_apic.c | 27 +- > usr.sbin/pmcstat/pmcstat_log.c | 99 ++++++- > 14 files changed, 1130 insertions(+), 32 deletions(-) can someone clarify is this is/will be needed or why is was added but not used? /sys/dev/hwpmc/hwpmc_mod.c:4597:1: warning: unused function 'pmc_is_multipart' [-Wunused-function] 4597 | pmc_is_multipart(struct pmc_sample *ps) | ^~~~~~~~~~~~~~~~ -- Bjoern A. Zeeb r15:7