Re: git: 1f2f5eba24aa - main - asmc(4): pull 32-bit support for the driver
- In reply to: Dag-Erling_Smørgrav : "Re: git: 1f2f5eba24aa - main - asmc(4): pull 32-bit support for the driver"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 01 Mar 2026 07:49:41 UTC
> On Feb 28, 2026, at 5:24 AM, Dag-Erling Smørgrav <des@FreeBSD.org> wrote:
>
> Enji Cooper <ngie@FreeBSD.org> writes:
>> commit 1f2f5eba24aa53e180a4eb46b772410e5a782469
>> Author: Enji Cooper <ngie@FreeBSD.org>
>> AuthorDate: 2026-01-05 03:36:55 +0000
>> Commit: Enji Cooper <ngie@FreeBSD.org>
>> CommitDate: 2026-02-27 19:44:08 +0000
>>
>> asmc(4): pull 32-bit support for the driver
>>
>> The asmc(4) driver should work for 32-bit Intel-based Macs, in theory, if
>> the model details were added to the detection list. That being said,
>> 32-bit Intel Macs were only released and available to the general public
>> for 8 months [1], so the value in maintaining i386 support in the driver is
>> reduced due to limited hardware access.
>>
>> Remove 32-bit support for the driver officially to make it clear its use is
>> not supported.
>>
>> This should fix building `NOTES.i386` by proxy as well.
>>
>> Relnotes: yes
>> MFC after: 2 weeks
>> Fixes: f224591746b ("Add ASMC_DEBUG make option")
>> Fixes: 8342d9f7b5f ("asmc(4): Stop building it on i386, as...")
>> Differential Revision: https://reviews.freebsd.org/D55544
>
> Please remember that the bugs this fixes have already been merged to
> stable/15 and stable/14.
Oof — fair. I’ll wait a 3 days instead of 2 weeks and merge.
-Enji