From nobody Sun Jun 28 10:46:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gp5gH2Qnlz6k0QB for ; Sun, 28 Jun 2026 10:46:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gp5gH0HKDz3mxC for ; Sun, 28 Jun 2026 10:46:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782643579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KUkcSwoS+oC3hYgMY0WHeX3KR0emAwRt76r4z3cxzeA=; b=ilUC5I+dmUxulHkmqA7FV9KTsRa1Nk/OHqPS0cY2aAwVmoJ3NuARZgGjctH+9U8y5H//tl 0wGytsU6w7b+k1JV4rZVFb4cpVOjHoZXwsLj98zv6h7BWuNH9eZaX/jkrMUaWxUPXlLcCz RAurYU4/esbOtI7aYTwZYU4AchJs9IrC+/ynFduGR9Jaeuh8EpHMLlFPs/Z94cftVCbyN9 JEu17bvKKbmjhKJ14oMyABkrWeM2b/85Hk0CtVCvt5kiR5+EZsXEK4VgqAHDBaMlSDO1JP JB8cQLaf/SFhLHKpxnzy0or6l9IHlU/eYsrK/5HZ14OMcVDL3OxC7gaXt7ZF/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782643579; a=rsa-sha256; cv=none; b=id1zhaIG7kRwRw7HGMZ3Tq1g4cnEvl2SEf+qw5YwKfdz3Xq8a6AQAW5x5TLvNEOxjmgdvi YBY+7ctPWMOkrFqFT9MSdzpWFjMGwkkJ6qC+0/oBmfhOsZOII36RZpMYbmbrfbEn97EOkb wTcSFgxKxNoF/a8VCuDRAsFhqOzHySDM+2E9OVqB3gAyfZOQVGVTM3JVISg0VbPbBQoQtG 7ZQjwOYGqpsxaEd/Wy8ZGD2/KOXEo3VwbAJz15L3FF4H49/cFSDpsphuwa3EApeGgnY/5z 98FgLiVriJiKYfwsRjvXKkpKYREmZvdQiEdZBH1/DzqdM0R1WOtAj81ZhL+xkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782643579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KUkcSwoS+oC3hYgMY0WHeX3KR0emAwRt76r4z3cxzeA=; b=ZjpLde95DnQi4UL2JAVdr/iDuHeV01V1lJjRLoUjBEWsiK4XWw8OFi/OLPAPSjztIbst22 OnptgT/16bzP8HSZyfj05pNfXkE4PsaZTtIq9+rIo4XPE1NpuNo5DY+pfT7FR/CKC9y08/ qqSSsJn5tr7XXnKYWN+dY/sJ3pDnBPT5GCDu8jsmlameN7RJ3LzmzMIGh7BYTU2VEOTN+Q g4U6CeqGY7z7wdqNlYSlpkp00Nj5Qbtzpcn0VcFz6xOAGptpZ5O+OtYk/c31elvFSncmuD 8EuBFjps0B6MquM1NuWF6mCxxVCqPoJeLQWZMwU9rexj+hsgrbuuSlC1FCfnUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gp5gG6LxJz165R for ; Sun, 28 Jun 2026 10:46:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 379e2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 28 Jun 2026 10:46:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Timo =?utf-8?Q?V=C3=B6lker?= From: Michael Tuexen Subject: git: 07b5d1ca52b1 - main - virtio_pci_modern: Remove endianness conversion for config space List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 07b5d1ca52b113cecad3cda73ff5e782d8f4d07d Auto-Submitted: auto-generated Date: Sun, 28 Jun 2026 10:46:13 +0000 Message-Id: <6a40fb75.379e2.36d824d9@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=07b5d1ca52b113cecad3cda73ff5e782d8f4d07d commit 07b5d1ca52b113cecad3cda73ff5e782d8f4d07d Author: Timo Völker AuthorDate: 2026-06-28 10:39:10 +0000 Commit: Michael Tuexen CommitDate: 2026-06-28 10:39:10 +0000 virtio_pci_modern: Remove endianness conversion for config space The bus_* functions already handle converting from PCI endianness (i.e. little-endian) to native endianness when accessing the config space (see ofw_pcib_bus_get_bus_tag), so converting again with virtio_htogX/virtio_gtohX undoes any byte-swapping and breaks big-endian systems. They should only be used for operating on shared memory. Note part of this reverts commit fb53b42e36a9 ("virtio-modern: fix PCI common read/write functions on big endian targets"). PR: 294706 Reviewed by: adrian, tuexen Fixes: fb53b42e36a9 ("virtio-modern: fix PCI common read/write functions on big endian targets") Fixes: 9da9560c4dd3 ("virtio: Add VirtIO PCI modern (V1) support") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57392 --- sys/dev/virtio/pci/virtio_pci_modern.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/virtio_pci_modern.c index baf7c448bb95..bdd9cacd505e 100644 --- a/sys/dev/virtio/pci/virtio_pci_modern.c +++ b/sys/dev/virtio/pci/virtio_pci_modern.c @@ -665,16 +665,13 @@ vtpci_modern_read_dev_config(device_t dev, bus_size_t offset, void *dst, *(uint8_t *) dst = vtpci_modern_read_device_1(sc, offset); break; case 2: - *(uint16_t *) dst = virtio_htog16(true, - vtpci_modern_read_device_2(sc, offset)); + *(uint16_t *) dst = vtpci_modern_read_device_2(sc, offset); break; case 4: - *(uint32_t *) dst = virtio_htog32(true, - vtpci_modern_read_device_4(sc, offset)); + *(uint32_t *) dst = vtpci_modern_read_device_4(sc, offset); break; case 8: - *(uint64_t *) dst = virtio_htog64(true, - vtpci_modern_read_device_8(sc, offset)); + *(uint64_t *) dst = vtpci_modern_read_device_8(sc, offset); break; default: panic("%s: device %s invalid device read length %d offset %d", @@ -700,17 +697,17 @@ vtpci_modern_write_dev_config(device_t dev, bus_size_t offset, const void *src, vtpci_modern_write_device_1(sc, offset, *(const uint8_t *) src); break; case 2: { - uint16_t val = virtio_gtoh16(true, *(const uint16_t *) src); + uint16_t val = *(const uint16_t *) src; vtpci_modern_write_device_2(sc, offset, val); break; } case 4: { - uint32_t val = virtio_gtoh32(true, *(const uint32_t *) src); + uint32_t val = *(const uint32_t *) src; vtpci_modern_write_device_4(sc, offset, val); break; } case 8: { - uint64_t val = virtio_gtoh64(true, *(const uint64_t *) src); + uint64_t val = *(const uint64_t *) src; vtpci_modern_write_device_8(sc, offset, val); break; } @@ -1312,15 +1309,13 @@ vtpci_modern_read_common_1(struct vtpci_modern_softc *sc, bus_size_t off) static uint16_t vtpci_modern_read_common_2(struct vtpci_modern_softc *sc, bus_size_t off) { - return virtio_htog16(true, - bus_read_2(&sc->vtpci_common_res_map.vtrm_map, off)); + return bus_read_2(&sc->vtpci_common_res_map.vtrm_map, off); } static uint32_t vtpci_modern_read_common_4(struct vtpci_modern_softc *sc, bus_size_t off) { - return virtio_htog32(true, - bus_read_4(&sc->vtpci_common_res_map.vtrm_map, off)); + return bus_read_4(&sc->vtpci_common_res_map.vtrm_map, off); } static void @@ -1334,16 +1329,14 @@ static void vtpci_modern_write_common_2(struct vtpci_modern_softc *sc, bus_size_t off, uint16_t val) { - bus_write_2(&sc->vtpci_common_res_map.vtrm_map, - off, virtio_gtoh16(true, val)); + bus_write_2(&sc->vtpci_common_res_map.vtrm_map, off, val); } static void vtpci_modern_write_common_4(struct vtpci_modern_softc *sc, bus_size_t off, uint32_t val) { - bus_write_4(&sc->vtpci_common_res_map.vtrm_map, - off, virtio_gtoh32(true, val)); + bus_write_4(&sc->vtpci_common_res_map.vtrm_map, off, val); } static void