Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status

"Siva Mahadevan" <siva@FreeBSD.org> writes:
> If it is incorrect, my apologies, but I'm not sure in which way. I wrote
> this from what I understood from the comments in the associated
> reviews[0][1].

You ignored this:

  https://ron-dev.freebsd.org/FreeBSD/src/pulls/50#issuecomment-853

and this:

  https://reviews.freebsd.org/D57884

and misrepresented the parts you did not ignore.

1) ping was incorrectly mixing buffered and unbuffered I/O on the same
   descriptor (standard output), which is not permitted by the standard
   and results in undeterministic output.

2) My first commit to ping had the side effect of changing the ordering
   of ping's output in the conditions established by the test, causing
   the test to fail.  This is not a bug in my commit, it is a bug in the
   test, which assumes deterministic output from a non-determinstic
   program.

4) My second commit changed ping to guarantee determinstic output in all
   cases.

5) Your commit changed the test to expect the output which ping now
   deterministically produces.

> Can you suggest a better commit message? And I'm not sure it warrants a
> revert and re-commit.

The current message is pure fiction, reverting and re-committing is the
only way to correct the record.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org