git: ad26a56cf2f5 - main - acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 26 Jun 2026 15:24:09 UTC
The branch main has been updated by olce:
URL: https://cgit.FreeBSD.org/src/commit/?id=ad26a56cf2f55967cc73d04a6ea17c27892d3141
commit ad26a56cf2f55967cc73d04a6ea17c27892d3141
Author: Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2026-06-26 15:21:41 +0000
Commit: Olivier Certner <olce@FreeBSD.org>
CommitDate: 2026-06-26 15:23:43 +0000
acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean
Same reason as for the previous commit to acpi_cpu(4). This boolean is
not used anywhere. Disabling acpi_timer(4) can be done through the
regular ACPI disable mechanism (using the 'debug.acpi.disabled' tunable,
see acpi_disabled()).
Reviewed by: emaste (implicit)
Fixes: ac3ede5371af ("x86/xen: remove PVHv1 code")
MFC after: 3 days
Event: Halifax Hackathon 202606
Location: Dalhousie CS Faculty building
Sponsored by: The FreeBSD Foundation
---
sys/dev/acpica/acpi_timer.c | 6 +-----
sys/x86/include/init.h | 3 ---
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/sys/dev/acpica/acpi_timer.c b/sys/dev/acpica/acpi_timer.c
index 84d9fb8e6ac8..08bfa292bf90 100644
--- a/sys/dev/acpica/acpi_timer.c
+++ b/sys/dev/acpica/acpi_timer.c
@@ -64,9 +64,6 @@ static eventhandler_tag acpi_timer_eh;
static u_int acpi_timer_frequency = 14318182 / 4;
-/* Knob to disable acpi_timer device */
-bool acpi_timer_disabled = false;
-
static void acpi_timer_identify(driver_t *driver, device_t parent);
static int acpi_timer_probe(device_t dev);
static int acpi_timer_attach(device_t dev);
@@ -125,8 +122,7 @@ acpi_timer_identify(driver_t *driver, device_t parent)
ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
if (acpi_disabled("timer") || (acpi_quirks & ACPI_Q_TIMER) ||
- acpi_timer_dev || acpi_timer_disabled ||
- AcpiGbl_FADT.PmTimerLength == 0)
+ acpi_timer_dev || AcpiGbl_FADT.PmTimerLength == 0)
return_VOID;
if ((dev = BUS_ADD_CHILD(parent, 2, "acpi_timer", 0)) == NULL) {
diff --git a/sys/x86/include/init.h b/sys/x86/include/init.h
index 42b194de26b9..200a90d31b5e 100644
--- a/sys/x86/include/init.h
+++ b/sys/x86/include/init.h
@@ -43,7 +43,4 @@ struct init_ops {
extern struct init_ops init_ops;
-/* Knob to disable acpi_timer device */
-extern bool acpi_timer_disabled;
-
#endif /* __X86_INIT_H__ */