From nobody Wed Jun 24 17:01:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glpBx5Tksz6jVZ8 for ; Wed, 24 Jun 2026 17:02:17 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glpBx1jGCz3Snh for ; Wed, 24 Jun 2026 17:02:17 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-697cee2eb6dso1265681a12.0 for ; Wed, 24 Jun 2026 10:02:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782320536; cv=none; d=google.com; s=arc-20240605; b=BOAIBQ6g48EI6AGpB1Xhnj2euSafFwlRA8i2uRXPIZO+jWS46FflbLEyHWdggmMkh3 ReB51Q/1h8VC0ZqL6SvNCEwGyTTdPVerUbBoqqavrEJKl/FpFLMY+H0OKlk88uD9ri9Z 7xow+lLyFYrzkDGGKcPK6gr18HTzU5MK1zccRz/8v/njOv8iamnyKd6M0a72ysQrZzjp RZz7oQo/Z0gdyARMHyupeMsumZFSXmgAAF6XLs/x8qXFIfild23BrI32YG9lSkPFzvRS KYQ1/LljRk64jwySkGjiZzyqveJnPNWRIDHu+B4TWcHM7B0Pm0/M8LDURc6+YYZX6j4i cqFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=te4acumv/2JBGZ4yo3SrgmF8G7CBCx/ga5cx7UHlbIk=; fh=TKBReMdlUWafF7G1IsVRpZYAoQoZcLLQFpCKL4Sxo1U=; b=QIYxcQxRdre3yhwlHOuZefaYiT/43iH9Kr5pIwRP7lt7ScgnQzXEwMuJNtWJtp3u1A 3ecRBvDEFV2Dj9N/XphMI/o874RYYlE+5Uek3De8yxnqRk69uIUhuEsAe9xFgcN+p2qA W4gd0qHXq+XP89T36GyLFSZVVzdnWmzZ+Nq+9NM/cR2AF3+3GM/Bit9FWSBhf76OfEDT g5Iuqk0LM9c+DijbBJfNTFSZqeNtZ3bJmMJQQZ870ZKCL3J9XoU4jsBdIhvyZO8/DhCL EEO86xQaNgVZyMq1fMkpRbB/8l73LECjJo444QFC3lCPvgLBn7xpgjfARIQf3Hej5yew ygNw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782320536; x=1782925336; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=te4acumv/2JBGZ4yo3SrgmF8G7CBCx/ga5cx7UHlbIk=; b=I/ISv/R5RdUMpqOVPm9rO4qtC9jOtj/aVjI9ppDyllhIJrwbCVE+Ypc2poBIPbBzD7 koj7k/ryN77I1TENO0In7WgTr60JDUC2R/QszjVlqIwowxC0V+3fMdXtewObTrPoodup iXKYF4VrzQVngZvEsqLiQLZ+zgeTOvDDf5Hf+bFGT5zYmTP6Jei9Ya1f9/qK4MH+gESF QnZ97GEfFzLbKs1+ndqyQji9TWgDQL8NqNfkNuc7aN3oXmQfSEtbyYIOwSztcQyaJRf5 7EEeb4AjaKdD9U8GlqqOh32CUn8mjd+P1Tm140tzrQsqd4Ne78fT4QGOy7lSy28uldQl 3hgw== X-Forwarded-Encrypted: i=1; AHgh+RqOfZ9SfIdC44HJmvsgk8wfY3ouZV+MQ3RtcfTfzDCDM7sd7ojnl2NxrFkJC73QC7GVczGu94R3AyeFZ/TRrHPwA09M@freebsd.org X-Gm-Message-State: AOJu0YzJhmmz7ksMI2qtuReEAXF5JFuLPgHcxAwgfGWIUzhrLIwQayqD a87YgAbUdoEe1HBiA2i0Cbjcg7SJW9fmMwcvhHnoU0zFiYAUI47fGqgNf1Lw48hc7IvtiIpjbxv vAuX8ZgFFbOai4S7I1Uc/MlMLQPUbeTo= X-Gm-Gg: AfdE7cmmv+ZZ3GnOzvQ2lIjjATsbMXAvht5Gr3yUwir98oNnDz4XwvjUVw4cz3zPB1v 1+7KgNzLPL/MVl/KzljgJpCqd6bCL2DLSaNRBySCwpyf5IM5ndRC9IWktebYQV/njvqm1XhFCcN dWiUQYHKJqfpa2OZnwG5y1zmlxwV0z4Hi24Vds567KbX+sin6gHUas0xvYOCtCC/6bkVfvS7/Xd SAl9zdEkOHX2aJIkKaG8ol1r9oUNtsVfeewjtLMj7L72nv7dnH25wdXfsSIEtlAA2rnBLw3ZdV4 rv6n2pH/oLCKClv1TaPKCRER5LlTpxHzs+pf+IUl3s7t6tkeaUvAp3qXZPrQzZ0/RLxg X-Received: by 2002:a05:6402:2349:b0:697:6226:f39c with SMTP id 4fb4d7f45d1cf-697f386f60cmr2653709a12.1.1782320518259; Wed, 24 Jun 2026 10:01:58 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> <9998a345-f864-466b-ac38-8603fc5ff359@FreeBSD.org> <4827de8d-ffbf-415a-aeca-4ec383dab315@FreeBSD.org> In-Reply-To: <4827de8d-ffbf-415a-aeca-4ec383dab315@FreeBSD.org> From: Alan Somers Date: Wed, 24 Jun 2026 11:01:45 -0600 X-Gm-Features: AVVi8CfcBIeqWDYHqoVUMFzHeK1se2QEfB9FdiIdVIbACJamdaLZVsbBbuAHWx4 Message-ID: Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally To: Bryan Drewery Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4glpBx1jGCz3Snh X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Wed, Jun 24, 2026 at 10:49=E2=80=AFAM Bryan Drewery wrote: > > On 6/24/26 9:45 AM, Bryan Drewery wrote: > > On 6/24/26 9:33 AM, Alan Somers wrote: > >> On Wed, Jun 24, 2026 at 10:04=E2=80=AFAM Bryan Drewery > >> wrote: > >>> On 6/23/26 7:54 AM, Alan Somers wrote: > >>>> The branch main has been updated by asomers: > >>>> > >>>> URL: > >>>> https://cgit.FreeBSD.org/src/commit/?id=3De03ed9daeb49fffa1d16b8d002= 40c65e92650d01 > >>>> > >>>> commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 > >>>> Author: Jitendra Bhati > >>>> AuthorDate: 2026-06-12 17:07:55 +0000 > >>>> Commit: Alan Somers > >>>> CommitDate: 2026-06-23 14:53:56 +0000 > >>>> > >>>> fts: refactor to use fd-relative operations internally > >>>> > >>>> Replace all _open() calls with _openat() in __fts_open(), > >>>> fts_read(), > >>>> and fts_children(). > >>>> > >>>> Add fts_dirfd to FTSENT. Callers can use > >>>> openat(ent->fts_dirfd, ent->fts_name, ...) to access files > >>>> safely without relying on fts_accpath, which enables: > >>>> > >>>> 1. Capsicum capability mode where path-based operations fail > >>>> 2. Security-sensitive programs that avoid TOCTOU races > >>>> > >>>> Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in > >>>> fts_ufslinks() when fts_dirfd is valid, falling back to > >>>> statfs() for > >>>> root-level entries where fts_dirfd is -1 > >>>> > >>>> This is a preparatory change for fts_openat() which will allow > >>>> callers to provide a pre-opened directory fd, enabling fts(3) > >>>> traversal inside Capsicum capability mode. > >>>> > >>>> Sponsored by: Google LLC (GSoC 2026) > >>>> Reviewed by: asomers, jillest > >>>> MFC after: 2 weeks > >>>> Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 > >>> Someone on IRC reported they bisected a Poudriere breakage to this > >>> commit. > >> Really? I'd be interested to see that log. Also, Jitendra is already > >> working on the fix. > >> > > I asked for more details but haven't heard back yet. It is probably > > because Poudriere ships static binaries so is hitting the ABI break. > > > > > Sorry for the spam. I misremembered, it's not static but they are > pre-compiled dynamic binaries expecting libc to match the headers built > with. Ok, I've reverted it for now. Sorry for the breakage.