From nobody Wed Jun 24 16:46:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glnsK0jNHz6jT3r; Wed, 24 Jun 2026 16:47:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glnsK02kFz3MLT; Wed, 24 Jun 2026 16:47:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782319621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ctuH/OOXoQc5U/PFeZBjkjIxr+kIdqKROnRIf73/LI=; b=uk2KTWYFYAbp09Fz3q3jezLLRgc5kGZEhlC/TsB5dyQkKwjZEKUwNantTLSwpgB+bvZlUr Mede9BflJKNu1I3mbIY//qVYt0NC2EBiiDh1PQaVqXq4idrkr3PvFTPuppHN3NO61Tgf5w R5vEa6p0vig08TLBGi0KNP3a+tw7iuVVKzm9RbO2HdeI7nVAvbZU9VTXg4IERJR8N+gkVi 7rhCvY6Wr26dK/tGU+iWb2i1kI0gEcXP/N3nmNK8lunSylmTHhrtTzAdPq7dSvcZfj8e24 4KlvAHAXkjAEW8ICljmxk9asrDIv5CDWMt48VgSneZldANEcma+4eYmJ5QMobw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782319621; a=rsa-sha256; cv=none; b=rh4dyt2GpWGuC1axg8WvIQIjOJK6MNaLjB99dfbtsq6sGC5A7szw/ecTYylc05RDgrWiHy UEBT2GJAEdlXiooBvbdSj+6VjMXC1uBPF8Vn36+z4arSE751IzbguJFhubO7TX7rUpHfRS 3jwX8IzfSqJyjkem5rYzOkgKjRpT5v3CZc8TYNbEQhkVomyDPDbTb2PYtPLACVTmKpcXWX 460yr0e5Xh1RDNoc4vQ/QNpxQEeOIpceazZhsTfd/KEjqbmZ2EvxGl0JCdFkDFWoifySsa Qzv8/v2YeFT6PC7zRZLBEKMzq1dXOv1Yn1UU/ek6Z3NlRueL7ZDIPbTZicTx0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782319621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ctuH/OOXoQc5U/PFeZBjkjIxr+kIdqKROnRIf73/LI=; b=hVkfHUJvVPvnt4sKJSB4Lgo8e2o4qy6HbdF1hBJMMJVUkcZosT7H/15ngoCHJIG0N4UUi0 onpQg106FxXW/+0dhW4drr0UiJFSrJqiB4bgrkpHICqVC8GGwmt2V/N9YKyGqJyxSSs0b4 x/COLgcHGo2V5Npu5cubZftUtosEbePjT9IpqZ8olkYhT68RSw90p/1bTmrs+JQbIG2m0n GtMAG+rwuwiFXQ80lYN2XyP4+alalU46rVNJmUXC0j3+QOEOIYarCr+XC3C2pFwV9nMJ8G lmgkPn/EzuPERNU37J/YJ7K/b0bShwtBTpmIzb+NVxqgtMSIPshT9W4O56cpyQ== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id CF79718FBD; Wed, 24 Jun 2026 16:47:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from localhost (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 4BFB49870; Wed, 24 Jun 2026 09:47:00 -0700 (PDT) X-Virus-Scanned: amavis at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by localhost (mail.xzibition.com [172.31.3.2]) (amavis, port 10026) with LMTP id HsfcBkleA4RL; Wed, 24 Jun 2026 09:46:57 -0700 (PDT) Message-ID: <85bf3f7f-d41e-40e7-8ea0-a92259503a9a@FreeBSD.org> DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com B3024986D Date: Wed, 24 Jun 2026 09:46:57 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> Content-Language: en-US From: Bryan Drewery In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/24/26 9:33 AM, Alan Somers wrote: > On Wed, Jun 24, 2026 at 10:04 AM Bryan Drewery wrote: >> On 6/23/26 7:54 AM, Alan Somers wrote: >>> The branch main has been updated by asomers: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=e03ed9daeb49fffa1d16b8d00240c65e92650d01 >>> >>> commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 >>> Author: Jitendra Bhati >>> AuthorDate: 2026-06-12 17:07:55 +0000 >>> Commit: Alan Somers >>> CommitDate: 2026-06-23 14:53:56 +0000 >>> >>> fts: refactor to use fd-relative operations internally >>> >>> Replace all _open() calls with _openat() in __fts_open(), fts_read(), >>> and fts_children(). >>> >>> Add fts_dirfd to FTSENT. Callers can use >>> openat(ent->fts_dirfd, ent->fts_name, ...) to access files >>> safely without relying on fts_accpath, which enables: >>> >>> 1. Capsicum capability mode where path-based operations fail >>> 2. Security-sensitive programs that avoid TOCTOU races >>> >>> Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in >>> fts_ufslinks() when fts_dirfd is valid, falling back to statfs() for >>> root-level entries where fts_dirfd is -1 >>> >>> This is a preparatory change for fts_openat() which will allow >>> callers to provide a pre-opened directory fd, enabling fts(3) >>> traversal inside Capsicum capability mode. >>> >>> Sponsored by: Google LLC (GSoC 2026) >>> Reviewed by: asomers, jillest >>> MFC after: 2 weeks >>> Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 >> Someone on IRC reported they bisected a Poudriere breakage to this commit. > Really? I'd be interested to see that log. Also, Jitendra is already > working on the fix. > Also I think this should be reverted ASAP unless the fix is landing soon. This is going to hit more people and maybe even the official builders quickly.