git: b6564c32ea98 - stable/15 - ctld: Ports without a portal group are not dummy ports
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 23 Jun 2026 16:28:13 UTC
The branch stable/15 has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=b6564c32ea988f738bdab11857b87f34b8189dd6
commit b6564c32ea988f738bdab11857b87f34b8189dd6
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2026-04-23 19:16:08 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-06-23 16:05:56 +0000
ctld: Ports without a portal group are not dummy ports
The default implementation of is_dummy should return false. Only
portal group ports should possibly return true.
PR: 293076
Reported by: Ken J. Thomson <thomsonk@yandex.com>
Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes")
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D56524
(cherry picked from commit 3df5cc33d894edd6b0ae87e51f0e35c3501fb907)
---
usr.sbin/ctld/ctld.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usr.sbin/ctld/ctld.hh b/usr.sbin/ctld/ctld.hh
index a88ef7eac96e..fdd70a37c514 100644
--- a/usr.sbin/ctld/ctld.hh
+++ b/usr.sbin/ctld/ctld.hh
@@ -271,7 +271,7 @@ struct port {
virtual struct auth_group *auth_group() const { return nullptr; }
virtual struct portal_group *portal_group() const { return nullptr; }
- virtual bool is_dummy() const { return true; }
+ virtual bool is_dummy() const { return false; }
virtual void clear_references();