From nobody Sun Jun 21 21:48:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gk4hJ5LDxz6hrbS; Sun, 21 Jun 2026 21:48:16 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gk4hJ4LTPz4109; Sun, 21 Jun 2026 21:48:16 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782078496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5q6SRGR3l4TW4InuUPf5oWm2aim30zMpLMGBGQPMZc=; b=tOBqnBNqaGwvL5G1zw18he2ZJ04jEJbq8t8wcSsM0pQN/NFhDM9XsIHJlzOHlFPEhHqE58 8jZsR46xJuXUy6ogpf7DTj47jAI606yfO149FaIUK1j1MMvAhnHoQe2BjAOKVXTrIWfDqX vol93CSJ89Ejrd3C3BohidouGfzF4VNsQipXpwyNEzB/O2gex2f19Tb23BPB/gPoLv1jT2 tA96LDcU9Xn/TLeeUMdLkHnzUrjjbF0jgR3SaGvUF/LvPG8bBICkQhyTkgN4ryhQgAduG8 pclB4P4vBn3Cr+fep9+ACe1Elu+c5DyP/lvgjKnYMpCmDdGr994TMQ42yzfufA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782078496; a=rsa-sha256; cv=none; b=GIJ6LYAn9PmmVrCrSEl3hvjGa/4lBCbaYgr+88SdS/fcmuHHlXihbhNCw54KtO0AtlghtR JL19e0cTkUrQLIjiIzLIqbQmbCVtpeQvJIZJD1igw6Vnjf3xfSCF/yWG3wyl+gbfb9mg8d 4G9O4Kx5TN7uALrMR0JPYDlQpYuwcGVbBEg+KsCIKapO5oST0i8V0CsPqgTD3nz1rttNJg gCGBUYjL5uHep2PK8pMbOwq22dTIOsyKa5cDWRevi9M91dSurrOXOJ7TdfBdKOujUwCj8a ND1BKcZQQ8pyRfDnQuJwY/PL73sCi2I+MVJtn6PoMz84zm7MBgwCvxJ+5Iot0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782078496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5q6SRGR3l4TW4InuUPf5oWm2aim30zMpLMGBGQPMZc=; b=j2gfhXjP9FTy2khvSQSz2I40E9j7uInWKjQjfZWJnc9P6UrF235h+h51l/dC9V94fvrg69 mVO4xPF5/DSewg19JSI5BuMfjR8p6XY2QGlwruv+YMkJnvFcsn1iWkWZSUAcle20T4TRHZ MEs81cVe2CHCazYAwfH93xP0tXTIcm1pErXbG/Z3e3icNVFzCe+buIDAhVcQYAjyqPLnVf 7EmziHOmQmI/LlBk9UXHDhLyRneXorGvHskIcBSlGj1ZufmpIwLrxV0IjGhFzzFtLDFyzD ScxuqV9KoiFAhBypX6nNO0DlOdiJOnjB5Hhy5FfcECQp9NG/18ISGkaFeZfbUw== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:8941:cb00:bd62:68b4:6301:20d7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gk4hH3prxz17C1; Sun, 21 Jun 2026 21:48:15 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sun, 21 Jun 2026 23:48:12 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Konstantin Belousov Cc: Faraz Vahedi , Warner Losh , alc@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d87c1aac4a8 - main - libc: Add missing kill_dependency macro Message-ID: <20260621234812.08eb82dc@hal.tijl.coosemans.org> In-Reply-To: References: <6a35ddd4.24ba1.2ad9343d@gitrepo.freebsd.org> <9A21692F-0B53-4303-85A8-57784BFAF8DE@kfv.io> <33E8BFC4-EA46-41A7-B54F-1AADD3C19D9E@kfv.io> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 21 Jun 2026 13:13:50 +0300 Konstantin Belousov wrote: > On Sat, Jun 20, 2026 at 11:50:50PM +0330, Faraz Vahedi wrote: >> Hey, >> >> I see. I dug further into related proposals and the reasons why no >> compiler today has implemented true data dependency tracking >> and that they all basically map and promote consume to acquire. >> The kill_dependency is also basically a no-op, and both compilers >> optimise them identically. I did a few tests on my AArch64 box and >> that's how I'm convinced, so I believe keeping the current form >> could be ideal as it fully conforms to the standard and we're assured >> that at least any conforming compiler would support it just fine and >> there's no extension or non-standard tweak in it. On the other hand, >> although adding a separate branch with the GCC style is possible, I >> don't think that'd add any value but visual complications. >> >> Either way, whether dependency tracking changes drastically or this >> very approach becomes obsolete, keeping our header as-is seems >> safe for now. > I am fine with it then. My concern was in subtle breakage of the > code compiled with gcc. I think the GCC definition just enforces that Y and kill_dependency(Y) are expressions so things like the following produce an error. if kill_dependency(foo);