From nobody Sun Jun 21 11:48:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjqMz6p0Zz6jZhJ for ; Sun, 21 Jun 2026 11:48:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjqMz23mMz3WBg for ; Sun, 21 Jun 2026 11:48:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782042495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xxD/8MiJYr2qyyDpbhdRIDcJbYnFhTezFXSsICp4hIM=; b=KdQq6S1HM31N22T2FeE7SNjA+caecJTyhEcgEFWjDJPFxBZ3zzF6hx6Cdl2oxTdH04CDmT C/Av2uxA3wMXL/bsGxybYZX2FkCsFirO2K6uZgMG1aAZJ4w3+iBitkaX+js5NLZDteV6s3 7fPjOe1alJmP/I2SHOo4wV71RrXEpYRFPSBnZHdI26x457KNsu4Mzsd7D6YGURCoOtCRO/ Plqnp3FjU/gG31JWgFnM/NLZEVJs3oBx+wIFsV0MKudIwSzBMiHC7eR8H6R1DW1GLQK+WW 2iOn4RREGnn3DAJRI59/KV4kJjk8D+qW+DKVMCi/MsfQa1FcOH0MRqTTdryp0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782042495; a=rsa-sha256; cv=none; b=WulqH9z5ZXacatM0pJu9gJwgLmmUfyhHieIo7qmrHbGBbuYn6IrfZK24jfSxQrrj6Hrkis 0SmzFTzbaFwkSCDZGqeTOazW28NDE+Sn7C6tlbdSsvCS7p/f1wJTl6H7S38oUcmhA2F2t8 YsZ5+nPzPl0+DAEMEmHAnAqnc06/fN6KRFO39GSbiyE4A2rXw8XfcPnj6fgXcO9+PsoaiT RkJ4llJ3PdrPMDvHb9jZxeD0umHLamYqrSCUzlfJeOA10iggTobkgQ9t/U4Er34VIjuzQ1 JE7Qy1B/e6aDAD71jw+azRWFnC3jux7lx/AqT5nFl08SPai4pJYYsXpLjkZDNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782042495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xxD/8MiJYr2qyyDpbhdRIDcJbYnFhTezFXSsICp4hIM=; b=lo5TIP9ZjSreBuUk7Eobh5mwuYGQLF+EK/BACYN6uDWylR1btV2dEcI5xQEX2rtIjq2QP2 6f9FhM5CwKJQNnK0GsdRVretGxStC8WesZ9gfJD+qtePJnCPGToMeO1I8IQlMCFEf/yN5P wf0NX3xind9e2QaNJotW++WvcMHZqgyukIEagwghni89KMPj/yg+AqnmzeQsPFVZZ/S4gX D/JOV7vBCjwxNLskPsEYXUOBo/QL3z0kZwgGqUnqigHQuoEk0kM3HKhNpInXd946Kd8Od2 EYm0lJTAIBKpwQsRrGcY7LfFniOYddPO5xjOr8bJhxjdbtJdV7rcE2xOwQ8gSg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gjqMz14c9z1Dbx for ; Sun, 21 Jun 2026 11:48:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 252e0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 21 Jun 2026 11:48:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5db31f1b47b5 - main - procfs, linprocfs: ensure target process vmspace stability List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5db31f1b47b586a5091eb41fc957236f28b78dba Auto-Submitted: auto-generated Date: Sun, 21 Jun 2026 11:48:15 +0000 Message-Id: <6a37cf7f.252e0.5c0b3698@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5db31f1b47b586a5091eb41fc957236f28b78dba commit 5db31f1b47b586a5091eb41fc957236f28b78dba Author: Konstantin Belousov AuthorDate: 2026-06-07 18:48:59 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-21 11:46:54 +0000 procfs, linprocfs: ensure target process vmspace stability Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57497 --- sys/compat/linprocfs/linprocfs.c | 16 +++++----------- sys/fs/procfs/procfs_map.c | 17 +++++++---------- sys/fs/procfs/procfs_mem.c | 6 +----- 3 files changed, 13 insertions(+), 26 deletions(-) diff --git a/sys/compat/linprocfs/linprocfs.c b/sys/compat/linprocfs/linprocfs.c index a0deea73d19c..b0e6a3a15bea 100644 --- a/sys/compat/linprocfs/linprocfs.c +++ b/sys/compat/linprocfs/linprocfs.c @@ -1311,19 +1311,13 @@ linprocfs_doprocmaps(PFS_FILL_ARGS) struct vattr vat; bool private; - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error) - return (error); - if (uio->uio_rw != UIO_READ) return (EOPNOTSUPP); - error = 0; - vm = vmspace_acquire_ref(p); - if (vm == NULL) - return (ESRCH); + error = proc_vmspace_ref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, + &vm); + if (error != 0) + return (error); if (SV_CURPROC_FLAG(SV_LP64)) l_map_str = l64_map_str; @@ -1421,7 +1415,7 @@ linprocfs_doprocmaps(PFS_FILL_ARGS) } } vm_map_unlock_read(map); - vmspace_free(vm); + proc_vmspace_unref(td, p, PRVM_CHECK_DEBUG | PRVM_BLOCK_EXEC, vm); return (error); } diff --git a/sys/fs/procfs/procfs_map.c b/sys/fs/procfs/procfs_map.c index d4913a7b0f1d..1ed785f1ad90 100644 --- a/sys/fs/procfs/procfs_map.c +++ b/sys/fs/procfs/procfs_map.c @@ -40,6 +40,7 @@ #include #include #include +#include #include #include #include @@ -93,15 +94,14 @@ procfs_doprocmap(PFS_FILL_ARGS) bool wrap32; #endif - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error) - return (error); - if (uio->uio_rw != UIO_READ) return (EOPNOTSUPP); + error = proc_vmspace_ref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, + &vm); + if (error != 0) + return (error); + #ifdef COMPAT_FREEBSD32 wrap32 = false; if (SV_CURPROC_FLAG(SV_ILP32)) { @@ -111,9 +111,6 @@ procfs_doprocmap(PFS_FILL_ARGS) } #endif - vm = vmspace_acquire_ref(p); - if (vm == NULL) - return (ESRCH); map = &vm->vm_map; vm_map_lock_read(map); VM_MAP_ENTRY_FOREACH(entry, map) { @@ -238,6 +235,6 @@ procfs_doprocmap(PFS_FILL_ARGS) } } vm_map_unlock_read(map); - vmspace_free(vm); + proc_vmspace_unref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, vm); return (error); } diff --git a/sys/fs/procfs/procfs_mem.c b/sys/fs/procfs/procfs_mem.c index 824fcd33b2ef..eb692c32923b 100644 --- a/sys/fs/procfs/procfs_mem.c +++ b/sys/fs/procfs/procfs_mem.c @@ -60,11 +60,7 @@ procfs_doprocmem(PFS_FILL_ARGS) if (uio->uio_resid == 0) return (0); - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error == 0) - error = proc_rwmem(p, uio, 0); + error = proc_rwmem(p, uio, PRVM_CHECK_DEBUG | PRVM_BLOCK_EXEC); return (error); }