From nobody Sun Jun 21 02:22:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjZqF5tVcz6hdjC for ; Sun, 21 Jun 2026 02:22:33 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yx1-xb131.google.com (mail-yx1-xb131.google.com [IPv6:2607:f8b0:4864:20::b131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjZqF3vzQz3YCk for ; Sun, 21 Jun 2026 02:22:33 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-xb131.google.com with SMTP id 956f58d0204a3-6626cd98209so2969740d50.3 for ; Sat, 20 Jun 2026 19:22:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782008548; cv=none; d=google.com; s=arc-20240605; b=F+kX90PfMkoa0ovLvE5tn9tEKiHJXceaBZrKRjTYqTb+BoJ3kYr+TPiTF3z2JeJ2wg R4cTkb/V7aJlqP6YPtZ9oZmYYCJbKtpHcudzplALaA+DM1uiRK1ZaXUquSA/3Rw7dQ22 aukHc78eAaFWo2mbPgVtR3JVvDorudw1ecStMFNKLGgjJHsG4ge13Ev2RZHMJEcIz35A oa4tvo8UeTr+0hiPphovzV0voeY2JaqMWoE2h081V/BJe4+5ZO5nICCv9ccBAkufKNYJ 4oti1uAZw6c8CIbNiAumS/RpU5uvoa215dKfOTA9z2zEZ5d9SWn2zNB9zLL71NTC6cmZ DtZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=uVLdVvhNwr35ePORbyr5OsdKrQBtXnjdBe1Xwo/qIjI=; fh=oO5B72een8BKMavsccdxlmUjv4ms1j9+C++7+U0vWyY=; b=PaQu+3VYejkdhoZ5kpzJ1aZcFEISp6tqvRplNZOihdR4jfhW6Zr8D+cF8LQFNK6O40 KuFPwvVMzxyZCkQZubWcANZwo86JBuihzUKrvrLXao3C0T9gu20+hQGQYgKYLwNT9rXZ YgpBuG0by6hOST2TzDelENCwonny4Ayvxggpb+TJhEzuZezKGpuk5pp8ri7dFv9Pi+oA Qi1t5F7zq+Hg/KCvC7m9qL1cig9IE8SrCGH/i6d9xeZJWNk5N9n0KuDjbqDmcr5Oyg7V GBTdMoqjZAxetAzq0Kfkl91Uml26uoIcCXBXwUXGNPb6v1rp2fAIRXsAQiZngNpynEWY NFyQ==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782008548; x=1782613348; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uVLdVvhNwr35ePORbyr5OsdKrQBtXnjdBe1Xwo/qIjI=; b=CbI0kfHxzWXYo9RikOU6Y2jrnkyzIpbq0e0Cq/GGPcKrBT5t3eGKFTXexiBblVfx9I 6EjwZ4DUagFGjwQ1juwr7ND4CymPuCjmW2DjahDsy+wMWMldPQ1+BqTF99VV9kfnenTj I/EeEvAeIeGloSfBkT97NNs5mwToTW2jEwnz8Dh5NqeJffYBKdE00cqoXzAp70NCieQM WhnAWTrMqQzHEze8EAEZ0luQVWqp6NcVl7XS6qOYDAohzDGc0Foiv3UpGPJg3h7zJydc m+AiWi9B8rCbrKQX9QTIAM8hRGxV/JN246JwVtupwDHYo9my/8misp+3pSxX0j4Cflly pTlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782008548; x=1782613348; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uVLdVvhNwr35ePORbyr5OsdKrQBtXnjdBe1Xwo/qIjI=; b=YQKwpthyhGK8cBqcOV6mOID12v7J2yAHFsb+sErE1E/kqmiZbyHnT0V9dxs4TsWKUl cCqJcszzHo8c+nlbM3fxB/xl/QMKJ9MMh/cjJsvQ28IjVfqjww2EM7ZmV9MbQpzzkhDq XizHs2isybNFwLEC8HGudAVLXv6pm3EVYuY5OyUOXX7Ahw34pU8G3YUrABgo4++dCWMY ydXLCCssP/CQ7NZlfJQVFrBSgxwI6m0FAQULgwentgBEjQ3OPsFbAha05NIOB9u1YmQ7 l9ssRLOM/DYUSPryk/yCIxC1koIASwpzmBnkZxCkNeb0bMKwSHxbgroICdMHDxRHnzKd zVDA== X-Forwarded-Encrypted: i=1; AHgh+RoxT2DUQhl3uVjb10YPyCgYSj1oVwDNWIT9Ao5pS5DQCHBZ/b8AjW/IN7ylXTE0R0TRZvjmnPFNPY5WOkERJLsy7w+S@freebsd.org X-Gm-Message-State: AOJu0YzW7ntMO7DnEuJUVzS+CYXabpXxN/dGHKNBVDiIV/1Dt3bhHiOc 3t28vJbJ4Yeivb/6UfqAtWlhvWJ/TtR6wGWQx/C8o5v7wzn2ACKtBgptt2mAv/XfvPSFzn5WN3T LIlrBse1Elg7bKoLOYSmOHTHYsuV4DvI= X-Gm-Gg: AfdE7clvPE79VJNpyPSxfJzeb5g2gZLH0TFOUjQ0okYeQ8kL8jmuYur6SaK3v71EikF Whg/XjG7Hbd5iP5ieFktNA30n4aCFe8iRmVz5E0EaDfAQjN2TZPWRiOSwnIaG/ikfmoHA9P/v31 dJObC/NtMYRKC7ClI9M6h8fwNTjsrqBFw/SZHwrGwz7mGhoJTuyJIJmarRw5itTdISCkP/cgAii 4b+reGU428eoDpDpKRW8NBkU55S6La7Q+Dpt+Er1li10mM1UehMZeK9SDUYGTgqXlrYPNCDaizn iYL/r6d+qO++ X-Received: by 2002:a05:690e:169b:b0:660:406f:61b6 with SMTP id 956f58d0204a3-662ffdec8efmr7693269d50.42.1782008547716; Sat, 20 Jun 2026 19:22:27 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a36e480.318f5.79b60374@gitrepo.freebsd.org> In-Reply-To: <6a36e480.318f5.79b60374@gitrepo.freebsd.org> From: Oliver Pinter Date: Sun, 21 Jun 2026 04:22:15 +0200 X-Gm-Features: AVVi8CfHtyIuAs6S2vxiSfCfCZoTEgyRdlpAK5ZtN_cSWNrC5D5-Dw1bu1OMa5E Message-ID: Subject: Re: git: 730eaf466493 - main - sound tests: Add PROT_EXEC rejection test To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007932780654ba329d" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4gjZqF3vzQz3YCk X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --0000000000007932780654ba329d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jun 20, 2026 at 9:06=E2=80=AFPM Christos Margiolis wrote: > > The branch main has been updated by christos: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D730eaf466493315c1d1164eb6b59b1476= 6f49322 > > commit 730eaf466493315c1d1164eb6b59b14766f49322 > Author: Christos Margiolis > AuthorDate: 2026-06-12 06:20:26 +0000 > Commit: Christos Margiolis > CommitDate: 2026-06-20 19:04:50 +0000 > > sound tests: Add PROT_EXEC rejection test > > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: markj, kib > Pull-Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/30 > --- > tests/sys/sound/mmap.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c > index b44b16e7f312..e83193db9bc1 100644 > --- a/tests/sys/sound/mmap.c > +++ b/tests/sys/sound/mmap.c > @@ -102,10 +102,38 @@ ATF_TC_BODY(mmap_buffer_lifetime, tc) > ATF_REQUIRE(munmap(buf, len) =3D=3D 0); > } > > +ATF_TC(mmap_reject_prot_exec); > +ATF_TC_HEAD(mmap_reject_prot_exec, tc) > +{ > + atf_tc_set_md_var(tc, "descr", "mmap PROT_EXEC rejection test"); > + atf_tc_set_md_var(tc, "require.kmods", "snd_dummy"); > +} > + > +ATF_TC_BODY(mmap_reject_prot_exec, tc) > +{ > + uint8_t *buf; > + size_t len; > + int fd; > + > + fd =3D open("/dev/dsp.dummy", O_RDWR); > + ATF_REQUIRE_MSG(fd >=3D 0, FMT_ERR("open")); > + > + len =3D 8; > + > + buf =3D mmap(NULL, len, PROT_READ | *PROT_EXEC | PROT_EXEC*, MAP_SHARED, There is PROT_EXEC twice. > + fd, 0); > + ATF_REQUIRE_MSG(buf =3D=3D MAP_FAILED, FMT_ERR("mmap")); > + > + munmap(buf, len); > + > + close(fd); > +} > + > ATF_TP_ADD_TCS(tp) > { > ATF_TP_ADD_TC(tp, mmap_offset_overflow); > ATF_TP_ADD_TC(tp, mmap_buffer_lifetime); > + ATF_TP_ADD_TC(tp, mmap_reject_prot_exec); > > return (atf_no_error()); > } > --0000000000007932780654ba329d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Jun 20, 2026 at 9:06=E2=80=AFPM Christos M= argiolis <christos@freebsd.org> wrote:
>
> The branch main has been updated by christos:=
>
> URL:
https://cgit.FreeBSD.org/src/comm= it/?id=3D730eaf466493315c1d1164eb6b59b14766f49322
>
> commi= t 730eaf466493315c1d1164eb6b59b14766f49322
> Author: =C2=A0 =C2=A0 Ch= ristos Margiolis <christos@FreeBSD.org>
> AuthorDate: 2026-06-1= 2 06:20:26 +0000
> Commit: =C2=A0 =C2=A0 Christos Margiolis <chris= tos@FreeBSD.org>
> CommitDate: 2026-06-20 19:04:50 +0000
>> =C2=A0 =C2=A0 sound tests: Add PROT_EXEC rejection test
>
&= gt; =C2=A0 =C2=A0 Sponsored by: =C2=A0 The FreeBSD Foundation
> =C2= =A0 =C2=A0 MFC after: =C2=A0 =C2=A0 =C2=A01 week
> =C2=A0 =C2=A0 Revi= ewed by: =C2=A0 =C2=A0markj, kib
> =C2=A0 =C2=A0 Pull-Request: =C2=A0= https://ron-d= ev.freebsd.org/FreeBSD/src/pulls/30
> ---
> =C2=A0tests/sys= /sound/mmap.c | 28 ++++++++++++++++++++++++++++
> =C2=A01 file change= d, 28 insertions(+)
>
> diff --git a/tests/sys/sound/mmap.c b/t= ests/sys/sound/mmap.c
> index b44b16e7f312..e83193db9bc1 100644
&g= t; --- a/tests/sys/sound/mmap.c
> +++ b/tests/sys/sound/mmap.c
>= ; @@ -102,10 +102,38 @@ ATF_TC_BODY(mmap_buffer_lifetime, tc)
> =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ATF_REQUIRE(munmap(buf, len) =3D=3D 0);
> = =C2=A0}
>
> +ATF_TC(mmap_reject_prot_exec);
> +ATF_TC_HEA= D(mmap_reject_prot_exec, tc)
> +{
> + =C2=A0 =C2=A0 =C2=A0 atf_= tc_set_md_var(tc, "descr", "mmap PROT_EXEC rejection test&qu= ot;);
> + =C2=A0 =C2=A0 =C2=A0 atf_tc_set_md_var(tc, "require.km= ods", "snd_dummy");
> +}
> +
> +ATF_TC_BOD= Y(mmap_reject_prot_exec, tc)
> +{
> + =C2=A0 =C2=A0 =C2=A0 uint= 8_t *buf;
> + =C2=A0 =C2=A0 =C2=A0 size_t len;
> + =C2=A0 =C2= =A0 =C2=A0 int fd;
> +
> + =C2=A0 =C2=A0 =C2=A0 fd =3D open(&qu= ot;/dev/dsp.dummy", O_RDWR);
> + =C2=A0 =C2=A0 =C2=A0 ATF_REQUIR= E_MSG(fd >=3D 0, FMT_ERR("open"));
> +
> + =C2=A0 = =C2=A0 =C2=A0 len =3D 8;
> +
> + =C2=A0 =C2=A0 =C2=A0 buf =3D m= map(NULL, len, PROT_READ | PROT_EXEC | PROT_EXEC, MAP_SHARED,
There is PROT_EXEC twice.

> + =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 fd, 0);
> + =C2=A0 =C2=A0 =C2=A0 ATF_REQUIRE_MSG= (buf =3D=3D MAP_FAILED, FMT_ERR("mmap"));
> +
> + =C2= =A0 =C2=A0 =C2=A0 munmap(buf, len);
> +
> + =C2=A0 =C2=A0 =C2= =A0 close(fd);
> +}
> +
> =C2=A0ATF_TP_ADD_TCS(tp)
>= ; =C2=A0{
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ATF_TP_ADD_TC(tp, mmap_offset= _overflow);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ATF_TP_ADD_TC(tp, mmap_buff= er_lifetime);
> + =C2=A0 =C2=A0 =C2=A0 ATF_TP_ADD_TC(tp, mmap_reject_= prot_exec);
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 return (atf_no_erro= r());
> =C2=A0}
>
--0000000000007932780654ba329d--