From nobody Thu Jun 18 04:17:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ggnW62ClYz6jNWd for ; Thu, 18 Jun 2026 04:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ggnW61PPWz3kLD for ; Thu, 18 Jun 2026 04:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781756242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XR9AkLgIe3sMjCON4BoorYC6CuxfkGGtSxxGdmkkNl8=; b=LF2iPC1G52abQWkS3d92L61m+2/yPN6B0kWtwntz1qSC4SiKMxxf7mFhydLS1Cys8c/ffx Byr2g6ou77wgDjqgITy5Sa1PwwYz2dHbbkyZBVl/zuLFFNzBsvXgoMMznM5BjVjykqRvjz nFbMEdbsfnZ7fD7GLnHbz70YF4vPKjczOQK2I0/AtV9MUdU+tof9LpUQQORIcYIyf4ah2g 1wO2MdjF8BVB/CJBLqcfhnLR05Eg+a5LbwVhyyfOYMnncTDAS6apdextPBuSb6AQvsblO4 6fvo+Xh4PQQMye7V93cUv/LoQfox9H0JZpakgWcUZccRXSCBMD9igsf0hjdENA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781756242; a=rsa-sha256; cv=none; b=R7xqlhvOWSfDuHClAn7C89/+4LrnN8I/mrzj6zrSUdAUBiXnPMswL1ZxWvAbt27Z/et2ch Le1M2ob4Ju0Qfb8e5iLfH8yUVaqtP3H70/M+E8OFDXCjtIDuf0lEkRM3udUl2hMochhG6d 3Ol3Lzd8GC8m6gHM6WyE+VLQHaKxY8gj9QV+VXMVOZFh4aKn9KOwEsz8RorEyf9OGZepR7 LivjLfF7eHgk3X1mdJfm6/fem1RARORBi+AGMaZ30f0CctxGaLhLMnNb5AfdbqczCSnss1 YTyyCJNKIlAE0NiC4OQyHo1oSnpbnCwznLQbSt0iSZ8tjYP/qiO6h7Xrn7StHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781756242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XR9AkLgIe3sMjCON4BoorYC6CuxfkGGtSxxGdmkkNl8=; b=JSriKscP0BUZgs5IaLpnRR4ihThOP2BKvcmOg0D3jyBzXC1Z7ecF+X/i1W0woZnzUAwY4s qzJ/b5dBm3hFp+foEcVYtOZT4e6hIUxW5NRPkEFtKEauNARbbKP9ojRW0PUKBrp6WOGS+u IzsmnO1/LfR9CF+eCNCypgAfUhC0IY1W/ZPDcpeRp+IRF+87bL49ykfXyrCA4v6EXm+e9l f3ksB3QXsF0AZDYn5lASApdAJm1MVm2ZhTNHozfp8ZtNHVvdNEFpHFYUEoPNfLJTqFXYn4 RakFrOc41FZea39o07GQdBT8G1rruAGv1IPLRB/yJ5BHjdHlby9JguUfH3e8Ng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ggnW56wXZzjTQ for ; Thu, 18 Jun 2026 04:17:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 187fe by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 18 Jun 2026 04:17:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 08180f1b613b - main - witness: actually set read-only tunables in time for witness_startup List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 08180f1b613b6fe000135efa28b7c3293cbf1683 Auto-Submitted: auto-generated Date: Thu, 18 Jun 2026 04:17:16 +0000 Message-Id: <6a33714c.187fe.20ec4acc@gitrepo.freebsd.org> The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=08180f1b613b6fe000135efa28b7c3293cbf1683 commit 08180f1b613b6fe000135efa28b7c3293cbf1683 Author: Ryan Libby AuthorDate: 2026-06-18 03:52:53 +0000 Commit: Ryan Libby CommitDate: 2026-06-18 04:05:43 +0000 witness: actually set read-only tunables in time for witness_startup SYSCTL_XXX with CTLFLAG_RDTUN and without CTLFLAG_NOFETCH should not be used for values that are needed before SI_SUB_KLD. Otherwise they are tuned after they are needed. Set CTLFLAG_RDTUN | CTLFLAG_NOFETCH for the debug.witness.witness_count and debug.witness.skipspin sysctls and add separate tunables for them, which run at SI_SUB_TUNABLES time, i.e., in time for witness_startup. Reviewed by: kib, markj Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D57613 --- sys/kern/subr_witness.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sys/kern/subr_witness.c b/sys/kern/subr_witness.c index 3c192b2b0dce..2bfd8711eed7 100644 --- a/sys/kern/subr_witness.c +++ b/sys/kern/subr_witness.c @@ -404,17 +404,22 @@ SYSCTL_INT(_debug_witness, OID_AUTO, trace, CTLFLAG_RWTUN, &witness_trace, 0, "" #endif /* DDB || KDB */ #ifdef WITNESS_SKIPSPIN -int witness_skipspin = 1; +static bool witness_skipspin = true; #else -int witness_skipspin = 0; +static bool witness_skipspin = false; #endif -SYSCTL_INT(_debug_witness, OID_AUTO, skipspin, CTLFLAG_RDTUN, &witness_skipspin, 0, ""); +SYSCTL_BOOL(_debug_witness, OID_AUTO, skipspin, + CTLFLAG_RDTUN | CTLFLAG_NOFETCH, &witness_skipspin, 0, + "Skip all witness checks on spin locks"); +TUNABLE_BOOL("debug.witness.skipspin", &witness_skipspin); int badstack_sbuf_size; -int witness_count = WITNESS_COUNT; -SYSCTL_INT(_debug_witness, OID_AUTO, witness_count, CTLFLAG_RDTUN, - &witness_count, 0, ""); +static u_long witness_count = WITNESS_COUNT; +SYSCTL_ULONG(_debug_witness, OID_AUTO, witness_count, + CTLFLAG_RDTUN | CTLFLAG_NOFETCH, &witness_count, 0, + "Maximum count of lock type entries"); +TUNABLE_ULONG("debug.witness.witness_count", &witness_count); /* * Output channel for witness messages. By default we print to the console. @@ -790,7 +795,8 @@ witness_startup_count(void) /* * The WITNESS-enabled diagnostic code. Note that the witness code does * assume that the early boot is single-threaded at least until after this - * routine is completed. + * routine is completed. This routine runs during SI_SUB_VM. Any read-only + * tunables need to have been initialized by now. */ void witness_startup(void *mem)