From nobody Mon Jun 15 12:58:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gf9D60K25z6hJq1 for ; Mon, 15 Jun 2026 12:58:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gf9D55Nmtz3WXn for ; Mon, 15 Jun 2026 12:58:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781528325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urawPso8+REUkabxOX1v19S9E6wzRVR5sivaunL8PRI=; b=DjGBUYvYsVoZH4x8Qwhzp9SuzJg3lhNUt1TA23ug8mWf1HQbKQXUZv+lrh7rF9bNhQUFiY xZSIwM2xlIXW3/jjfd14z6bZgbMzg80/UlLLFj4NZcSBkc0tfqwk0qvkaI2GwxoH/7a1wy mR84Qqfk4VDrNUUOXscfnzLH7JJh9xMkRiZhU5vNR2EL1Iifh7DiUf27YRp7+m8RGRucDu v7Slmo2DEKQ9BLOld+0l3WEnRMqMbjnXkA5m7onEpjs3GeOMCBOMFS8/ZvtiF37h1vJjJT CbY2AJcdwXcwiiMEEaqcxud2xFRrDGJQaBQQuFlwB6Is2Zs2uP7fsdz00uUysQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781528325; a=rsa-sha256; cv=none; b=BGLj0uTWUDnmmrebfd4pW1n0/g8vdWqLqwgWQddp9CFLnDJdFn9/ztWPgOH10eyEiPju3C vik4f1/QUW3PmmI4HyCsTkrLz6retTSZzfK0C6H26gTtuf90Wbc1xeMpzPCR3A8RFPuR0R DZ8PW+91G9BR1sbbGvJq72kcyW1JMVWcxMzg7DPr/av5W/ft6dCLCJs7v35XGPkGhK04+n bTJ9Q7j/wir5F8WLOTgvq78Wb8fRL1gjbl/PIwox/qUptK/tldQ/Huj5Wy78m+6kXjDtrb JNOKlp/85+likDC93ouna7H9vSwGDXZK88l57+Fc/+0NktX2NXVl8urls5xU9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781528325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urawPso8+REUkabxOX1v19S9E6wzRVR5sivaunL8PRI=; b=ZmIj/9DXwM4Bf0st+cJjUIolfjhPviy8pUocfdrBmuGzgOGU3XRfjRnh7TWHK23dmI6KAD QYWQPN5YGlR7c+Ne2UEvIvBGQR6tH2kAzMV9pjBcZ9ks+tAsJh7HmFjcIAbOUix2lV/9DZ 0+mRWvwTAr+xMJZIi14UZWTzwkh7Wtfi4heLdve8iokUsK6/tyR4K5Rgfat96JpxVamVzu GfhN6vGP4BA27FiXyiSgOL+MBJP1oFUdKBk4HGlc4CF1rx3eNdB2+W9Pk0ZZVQvr0mIVYn 2IRdk7pJT5tU9CcLQNy/GpHFlT7OJAsewLuwbo2zyexuqv4Scvh8pyugIHDW+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gf9D54x5Tzwkx for ; Mon, 15 Jun 2026 12:58:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24d39 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Jun 2026 12:58:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1491ab351b45 - main - ntsync(9): do not double-free obj when finstall() failed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1491ab351b45b1c727eeed40027f7b5074b19ff5 Auto-Submitted: auto-generated Date: Mon, 15 Jun 2026 12:58:45 +0000 Message-Id: <6a2ff705.24d39.46b7366a@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1491ab351b45b1c727eeed40027f7b5074b19ff5 commit 1491ab351b45b1c727eeed40027f7b5074b19ff5 Author: Konstantin Belousov AuthorDate: 2026-06-15 04:41:53 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-15 12:57:41 +0000 ntsync(9): do not double-free obj when finstall() failed Reported by: Alex S Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/dev/ntsync/ntsync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/ntsync/ntsync.c b/sys/dev/ntsync/ntsync.c index 5fba9775be0e..2dec2f68aa80 100644 --- a/sys/dev/ntsync/ntsync.c +++ b/sys/dev/ntsync/ntsync.c @@ -297,6 +297,7 @@ ntsync_create_obj(struct ntsync_obj *obj, struct fileops *fops, finit(fp, FREAD | FWRITE, DTYPE_NTSYNC, obj, fops); error = finstall(td, fp, &fd, 0, NULL); if (error != 0) { + finit(fp, FREAD | FWRITE, DTYPE_NONE, NULL, &badfileops); NTSYNC_PRIV_LOCK(priv); MPASS(priv->objs_cnt > 0); priv->objs_cnt--;