Re: git: 439710cf003b - main - assert.h: Revert "Remove leading tabs for whitespace consistency"

In reply to: Robert Clausecker : "git: 439710cf003b - main - assert.h: Revert "Remove leading tabs for whitespace consistency""
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Olivier Certner <olce_at_freebsd.org>
Date: Mon, 01 Jun 2026 07:38:04 UTC

Hi Robert,
     
>     As per style(9), a tab goes after #define.  This should not have been
>     removed.

A TAB or space indifferently can go after a '#define', the important thing is whitespace consistency.  To quote style(9): "Put a single space or tab character between the #define and the macro name, but be consistent within a file.".

Here, although not covered explicitly by style(9), there's still a series of '#undef' that does not have a TAB after it but a space.

Additionally, from style(9): "The comment should be separated from the #endif or #else by a single space." speaking about comments matching (the invert of) '#if" conditions, so ruling out TABs there.

All-in-all, the original commit was fine and IMO should not have been reverted.

Thanks and regards.

-- 
Olivier Certner