From nobody Wed Jan 28 11:31:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f1Kq929kJz6Pmt4 for ; Wed, 28 Jan 2026 11:31:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f1Kq86XPtz3mv0 for ; Wed, 28 Jan 2026 11:31:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769599892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+YC9UkUNOjgi4sytePhjzyyEbvIwGTxjghn1Tukvmo=; b=tzJO4GpQhV1cxq3ZwnGrgKDYEF6lQYLl2sK6+nw4JfIvkajWlrDRtiX7x/4hXufQ/4KsX7 u5eTqBKStS5aorFuUocK2BTgOj9GW055fU2mOhnBmPhXpPzr/AMXzIsVRPrQOeoElNaeyx uLFEgRkcBeCObSGq34XY5aNRIs6kqVUkdRkvSAKV4BrDeMWuvaQM4R2+inTbN9ZnA8MACg 91k8cKFkMFNypkA+2D3TsSQx5IXnSYyAqvnmctCJYTOcw4rgtOsmQ8Fke2/oLWot/WxF67 0WwMvLVOoXCY1llIEqu08zHlWj7qEe8DX/E+yNDNCZYW9cVaRom6Cyw9pGsKQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769599892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+YC9UkUNOjgi4sytePhjzyyEbvIwGTxjghn1Tukvmo=; b=rk69UyZPgaRhcjvX9xYR0AkzJywUi/IfEo95G5yD3Fp0yZ+iMqhXbvMas0MBjyoq2KzntK Q5PTsw8sCBB6NA0bCv7yttmigSOKDI+Ik3Ov0DcsP0YyO6uGeNM9tkYnXIf3zni+cenVe7 /FghdVytPfJC20XByItTf53ux/Ef5r5BdKPmHcOH9XwFiAQBf40rL1OktbZTGJcc7Ag+Zc YKKGDcUiT/Wwl5EuF6A2uuuHjU/rtWzAmM0yAw10xOcIei6Y9la+BQbMvhJu4/s6hk/55t DT1G1/xy3xgyDTxTWqjNUeyyNLIe+nPKTrwrgT0y82pE5r7MLzu31DzBuxbHlw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769599892; a=rsa-sha256; cv=none; b=Lj5/UBy+XQMCPAt0aAda7rJnKitCfnhMSw7D4S/mEJvwWsMt9K/JIYnTIuHvCA0k5/nlPy KSlLgX/m+Zm4pFHoX9uNPKgyqC5E8m6Gzl+QXweI1PMLI1zt/Q205iHCKntwl0AN3r0W49 wJPaoAANWoYoVx29xri64XcHHz0rLN5q4On5UYflzt10n+vfNVTcDjmvrCuDNIH5LtKAJ5 Hr8xIusbuGKGkwqnCbq3lyql5+SNbEgcj+n067KcoIXiXjYmsdN9Om2d5Cj5jGljV4OQXT sttCq8TdR7jHOmj5Qq+C33k75hYjTSku7X92YmO43vv9gZiuU6uBHjyxWIFigA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f1Kq8634xzrL9 for ; Wed, 28 Jan 2026 11:31:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43a9f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 28 Jan 2026 11:31:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 526c09a48929 - main - acpi: Use only AcpiGetSleepTypeData() to determine Sx support List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 526c09a489295c96662d6c3d428f69672968ab80 Auto-Submitted: auto-generated Date: Wed, 28 Jan 2026 11:31:32 +0000 Message-Id: <6979f394.43a9f.36a680b6@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=526c09a489295c96662d6c3d428f69672968ab80 commit 526c09a489295c96662d6c3d428f69672968ab80 Author: Olivier Certner AuthorDate: 2026-01-07 13:34:44 +0000 Commit: Olivier Certner CommitDate: 2026-01-28 11:26:37 +0000 acpi: Use only AcpiGetSleepTypeData() to determine Sx support Previously, we would first call AcpiEvaluateObject() to execute \_Sx before calling AcpiGetSleepTypeData(). This was unnecessary, as AcpiGetSleepTypeData() performs the same call itself. While doing so, the latter function logs any other error than AE_NOT_FOUND (which indicates that a particular sleep state is not supported), which most probably is an added benefit of this change. Reviewed by: obiwac MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D54624 --- sys/dev/acpica/acpi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c index e43ef72ca9d2..6da406377d4b 100644 --- a/sys/dev/acpica/acpi.c +++ b/sys/dev/acpica/acpi.c @@ -490,7 +490,6 @@ acpi_attach(device_t dev) ACPI_STATUS status; int error, state; UINT32 flags; - UINT8 TypeA, TypeB; char *env; enum power_stype stype; @@ -688,13 +687,14 @@ acpi_attach(device_t dev) #if defined(__i386__) || defined(__amd64__) acpi_supported_stypes[POWER_STYPE_SUSPEND_TO_IDLE] = true; #endif - for (state = ACPI_STATE_S1; state <= ACPI_STATE_S5; state++) - if (ACPI_SUCCESS(AcpiEvaluateObject(ACPI_ROOT_OBJECT, - __DECONST(char *, AcpiGbl_SleepStateNames[state]), NULL, NULL)) && - ACPI_SUCCESS(AcpiGetSleepTypeData(state, &TypeA, &TypeB))) { + for (state = ACPI_STATE_S1; state <= ACPI_STATE_S5; state++) { + UINT8 TypeA, TypeB; + + if (ACPI_SUCCESS(AcpiGetSleepTypeData(state, &TypeA, &TypeB))) { acpi_supported_sstates[state] = true; acpi_supported_stypes[acpi_sstate_to_stype(state)] = true; } + } /* * Dispatch the default sleep type to devices. The lid switch is set