From nobody Tue Jan 27 18:44:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0vTF2Wk7z6QG97 for ; Tue, 27 Jan 2026 18:44:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0vTD6mDlz3rfD for ; Tue, 27 Jan 2026 18:44:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Zr4D7JBH8W90+AVriCEuNBZo97cxWkZL2ykg2D2J8s=; b=BQZsPgIloxnRBum2hH03Bg4g1kvcJBOipRMm6N44kfWYk+pcO3ZIlpfPUT6Dr2d8grltHu nOMb7TRdRS2/2SJybLCK1H/4Q8CVWyQiAOR41MMzK22EYeoKECLSm4GMJcZLexusWVKa4z rZtOD874a6tcC4c+BLVczZf94i46MyjLAJrJirr6pt27v7xmcvFBYBeyqZpX83z+/IHjGG uZavL3iGqF5P+Hg4bx2TWAqvcGGrh9xIN57f3UO622QleyRYfDLlqMJd4o0okx4E1dznjV g/g6aq6SmkO9Fa7NerayJoABsJ/UlwshmtuBN2IbZaXfuGrMPQk8JPGqAoCokw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769539473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Zr4D7JBH8W90+AVriCEuNBZo97cxWkZL2ykg2D2J8s=; b=RKhyqfROj4BT62YUvqxY7MaRBMxjoKX/DIUzo2uDBYi1lxx2Ys82qFIJU6Liunr38UPiyK dbZksXDLh8xCJ8pNs4zAXGLSxssUkV6dOC/gkFmaRjHRz997wVXGhYNM5bvNOO7sZTbQDT 0ifWhUtLQJXEInZ3ABMx3vc/DHOwFI4VSByub2ah6jxJ2fcpT8Y7ZKlHp23rLRMUkbk+ej DD4AEewYNFN0p5Y+AZ4oSAsW6aepd2fDVU1jKee3GCaT+CB2iAV7+yxZPNMP4ySa5mOxDw EebeRfc85el6ht5GdcDXGv8cTuxpcSZ7WRAAAS2t7qNoYqOqZGKx8M+/kyfr1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769539473; a=rsa-sha256; cv=none; b=ct7mjtynX79cGe/vvNRE1htjypiTL8Fs8HTXoDmBBNeNvjRUW0aAY8l3CWiJjPQhRpsDHY R/6wuIGFZSqKFTnPh2p/Mudk+HPxfBL1tsGi/uAdi3ERE9exEaNUb16BdjfawjakKrMbPj cZv37039wCo8YKzfmQsI/dzkArwz7mOXX6g7NnnVbbNW/ARpnBpTO5eqGg6vTxTA7k/4vf gfoX+E7lZoozDxun4UnUHWK9wgCk4xpKS2bijDj6k8uMIfVhVVwkjVPNPdtiMStyz51VZb zB6l1jZYfCkZuzwIR7/T66JxfWolIvorhLBXOOnPSDo3Vt1gybuNy7jO3Bh8yw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f0vTD6HFfz3tf for ; Tue, 27 Jan 2026 18:44:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20255 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Jan 2026 18:44:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 8c211a00d3b4 - stable/14 - ctld: Require a mask if / is specified in an initiator portal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8c211a00d3b45b46b00e3fb99d803b65e7aadeee Auto-Submitted: auto-generated Date: Tue, 27 Jan 2026 18:44:32 +0000 Message-Id: <69790790.20255.337ca042@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=8c211a00d3b45b46b00e3fb99d803b65e7aadeee commit 8c211a00d3b45b46b00e3fb99d803b65e7aadeee Author: John Baldwin AuthorDate: 2025-04-11 14:02:09 +0000 Commit: John Baldwin CommitDate: 2026-01-27 18:15:58 +0000 ctld: Require a mask if / is specified in an initiator portal If the / separator in a portal string is the last character in the string, treat the portal as invalid. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D49648 (cherry picked from commit 4449cf28a3152cf6e87a45176ae15ae250e543de) --- usr.sbin/ctld/ctld.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/usr.sbin/ctld/ctld.cc b/usr.sbin/ctld/ctld.cc index 51983a42a8bf..bcde2f1ae433 100644 --- a/usr.sbin/ctld/ctld.cc +++ b/usr.sbin/ctld/ctld.cc @@ -350,6 +350,8 @@ auth_portal_new(struct auth_group *ag, const char *portal) dm = 32; } if (mask != NULL) { + if (mask[0] == '\0') + goto error; m = strtol(mask, &tmp, 0); if (m < 0 || m > dm || tmp[0] != 0) goto error;