From nobody Sat Jan 24 20:19:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dz5js2J76z6PbJY for ; Sat, 24 Jan 2026 20:19:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dz5js1Zwkz3Db5 for ; Sat, 24 Jan 2026 20:19:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769285953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sht+cWMGa9oD8ddrAxzy45bWVDore+LAI8SEgz00eCo=; b=rQMNXmUSrY6yepAMdB5abanWgDQ4Q9q9AE8535mTehSSrJdoaZrNcPCGBdhVPSjus14ZMg pggGMfOE1hrRgpyq+6IoW5+1iYPIHxfa45SfSwSxmz7OIasHUmvRS6zYdsYZ+piG7iLe3h UHRh5PfXdBoC5VUziYKEn+bi5meJ56OsJoyycEJO7dJVNaMW1ghHG1KoNFhM62mbDqlBur j7hS5PXhIVf1L33cGL7az/2VmUwoIsSc8q57GoCTUNDjJ2YJz+p6qGBmyAiitFef2I9e4u KJ50SO7Zj6zCdvjHzrtrYtk//TNfgXpgTWzwmKf7e1Bn218PZAkFGOqp1xJW3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769285953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sht+cWMGa9oD8ddrAxzy45bWVDore+LAI8SEgz00eCo=; b=lo1+uejR9COyhUkKDDiowNxQTa2p77mK2XzvhBlstkfgmahcPu/hOxOaL55ckUPJHiiuRb W1jdyvGi2pizC1RhjhkrucStJZntVvk75TB2IRYNTwU31WmdrlIQnzsyn0W1BXrRu/vS7/ GtNgMtVk3tJRN3FlTx52A5OmTIzxcQ4OEpk+mIk9l1Kw70E91L/v86z2WVw9iGrahdPswU LlHxuc2vAdL4ty+9PYCwvuKVboDvuQrXP7NQ0i+VnJZG2K12ylxTJpFwFrAb5a8XOx36qG gLtVlFQz3drLLz7NJzxGdzDo7K4tDQgnC/5NpZMpIKLjl+Uu6KIvnelzmphZmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769285953; a=rsa-sha256; cv=none; b=X3wnLgdClBt7U7UuBk8u/Vw4d7YUM+1ewcjvai//85lSDGCuL45J5OqYOX+1eFEV1/h6Ow IkfDu8iDOwNqUtFKSk0zCB2FiOB/uq23JxK/6AQSmf68IkS7nlGSaeo2bJyE3DYpdOF69K HkALy3JotSYFf2p9CZ7/9afFxK91vExpN4+3JA1zrfKEIOkGqT4QeYv9aq1JmcVdxHS8QT AFN/fMcKH/IGiKK9Th9nJoh7bjpuOmV+YWwYQPyNxFYTHM+Y4RyunyG0yDIQ+W3cRzIi8f OsJC7WmGmzL5+WMrjqVfl9WWQGa8AvJpXt+QjAqUQ3LUGGD6VN2+QPCHx+lnrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dz5js0gpNz1JSL for ; Sat, 24 Jan 2026 20:19:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id ff0f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 24 Jan 2026 20:19:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: ec2b3d786b23 - main - loader: Only warn for !FDT && !ACPI take two List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ec2b3d786b236ac64ff5d3e28e8d05e2293896d5 Auto-Submitted: auto-generated Date: Sat, 24 Jan 2026 20:19:13 +0000 Message-Id: <69752941.ff0f.228fc8f4@gitrepo.freebsd.org> The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=ec2b3d786b236ac64ff5d3e28e8d05e2293896d5 commit ec2b3d786b236ac64ff5d3e28e8d05e2293896d5 Author: Colin Percival AuthorDate: 2026-01-19 01:19:03 +0000 Commit: Colin Percival CommitDate: 2026-01-24 20:18:35 +0000 loader: Only warn for !FDT && !ACPI take two For unclear reasons, we used to print two warnings about not having a DTB: First, printf("No valid device tree blob found!\n"); and immediately later a second, printf("WARNING! Trying to fire up the kernel, but no " "device tree blob found!\n"); A previous commit silenced the second warning in the event that the acpi.revision environment variable was set, on the theory that systems which have ACPI might not need a DTB; this commit silences the first of the two warnings under the same condition. Reviewed by: andrew Fixes: 3989a3d81701 ("loader: Only warn when we have neither FDT nor ACPI") Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D54772 --- stand/fdt/fdt_loader_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/fdt/fdt_loader_cmd.c b/stand/fdt/fdt_loader_cmd.c index 161c2435c410..a53bb2e651f2 100644 --- a/stand/fdt/fdt_loader_cmd.c +++ b/stand/fdt/fdt_loader_cmd.c @@ -993,7 +993,7 @@ fdt_copy(vm_offset_t va) debugf("fdt_copy va 0x%08jx\n", (uintmax_t)va); if (fdtp == NULL) { err = fdt_setup_fdtp(); - if (err) { + if (err && (getenv("acpi.revision") == NULL)) { printf("No valid device tree blob found!\n"); return (0); }