From nobody Wed Jan 21 16:07:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dx8GX1xx5z6PNqL for ; Wed, 21 Jan 2026 16:07:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dx8GX16qZz3jpb for ; Wed, 21 Jan 2026 16:07:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769011636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4NMpCilAPqTym2SXF9SB8vosC96ELVBusXAY6AOnFRQ=; b=ySo1rsGdH9VJsulb5cZrSG4Q6GcQ/Bzc0ZEASLxHdqPRSz53KBlmN61EFAsbSqu+ScGnU6 kXRUOFKyfTQUYpV14/31BPTgHm6MfG6e74cH8v/lzcw99+Qx/p0IRwJB8M2lelW4a2IdMg OWc/xxdLP34h08rQfu8OS6/xwKDAX2T3/S0GnMUfgKB/+GTTkMUq0U/Tr6QamlbueBdfqi 0bBxELTUpvlGNOvPrcktewFrZMr/VTNr+uJ/lJ89u6QhxbZjlx363mEY50R0qxjKNTsp4/ 3DtSQ+E1o5RSHKIcXKu7JHgxwIoU3xnS8aIoMDg+nsJG5i8hpzIuUAdzGC1caQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769011636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4NMpCilAPqTym2SXF9SB8vosC96ELVBusXAY6AOnFRQ=; b=obT4QiAn0OQdV2j7HGdz5g3LEQmO6QeSnlDJEd9DNZcq0ds3e79JKKfdgmbUuinOPPNRZ9 5dMx9GUGoliWvTLa14fP4Tlj4iIEnuueb8c8REx2nn4WTbxnt7KXr29dRW6aWLjOBBZWpg GFGWmRgPQnjtdnmegdAbKcZ3tKem6Jts7FRut0sIPPTx/QEovP/iUafpsAB0AcxOXGdQlp Ks/ej/6zM3XyD0Wm20uIsqqtzjBg23rdlQMGj5e4QTIni7uk1rRpNrKU7FSl2qBSEeOOKT XhQf771R7Xgwva+lsmuqteb4sjp2Jtqd7pJ3SyNbAXHS92tWXtQmthGNyD/+nQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769011636; a=rsa-sha256; cv=none; b=OD9qvKYheoBZyrOoCMfRSt01qdouZSpvfN67ECb6OpBKmqgbFxJmIMuP4LQUbLDgkLczRU j46lZmdF0Rf00YlZ5IMZponiG1IS78Jtg4OTJuMnVntT3TdmxKlyQ7yUiPYYCBFYTgL+WF PW0FDbVTbuGcG+xcmkyyF7bz7u8R9L6nZrjor8+OesxgWqUsjfGVM3C56xqR0lIwb0ilSn GoaWqRvR4gVAamIMop6RhP/F0/Jz3IFD4hqbxZBmrxcdVgSu6/dFnz+x3zGDTE5EGioKEZ b2rm1zMWyxWKEJgHi3LWWhgBcFCfhLs7KLJbJ/gPL2fBuHUmWpNKTXfjtURr2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dx8GX0bS7zv1W for ; Wed, 21 Jan 2026 16:07:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 347b2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 21 Jan 2026 16:07:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 0d33cdd04da7 - stable/15 - sound: Unlock around uiomove() in midi_{read,write}() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0d33cdd04da7498a2070fe3f1557b2d519cc66fb Auto-Submitted: auto-generated Date: Wed, 21 Jan 2026 16:07:16 +0000 Message-Id: <6970f9b4.347b2.f896c80@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=0d33cdd04da7498a2070fe3f1557b2d519cc66fb commit 0d33cdd04da7498a2070fe3f1557b2d519cc66fb Author: Christos Margiolis AuthorDate: 2026-01-12 11:27:15 +0000 Commit: Christos Margiolis CommitDate: 2026-01-21 16:05:31 +0000 sound: Unlock around uiomove() in midi_{read,write}() Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D54130 (cherry picked from commit 6b69d6726a7d3455fb295abfcf9aedd48c580d4a) --- sys/dev/sound/midi/midi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index c86f5fb41b14..8c38b00f15ad 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -391,9 +391,11 @@ midi_read(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(used, MIDI_RSIZE); MIDIQ_DEQ(m->inq, buf, used); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); } /* @@ -457,9 +459,11 @@ midi_write(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(MIDIQ_AVAIL(m->outq), uio->uio_resid); used = MIN(used, MIDI_WSIZE); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); MIDIQ_ENQ(m->outq, buf, used); /* * Inform the bottom half that data can be written