From nobody Wed Jan 21 12:44:03 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dx3m368TKz6P8X3 for ; Wed, 21 Jan 2026 12:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dx3m350fdz3H6Y for ; Wed, 21 Jan 2026 12:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768999443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/5va34ZnZS5Red8SYq12V4gZJgyFq/lcPqN/G5eIe5A=; b=wzgi4VZjYjJdLvy8sWRt2GLjaklj+LNoM/9EQJybXtF8rB2Upa2xSdibOdL9/l+AdnX1+n x35W2iuGhSxnktfWe6ZgAik1wVHWoyMvEd92jeXk0G84C64kZun7h0KT0Cm6kRldu4VIEb SCxcFtjmRrtPRSmE5NYjr/wCt3L1kIi5+G7HjdJYajw0yKdiZlXoy38C4tPkOdEiq1GPfS dJ8lQ4yjrglA4O9ZRU/SeoaIkFBHR3bLk0DfrY/iPwsmOC34kL0ZH/7aVl07tb2dXdtNkZ yrvpc5cN7P6QiWzkJ2I+2RyYdcMKrsHL4jhu6NoGnKlnWEhGCL2vKaVXP12wKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768999443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/5va34ZnZS5Red8SYq12V4gZJgyFq/lcPqN/G5eIe5A=; b=l8tFMDVatlnC62W5L5Od35158/v9XOfHzUPavbXdseoBKeOstkhJOLRcfVvD06kWZB6unI v38Dr7kFBSJS/ZGODUlRa/bATYAGtrK54vf+2Lsi0pKplWwE+Ul1hHjX+u2zgZxBGRzrlk MQLZxW0heZ8paG1tXmX6C3fqP/L3M1r2mVtLSbInda3qhBoG9guoBUzoxYDkVJrwucg/ue /sqDrUWruOak4VJs0AAjNaSbfnQX+M/Vn+STPfMDnyb8id5UnZ8x9bmR+PzAldJXHRnrhm bdHH2LjaUb1yB3HQfuPR2k/ZKgdkTB0z3pK0HB6txmOD0D6zsGRDddRUEsozQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768999443; a=rsa-sha256; cv=none; b=qgXERGREFReaHi9vlih7/Gm+to3darWd497droEmJMJR5BUHrE86MuTxLd/7CaN3rosuw0 T/qGjzENiCj8DphHY0rQm1Sgla8i5TiT7zjPKJGLLbzcSC0+nDiDVWSm8ROTSjhSpy7ztI 4H6TgPzAz2wXOD4l1HJF+jgcxyIIAiy6Qc+KIy5ZJgYdPrSQe6M7vM7AWm+7+fBDSJJave pZrf3FiFHQ4ygMs2AEo7mdRsSUGQ5MbSaudf3p8VzWs/1UPnI5XhtEv0L9SN0cMisDrZvm EKtiSEbI/5caqBPhaM7400BdtId3qatom60abGAQGUSS32MTG+igcnBdDPDuYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dx3m34V5szpDN for ; Wed, 21 Jan 2026 12:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9902 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 21 Jan 2026 12:44:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 9d246c6be2b2 - stable/14 - vtnet: expose features via sysctl tree List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9d246c6be2b2c4d8845961c3170d6d65b4a92e3c Auto-Submitted: auto-generated Date: Wed, 21 Jan 2026 12:44:03 +0000 Message-Id: <6970ca13.9902.2b9d87c2@gitrepo.freebsd.org> The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=9d246c6be2b2c4d8845961c3170d6d65b4a92e3c commit 9d246c6be2b2c4d8845961c3170d6d65b4a92e3c Author: Michael Tuexen AuthorDate: 2025-12-19 16:38:35 +0000 Commit: Michael Tuexen CommitDate: 2026-01-21 12:42:09 +0000 vtnet: expose features via sysctl tree Right now the 64-bit flags field needs to be casted to a 32-bit field, because clang warns if more than 32-bits are used. Once clang is fixed, this restriction will be removed and more bits will be added. Reviewed by: markj, Timo Völker Differential Revision: https://reviews.freebsd.org/D54288 (cherry picked from commit 634d9c0d111b630c3d63a1cf25d15c32a37afab8) --- share/man/man4/vtnet.4 | 4 +++- sys/dev/virtio/network/if_vtnet.c | 18 ++++++++++++++++++ sys/dev/virtio/network/virtio_net.h | 8 ++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/share/man/man4/vtnet.4 b/share/man/man4/vtnet.4 index 9836f38cb274..7a4c64a8e5d5 100644 --- a/share/man/man4/vtnet.4 +++ b/share/man/man4/vtnet.4 @@ -22,7 +22,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd December 18, 2025 +.Dd December 19, 2025 .Dt VTNET 4 .Os .Sh NAME @@ -270,6 +270,8 @@ The maximum number of supported virtqueue pairs. .It Va dev.vtnet. Ns Ar X Ns Va .flags The flags of the interface. Mostly for debugging purposes. +.It Va dev.vtnet. Ns Ar X Ns Va .features +The features of the interface as defined by the virtio specification. .El .Sh SEE ALSO .Xr arp 4 , diff --git a/sys/dev/virtio/network/if_vtnet.c b/sys/dev/virtio/network/if_vtnet.c index f95f99f9dd28..5688b21e92a3 100644 --- a/sys/dev/virtio/network/if_vtnet.c +++ b/sys/dev/virtio/network/if_vtnet.c @@ -4402,6 +4402,21 @@ vtnet_setup_stat_sysctl(struct sysctl_ctx_list *ctx, "Times the transmit interrupt task rescheduled itself"); } +static int +vtnet_sysctl_features(SYSCTL_HANDLER_ARGS) +{ + struct sbuf sb; + struct vtnet_softc *sc = (struct vtnet_softc *)arg1; + int error; + + sbuf_new_for_sysctl(&sb, NULL, 0, req); + sbuf_printf(&sb, "%b", (uint32_t)sc->vtnet_features, + VIRTIO_NET_FEATURE_BITS); + error = sbuf_finish(&sb); + sbuf_delete(&sb); + return (error); +} + static int vtnet_sysctl_flags(SYSCTL_HANDLER_ARGS) { @@ -4440,6 +4455,9 @@ vtnet_setup_sysctl(struct vtnet_softc *sc) SYSCTL_ADD_INT(ctx, child, OID_AUTO, "act_vq_pairs", CTLFLAG_RD, &sc->vtnet_act_vq_pairs, 0, "Number of active virtqueue pairs"); + SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "features", + CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, 0, + vtnet_sysctl_features, "A", "Features"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "flags", CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, 0, vtnet_sysctl_flags, "A", "Flags"); diff --git a/sys/dev/virtio/network/virtio_net.h b/sys/dev/virtio/network/virtio_net.h index e0ca40a7acbb..961d330ced8a 100644 --- a/sys/dev/virtio/network/virtio_net.h +++ b/sys/dev/virtio/network/virtio_net.h @@ -57,6 +57,14 @@ #define VIRTIO_NET_F_CTRL_MAC_ADDR (1ULL << 23) /* Set MAC address */ #define VIRTIO_NET_F_SPEED_DUPLEX (1ULL << 63) /* Device set linkspeed and duplex */ +/* virtio net feature flag descriptions for use with printf(9) %b identifier. */ +#define VIRTIO_NET_FEATURE_BITS \ + "\20\200CSUM\201GUEST_CSUM\202CTRL_GUEST_OFFLOADS\203MTU\205MAC\206GSO" \ + "\207GUEST_TSO4\210GUEST_TSO6\211GUEST_ECN\212GUEST_UFO\213HOST_TSO4" \ + "\214HOST_TSO6\215HOST_ECN\216HOST_UFO\217MRG_RXBUF\220STATUS\221CTRL_VQ" \ + "\222CTRL_RX\223CTRL_VLAN\224CTRL_RX_EXTRA\225GUEST_ANNOUNCE\226MQ" \ + "\227CTRL_MAC_ADDR\277SPEED_DUPLEX" + #define VIRTIO_NET_S_LINK_UP 1 /* Link is up */ #define VIRTIO_NET_S_ANNOUNCE 2 /* Announcement is needed */