From nobody Wed Jan 14 18:57:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drwN94GvYz6Nmqx for ; Wed, 14 Jan 2026 18:57:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drwN834YMz3lC8 for ; Wed, 14 Jan 2026 18:57:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2a0d5c365ceso1201435ad.3 for ; Wed, 14 Jan 2026 10:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1768417042; x=1769021842; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kRKShWhmcvpHniF1+htToVc17kb0poVpwpbgOLp3AhM=; b=HqUb2WqhCyhKU6ZmUSNLWSzgHZx7dT+/QWuMbgzMEhTksfe73EaffSvzBImWoYCab5 GpVukS5FCHevWQrA5J6oSYtfM6Eqx1YK4gKr8wGnuJLbZ6KfLQe7+TKBZVD+MOnxeYgG ovOPf+EMv2AmInQg1BXUAeKvHf2m2tL5xI0a5BpDp5Oquzci1ca8mmT7rGwY5iSo1TOV 6gY/zcSJPiZDGsWFhxX+d5KQWI6mhbXCvmTOB+3Eq6g5pppYeX0Cc7rbgF3KE83XUfTg ewKY1W4prjLUVPkUahlysfwtfEIXmzZTbmWPxDTUv+/NCTtS7bz+wtQc3+t4ChdNbitR cGFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768417042; x=1769021842; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kRKShWhmcvpHniF1+htToVc17kb0poVpwpbgOLp3AhM=; b=psivQNrBuUmrGqTQEuazATtHxaVDw8CZZnHcs+Ysjef8GEKY70UHsLmTJvVoFBz2/L jpt5kXWMd308B3TvI3ImL9fPG3yB8Y/ENBxg4AX+sL2mqxYBc2UDOrO+mGrIF4FQFiOT mFg5EO+Mx01DCgMA6j6zD++kkqi+eoiHaRFn1uuDcaZVpKTOifZmXFqSQze7sbzF0q6Z 1n2Vuv2MRwnPf0Pt00X8Qj1R0YLlm2jAVQrzDPaXLTG3SuCpM9DIWybo3pXNo11PSctq hEC1d5Qpe+9QxHquUSE8X6yNaqYe9Lkkx6+jIeRWC3jLSkBCfdcrJv/XUNG+dbLrZW2h 1NLw== X-Forwarded-Encrypted: i=1; AJvYcCULcm/8+KLUhMgkyk0rbI961+UYSVIig3pTiE/ckxzsKWF4OfxvC0h084Y9Blpr6I9M5d1lDQ6wUzKXVeUxYddM7eJZ@freebsd.org X-Gm-Message-State: AOJu0YxZgmlrlvN4AZ8ATP7Fv1rq5C9UMdeT1H+fr5CoXDcu/ZbXsaxm qCIrKSvIIezogRbwr9dcvjsWzLfLAJRUDzVKxkX4I3XEahQZB+UarMGqaVntPh/TKEzgf/BVQHz 9/otgW6RSRmDnBpvhwM/VPlHf/gOQoCHkEY7uwOv2mQ== X-Gm-Gg: AY/fxX6W9yNDS4ojJagt3fGsa/tT9UA92p/n+vwQ1aC5ozkAs+B2A71nDzF5TA9tVLb ZgtkJ2qJFh6lA/Dso4SMzIClhQaGFLenPR4QtEwNk9veTqC7IwIztGoJ+bQQsuXRub4ZhiXWzyv bjq6vBJp25ynuTeRriJJm9396le7ZGXIXOKDiVvrKXBgMjebpED1zH/b/Js6OI67N399LxlDcpW GUOVQWgKG1jgpyHwJDz4+BhtVVLTfPWgEqvEjcvLWn6044rYHTeZvjOhUPF091IEKd4dyg7LZKQ FbWe7g== X-Received: by 2002:a17:902:cec7:b0:2a0:c1e4:e25 with SMTP id d9443c01a7336-2a599e55f40mr39540945ad.54.1768417042234; Wed, 14 Jan 2026 10:57:22 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 14 Jan 2026 11:57:10 -0700 X-Gm-Features: AZwV_Qj_S51Nj3-urxisfPhgmuURaQMZkuEq7008GLgRqnLzCA78N_tgeLzBGAg Message-ID: Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests To: Jessica Clarke Cc: Ed Maste , Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000009e0e2906485dada9" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4drwN834YMz3lC8 --0000000000009e0e2906485dada9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 14, 2026 at 11:22=E2=80=AFAM Jessica Clarke wrote: > On 14 Jan 2026, at 18:16, Warner Losh wrote: > > On Wed, Jan 14, 2026 at 11:12=E2=80=AFAM Ed Maste = wrote: > >> On Mon, 12 Jan 2026 at 02:37, Warner Losh wrote: > >> > > >> > The branch main has been updated by imp: > >> > > >> > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001d94974a081e5fd58c4f= 3994429cb > >> > > >> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb > >> > Author: Warner Losh > >> > AuthorDate: 2026-01-10 16:20:20 +0000 > >> > Commit: Warner Losh > >> > CommitDate: 2026-01-12 07:18:11 +0000 > >> > > >> > github: Add more context to pull requests > >> > > >> > Add code to fetch and decode CODEOWNERS and automatically @ > people in > >> > the review. > >> > >> Does this not just duplicate existing GitHub functionality; it should > >> be automatically assigning reviewers to a pull request based on > >> CODEOWNERS AFAICT. > > > > No. It's not doing that right now at all. That's why I added it. Maybe > there's a simpler way, but it wasn't tagging people automatically. > > Only users with write permission for the GitHub repo work. > What I've done? Or CODEOWNERS? It works for me, but I'm extra special in github land. Warner --0000000000009e0e2906485dada9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 14,= 2026 at 11:22=E2=80=AFAM Jessica Clarke <jrtc27@freebsd.org> wrote:
On 14 Jan 2026, at 18:16, Warner Losh <imp@bsdimp.com> wrote:<= br> > On Wed, Jan 14, 2026 at 11:12=E2=80=AFAM Ed Maste <emaste@freebsd.org> wrote: >> On Mon, 12 Jan 2026 at 02:37, Warner Losh <imp@freebsd.org> wrote:
>> >
>> > The branch main has been updated by imp:
>> >
>> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001d94974a081e5fd58c4f3= 994429cb
>> >
>> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb
>> > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>= ;
>> > AuthorDate: 2026-01-10 16:20:20 +0000
>> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>= ;
>> > CommitDate: 2026-01-12 07:18:11 +0000
>> >
>> >=C2=A0 =C2=A0 =C2=A0github: Add more context to pull requests<= br> >> >
>> >=C2=A0 =C2=A0 =C2=A0Add code to fetch and decode CODEOWNERS an= d automatically @ people in
>> >=C2=A0 =C2=A0 =C2=A0the review.
>>
>> Does this not just duplicate existing GitHub functionality; it sho= uld
>> be automatically assigning reviewers to a pull request based on >> CODEOWNERS AFAICT.
>
> No. It's not doing that right now at all. That's why I added i= t. Maybe there's a simpler way, but it wasn't tagging people automa= tically.

Only users with write permission for the GitHub repo work.
=

What I've done? Or CODEOWNERS? It works for me, but= I'm extra special in github land.

Warner=C2= =A0
--0000000000009e0e2906485dada9--