git: da358db1cba7 - stable/13 - ng_tty: avoid the sign extention of char
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 12 Jan 2026 17:33:05 UTC
The branch stable/13 has been updated by vexeduxr:
URL: https://cgit.FreeBSD.org/src/commit/?id=da358db1cba7402059187bd74313fa18601df609
commit da358db1cba7402059187bd74313fa18601df609
Author: Ahmad Khalifa <vexeduxr@FreeBSD.org>
AuthorDate: 2026-01-06 02:07:29 +0000
Commit: Ahmad Khalifa <vexeduxr@FreeBSD.org>
CommitDate: 2026-01-12 17:28:02 +0000
ng_tty: avoid the sign extention of char
When c is compared to sc->hotchar, both undergo integer promotion, which
can lead to c being sign extended. Fix this by casting c to an unsigned
char.
Reviewed by: kevans
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54544
(cherry picked from commit 9b2478f60bfda663c84b48e272a2293159e1b0a0)
---
sys/netgraph/ng_tty.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c
index 0e3230a66f66..200a72336110 100644
--- a/sys/netgraph/ng_tty.c
+++ b/sys/netgraph/ng_tty.c
@@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags)
m->m_pkthdr.len++;
/* Ship off mbuf if it's time */
- if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) {
+ if (sc->hotchar == -1 || (u_char)c == sc->hotchar ||
+ m->m_len >= MHLEN) {
sc->m = NULL;
NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */
}