Re: git: 27894e20f140 - main - libgeom: Fix segfault in 32-on-64 case
- In reply to: John Baldwin : "Re: git: 27894e20f140 - main - libgeom: Fix segfault in 32-on-64 case"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 07 Jan 2026 21:19:34 UTC
On Tue, 6 Jan 2026 at 09:37, John Baldwin <jhb@freebsd.org> wrote: > > Should we perhaps not use pointers to hold the cookies? This is going to truncate > in the lib32 case which will probably still work in practice as the low 32 bits of > kernel object addresses are probably unique, but isn't foolproof. Perhaps the cookie > values should be stored as either kvaddr_t values, or uintmax_t? I left a comment in the review that it would be good to at least have a comment in the code explaining the 32-bit truncation (that in practice they are probably unique).