git: 2e92aeede85c - main - bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 03 Jan 2026 02:57:26 UTC
The branch main has been updated by ivy:
URL: https://cgit.FreeBSD.org/src/commit/?id=2e92aeede85c8986bd6f4dde65d2ac2449eccf51
commit 2e92aeede85c8986bd6f4dde65d2ac2449eccf51
Author: Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2026-01-03 01:13:22 +0000
Commit: Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2026-01-03 02:57:16 +0000
bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER
Currently, we disallow BRDGSIFVLANSET when IFBRF_VLANFILTER is disabled.
There's no particular reason to do this, and it causes some undesirable
behaviour such as not being able to remove the tagged config on a member
after disabling vlanfilter on the bridge.
Remove the restriction so BRDGSIFVLANSET is always accepted.
PR: 292019
MFC after: 1 week
Reviewed by: zlei, p.mousavizadeh_protonmail.com
Sponsored by: https://www.patreon.com/bsdivy
Differential Revision: https://reviews.freebsd.org/D54435
---
sys/net/if_bridge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c
index 9a468a8eb462..5bdd8613245e 100644
--- a/sys/net/if_bridge.c
+++ b/sys/net/if_bridge.c
@@ -1990,9 +1990,6 @@ bridge_ioctl_sifvlanset(struct bridge_softc *sc, void *arg)
struct ifbif_vlan_req *req = arg;
struct bridge_iflist *bif;
- if ((sc->sc_flags & IFBRF_VLANFILTER) == 0)
- return (EXTERROR(EINVAL, "VLAN filtering not enabled"));
-
bif = bridge_lookup_member(sc, req->bv_ifname);
if (bif == NULL)
return (EXTERROR(ENOENT, "Interface is not a bridge member"));