Re: git: 887f0f125fd1 - stable/14 - Revert "GoogleTest: import 1.17.0"

From: Enji Cooper (yaneurabeya) <yaneurabeya_at_gmail.com>
Date: Wed, 25 Feb 2026 06:22:56 UTC
> On Feb 24, 2026, at 7:30 AM, John Baldwin <jhb@freebsd.org> wrote:
> 
> On 2/22/26 00:17, Enji Cooper wrote:
>> The branch stable/14 has been updated by ngie:
>> URL: https://cgit.FreeBSD.org/src/commit/?id=887f0f125fd1282c8054b402ad72af371a9f5dec
>> commit 887f0f125fd1282c8054b402ad72af371a9f5dec
>> Author:     Enji Cooper <ngie@FreeBSD.org>
>> AuthorDate: 2026-02-22 05:17:40 +0000
>> Commit:     Enji Cooper <ngie@FreeBSD.org>
>> CommitDate: 2026-02-22 05:17:40 +0000
>>     Revert "GoogleTest: import 1.17.0"
>>          This reverts commit 227baf32d26360137492b108aba06c6a54c0949b.
> 
> Please include the "why" in commit logs when reverting.  I (nor any
> other readers) have any idea why you reverted these commits.

Will do next time :/.

I reverted these changes because some of the compiler changes made on main couldn’t be backported without potentially breaking how C++ binaries are built, resulting in potentially unexpected breakage on stable/14. I might retry it in a future cherry-pick after additional testing, but for now I pulled the changes out to ensure behavior isn’t dramatically changed on the branch.

Thank you so very much for bringing this up.
-Enji