Re: git: 8f8a7f6fffd7 - main - libfetch: apply timeout to SSL_read()

Eugene Grosbein <eugen@FreeBSD.org> writes:
> [moving to developers]

[moving back where it belongs]

> Dag-Erling Smørgrav <des@FreeBSD.org> writes:
> > I did not review or approve this, and it is incorrect.
> Sorry, I did not check MAINTAINERS, indeed. Mea culpa.
> But, why is it incorrect? It was tested by other users of FreeBSD and
> it works for me and them.

* It has almost as many style violations as lines of code.

* It's in the wrong place.  You're calling setsockopt() once per read
  operation instead of once per connection.

* It doesn't fix unencrypted connections.

* It's the wrong solution.  As explained in code comments, libfetch was
  designed to work with non-blocking sockets.  All you needed to do was
  restore the fcntl() call that was accidentally dropped a while ago.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org