Re: git: 8f23665fed2f - main - pcb.h: mark struct pcb to be preserved
- In reply to: Konstantin Belousov : "Re: git: 8f23665fed2f - main - pcb.h: mark struct pcb to be preserved"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 09 Feb 2026 18:19:45 UTC
> On Feb 9, 2026, at 12:49, Konstantin Belousov <kostikbel@gmail.com> wrote: > > First, I do not mind reverting this, will do in a hour unless we get to some > other conclusion in the thread. > > Second, I want to discuss something related to the struct pcb. Right now > the structure is used for three quite unrelated purposes: > - as effectively part of the struct thread, despite being a separate > allocation when the thread is created > - as wakepcb for saving some part of BSP state suspend/resume > - as dumppcb for saving all CPUs state for vmcore > With these consumers, it seems that fields are only added to the struct, > and never removed. For instance, I do not see any use of pcb_sfmask. > > I really want to split pcb into 'thread pcb' and 'kpcb', and define > that kpcb is KBI, while thread pcb would be only stable on the stable > branches. kgdb and possibly klldb need kpcb for starting frame information > on CPUs when kernel dump does not have dwarf, am I right? I'm fine with this change. Can we have version field in kpcb? This would make debugger logic easier than using osreldate, but it's not necessary. -- Minsoo Choo