Re: git: 70aab985c300 - stable/15 - heimdal: Pass the correct pointer to free in an error case

> On Feb 6, 2026, at 6:41 AM, John Baldwin <jhb@freebsd.org> wrote:
> 
> On 2/3/26 14:10, Enji Cooper wrote:
>> The branch stable/15 has been updated by ngie:
>> URL: https://cgit.FreeBSD.org/src/commit/?id=70aab985c30092483b5b32cdd3750570ec3d9364
>> commit 70aab985c30092483b5b32cdd3750570ec3d9364
>> Author:     John Baldwin <jhb@FreeBSD.org>
>> AuthorDate: 2026-01-31 17:00:44 +0000
>> Commit:     Enji Cooper <ngie@FreeBSD.org>
>> CommitDate: 2026-02-03 19:09:55 +0000
>>     heimdal: Pass the correct pointer to free in an error case
>>          This fixes a warning reported by GCC 14 on stable/14:
>>          crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]
>>       241 |             free(hist_keys);
>>           |             ^~~~~~~~~~~~~~~
>>     crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc'
>>       234 |         ext = calloc(1, sizeof (*ext));
>>           |               ^~~~~~~~~~~~~~~~~~~~~~~~
>>          Reviewed by:    rmacklem, cy
>>     Fixes:          5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")
>>     Differential Revision:  https://reviews.freebsd.org/D54932
>>          (cherry picked from commit b26a7af438f36dcde86f39a681123cc2140affb2)
> 
> Why so eager to MFC all the heimdal fixes before the normal time?  They aren't even compiled
> on stable/15 by default?  These were at least 3 days later, but I think the last one I
> committed you merged the next day which seemed a bit odd.

Sorry — I jumped the gun looking at the date after I merged the change :/. I was trying to get rid of the build error emails and your change made sense.
-Enji