From nobody Sun Feb 08 08:45:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f81c70Pq3z6RPq7; Sun, 08 Feb 2026 08:45:11 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f81c64jzxz3qmZ; Sun, 08 Feb 2026 08:45:10 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770540310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S+MbVt4hNIXnoeZ3wytIZc9K8/sFSxWLS+bx6N0YGWE=; b=wDnqySCJ+g16Fy7jIpVBD7jWX4vFZzOD8BJSkeEN+v2ris5C7uRiBQ10gvmijpVobKLeZw eokSkjvd2cjD7hTTJ30CoNGaibRQ9MoLvnt2OQsZnSLLW/s1gMBnaGlb1UYmr/ijkyPk7b w3Q7/pAiNqbx8G6MqNKvXEhbyigwVKYxrbLqIG/Q7NO7MUVYUNgl66TrQghe6qh/CZSRhS fdP90CKr89q/DCuIWVQ2m50uydk88IPoqLRXsUs+RX7w8gSZdV471W+7q0Jt39d1pxiUZq 5Eke5oTxyF0NHrcM1YEj6xHYwXJWY7uLWxVPW33bH7Z5hbvyXKV9il06ewdmYw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770540310; a=rsa-sha256; cv=none; b=IwlUfYTL+W7V8XOEzP/SgUmhutxZzEPxYqu3ElbtOhhoZphoOwPKeYACT8Pj1FP9IkMqTG DLME0/0oHLsG47vreoQB2jekw5mR7qmMxuuMqAK589ATm+4CfcuhWj0Sm9rTa27wnxB/oM b3YmJbB+6ZnMbKTXFpQ3Viq3qUEDr2NxhrOEtHV0GJaYQWXkIsf0rMPciK/oi3frbRGfpf j7yVUkpEVHcC41lQhEWoWbrsjUBwCd+iwMXuBFGe4gSDT92Gwy8sB6WFnKcUmZAlgSA/l1 PJN6ZqLIJzUEJpnPC9NQiIcaKYIP3/8BnXtcW0sDh122iDSLoFOqjWT4q345tg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770540310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S+MbVt4hNIXnoeZ3wytIZc9K8/sFSxWLS+bx6N0YGWE=; b=jsbveDB/sThT5Kh7yBPQrxCyoXHKF+0F6y3JuraCuybjworBRnVIb40V8QdUOQ5ZD+3xg1 mPFCEd0w3WbUtDwHkbcok7AiTwTUl+qplGBNBs4HZ2+ILIzyvTVVyB4ibsD9RVBm28G3Nl W9pLKlS8o9FKMGKduR4FO5oipVSZGqwvbymmbFa7zIA9LmLNZEP5K+1v+YpVGm0WKGN0mr jjsQrlchSLPbhH/itpd1jHrf36/CxliozxlbrpBUOLQAncSrJjvj+gyENaGLksISftZCKw lNJOFtpbI3bduBcJzQJCJHcz0dS1iWHxfgDS3iKiT+SupYB/4e7zpQFdvMLhMA== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:614d:4071:7145:c2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f81c53LVnzGdH; Sun, 08 Feb 2026 08:45:09 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: git: 7b6e84c9ac56 - main - ure: improve checksum offloading From: Michael Tuexen In-Reply-To: <98155039-1cb4-4420-a66e-1b6bd94464c8@freebsd.org> Date: Sun, 8 Feb 2026 09:45:05 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <2926D3E0-F01A-4D6E-BCE7-6AB370054D67@FreeBSD.org> References: <697ddd34.3ef70.43e05480@gitrepo.freebsd.org> <98155039-1cb4-4420-a66e-1b6bd94464c8@freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3864.300.41.1.7) > On 7. Feb 2026, at 16:34, Charlie Li wrote: >=20 > Michael Tuexen wrote: >> The branch main has been updated by tuexen: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7b6e84c9ac5668134ab2d075019ef0b8= 27d90c84 >> commit 7b6e84c9ac5668134ab2d075019ef0b827d90c84 >> Author: Michael Tuexen >> AuthorDate: 2026-01-31 10:42:10 +0000 >> Commit: Michael Tuexen >> CommitDate: 2026-01-31 10:42:10 +0000 >> ure: improve checksum offloading >> This patch fixes three issues: >> (1) Initially, set the hwassist flags correctly when enabling >> transmit checksum offload for TCP/IPv6 and UDP/IPv6. >> (2) Keep the hwassist flags in sync with the capabilities when >> changing txcsum. >> (3) Keep the hwasssit flags in sync with the capabilities when >> changing txcsum6. >> Without this patch, transmit checksum offloading for TCP/IPv6 and >> UDP/IPv6 is never used and transmit checksum offloading for IPv4, >> TCP/IPv4 and UDP/IPv4 is always used, even if disabled via >> ifconfig ue? -txcsum. >> Reviewed by: Timo V=C3=B6lker >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D54974 >> --- >> sys/dev/usb/net/if_ure.c | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/sys/dev/usb/net/if_ure.c b/sys/dev/usb/net/if_ure.c >> index c3f7b622d687..3dea88eb10f1 100644 >> --- a/sys/dev/usb/net/if_ure.c >> +++ b/sys/dev/usb/net/if_ure.c >> @@ -1015,6 +1015,7 @@ ure_attach_post_sub(struct usb_ether *ue) >> if_sethwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >> #ifdef INET6 >> if_setcapabilitiesbit(ifp, IFCAP_HWCSUM_IPV6, 0); >> + if_sethwassistbits(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP, 0); >> #endif >> if_setcapenable(ifp, if_getcapabilities(ifp)); >> @@ -1463,6 +1464,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >> if ((mask & IFCAP_TXCSUM) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_TXCSUM) !=3D 0) { >> if_togglecapenable(ifp, IFCAP_TXCSUM); >> + if_togglehwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >> } >> if ((mask & IFCAP_RXCSUM) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_RXCSUM) !=3D 0) { >> @@ -1471,6 +1473,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >> if ((mask & IFCAP_TXCSUM_IPV6) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_TXCSUM_IPV6) !=3D 0) { >> if_togglecapenable(ifp, IFCAP_TXCSUM_IPV6); >> + if_togglehwassist(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP); >> } >> if ((mask & IFCAP_RXCSUM_IPV6) !=3D 0 && >> (if_getcapabilities(ifp) & IFCAP_RXCSUM_IPV6) !=3D 0) { > It seems that with this commit, all network traffic and then some, = excluding ICMP{,v6}, time out. Even `route(8) get default` takes forever = to query. Do you use a GENERIC kernel? What is the output of ifconfig ue0 and (if you compiled and installed tools/tools/ifinfo/) ifinfo ue0 What happens if you run as root ifconfig ue0 -txcsum and/or ifconfig ue0 -txcsum6 Does the problem persist? This commit should actually only let the host stack know that TCP/IPv6 = and UDP/IPv6 transmit checksum offload is enabled. It should not affect TCP/IPv4 and = UDP/IPv4 transmit checksum offload (except that you can now disable it). Is any other network interface (like epair, bridge, ...) involved? Best regards Michael >=20 > --=20 > Charlie Li > ...nope, still don't have an exit line. >=20