Re: git: 804329587508 - main - hwpstate{_amd,intel}(4): Move common knobs to a separate file
Date: Fri, 06 Feb 2026 19:00:55 UTC
On Fri, 06 Feb 2026 17:23:19 +0100, Olivier Certner wrote:
>
> The branch main has been updated by olce:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=8043295875083b57a6b7b2dc6826fde4cf4e1ba1
>
> commit 8043295875083b57a6b7b2dc6826fde4cf4e1ba1
> Author: Olivier Certner <olce@FreeBSD.org>
> AuthorDate: 2026-02-06 10:58:07 +0000
> Commit: Olivier Certner <olce@FreeBSD.org>
> CommitDate: 2026-02-06 16:23:07 +0000
>
> hwpstate{_amd,intel}(4): Move common knobs to a separate file
>
> Reason for doing this right now is to resolve the conflict on
> 'machdep.hwpstate_pkg_ctrl' between the Intel and AMD drivers, even
> though I expect to remove it for hwpstate_amd(4) at some point.
>
> More generally, this is going to be useful for some future code
> factorization. Also, the 'debug.hwpstate_verbose' knob was moved there,
> as we'll likely want to use it for the Intel driver as well (which is
> currently not the case).
>
> Note for MFC: Will be partial, since `hwpstate_amd(4)` does not support
> CPPC in stable/15 nor stable/14.
>
> Reviewed by: emaste
> Fixes: 3e6e4e4a0d42 ("hwpstate: add CPPC support for pstate driver on AMD")
> MFC after: 2 weeks
> Differential Revision: https://reviews.freebsd.org/D54528
> ---
> sys/conf/files.x86 | 1 +
> sys/modules/cpufreq/Makefile | 3 ++-
> sys/x86/cpufreq/hwpstate_amd.c | 11 ++---------
> sys/x86/cpufreq/hwpstate_common.c | 22 ++++++++++++++++++++++
> sys/x86/cpufreq/hwpstate_common.h | 13 +++++++++++++
> sys/x86/cpufreq/hwpstate_intel.c | 6 +-----
> 6 files changed, 41 insertions(+), 15 deletions(-)
This commit seems to break GENERIC_NODEBUG.