git: 4ac3081b2828 - main - qlnxe: Remove a pointless copy back from the link-layer address

From: Zhenlei Huang <zlei_at_FreeBSD.org>
Date: Fri, 06 Feb 2026 17:59:26 UTC
The branch main has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=4ac3081b282800158df7abe93f307d76e1b5b808

commit 4ac3081b282800158df7abe93f307d76e1b5b808
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2026-02-06 17:52:53 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2026-02-06 17:52:53 +0000

    qlnxe: Remove a pointless copy back from the link-layer address
    
    On ifnet attaching, ether_ifattach() makes the link-layer address by
    shadow copying the ha->primary_mac. Well, the link-layer address will
    not be altered during attaching, thus it is pointless to copy it back.
    
    No functional change intended.
    
    Reviewed by:    kbowling
    MFC after:      5 days
    Differential Revision:  https://reviews.freebsd.org/D54883
---
 sys/dev/qlnx/qlnxe/qlnx_os.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c
index 99110e5e2d8f..9616d9f4d611 100644
--- a/sys/dev/qlnx/qlnxe/qlnx_os.c
+++ b/sys/dev/qlnx/qlnxe/qlnx_os.c
@@ -2392,8 +2392,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha)
         ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO));
 
 	ether_ifattach(ifp, ha->primary_mac);
-	bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN);
-
         QL_DPRINT2(ha, "exit\n");
 
         return;