From nobody Fri Feb 06 15:59:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6zLJ0B2wz6RNDk; Fri, 06 Feb 2026 15:59:36 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6zLH4p21z3ynV; Fri, 06 Feb 2026 15:59:35 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770393575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AAAleocPvqeRZllqL2Nf2roFk07g18D05j8CwVY5DA4=; b=JRpvm8HJ4q/IjbRSMxuv2b82mXU1g+05tqr9aTWkUa9nlQ8lBc138MmtXvW5GDnQyw4qGo A1c9KOJ2dXfWGc5KQWauz7r/8arNjowIYo6fBFsIwsPkLzzqffGxfGlmLfh/3jZeTALaxy Lg+q/IgOWxdwUwTOT11eDj3utz2BZC/orAC4jyqqy/f2uitwjnNPlZBzfvM6vbGbJnQf4C E57+cZBSwduw5kimHJnQuR/oaxCldfIEPi9yOp4HQKA7FI01dLABAyEDTYzPRklPoiftZk mxx6GyNsMY4SuFbM6sQjYDFLcxzBx5oYNvpgBFzHVPF/Sr7gBCQZbySiGOy7Sg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770393575; a=rsa-sha256; cv=none; b=yOqVXfKAxBC06FKDoEzrgy6WpLCymfxiMMb8/chLIRerihTlZBWHwZxJXmkmxO4lGHrGDs BxAQ/TU9u431qDLA2qO7GIxOT+TtOdj6ovQI2zgHcCpOLfsRVQhH8mTIpzxH27/X7R8oox ypCO7HPEaqyEPyv3catbKR+2Dc+apJMM6wgDTVQQ/eoHgj1zh/N+qP7caUYf3ShU4U58JP GIvMVNqrKXgkkYCcZgYOU+UjHM5mGv77/VtPEziU18Zjn2c75uSRd8fmQQqyj2rQjgy6rm 43R709GX4yhfvw4pcYc4Zc5u0NsrG6kEzeHh1VD/zQBKlNvtnayo5ZJYItp8kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770393575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AAAleocPvqeRZllqL2Nf2roFk07g18D05j8CwVY5DA4=; b=QLVGCz6O5rmmVvJUiby2x4jo6Oo2J3Zd+FGwL1XsnlwOVp/RxkcihM0zyN7dfE0/e7uHX+ O6wjQL7xvml2vW07OLmD+TuRLbrqS5KwgzBiUnC4PnI946VGQX7QklqLNrK9CWKyF+kEQ8 Mhv8p3TeSK85J7Ca78jAZrZquop2kyw5kW3rc0uPHpqhSFRQ79c9EOmwfhD0EYD3ny/yDp Q5KiQ2tsgkAsWXouob5b6QcuThaPlMPrsneMxT5YWnQR2KSf5WS/Cls3vFwcxtqUdyXP9J VJrlJV1adbKJ9uxXvtWRvtuLqTP5jkfoqruKne/yJQdktdlzSVWkhkT/9lTw1A== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f6zLH2MySzMDN; Fri, 06 Feb 2026 15:59:35 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <11fddfa0-41fd-430a-8ecb-8afa27385878@FreeBSD.org> Date: Fri, 6 Feb 2026 09:59:33 -0600 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: c0df8f6f0e6a - main - acpi: Make taskqueue only run on BSP To: Aymeric Wibo , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <695f8abf.30bec.62a9009@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: <695f8abf.30bec.62a9009@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/8/26 04:45, Aymeric Wibo wrote: > The branch main has been updated by obiwac: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c0df8f6f0e6a5f77ec9140e8075d09c55fe4c3c7 > > commit c0df8f6f0e6a5f77ec9140e8075d09c55fe4c3c7 > Author: Aymeric Wibo > AuthorDate: 2025-12-29 20:01:50 +0000 > Commit: Aymeric Wibo > CommitDate: 2026-01-08 10:35:54 +0000 > > acpi: Make taskqueue only run on BSP > > This is needed because when we add the suspend-to-idle loop, we only > want to break the BSP out of idle to process the taskqueue while keeping > all the others idled. > > Currently assuming BSP to be CPU0, which may not always be the case on > non-x86. > > Reviewed by: kib > Approved by: kib > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D54406 > --- > sys/dev/acpica/Osd/OsdSchedule.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/sys/dev/acpica/Osd/OsdSchedule.c b/sys/dev/acpica/Osd/OsdSchedule.c > index f0464709e8ad..0c5eadb87687 100644 > --- a/sys/dev/acpica/Osd/OsdSchedule.c > +++ b/sys/dev/acpica/Osd/OsdSchedule.c > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -109,10 +110,13 @@ static void > acpi_taskq_init(void *arg) > { > int i; > + /* XXX Currently assuming BSP is CPU0. */ > + cpuset_t just_bsp = CPUSET_T_INITIALIZER(0x1); > > acpi_taskq = taskqueue_create_fast("acpi_task", M_NOWAIT, > &taskqueue_thread_enqueue, &acpi_taskq); > - taskqueue_start_threads(&acpi_taskq, acpi_max_threads, PWAIT, "acpi_task"); > + taskqueue_start_threads_cpuset(&acpi_taskq, acpi_max_threads, PWAIT, > + &just_bsp, "acpi_task"); > if (acpi_task_count > 0) { > if (bootverbose) > printf("AcpiOsExecute: enqueue %d pending tasks\n", > Hi, Mentioned privately, but also bringing it to the list in case anyone else has had the same symptom- updating my frame.work laptop from ~December main to ~February main resulted in a power-button wakeup shutting down the system after it wakes up. The result of a bisect pointed at this commit reliably causing it, and reverting it locally does seem to fix it. Thanks, Kyle Evans