git: 7bdf066ad212 - stable/14 - ifconfig: fix logical error in interface matching for '-l ether'
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 05 Feb 2026 18:12:17 UTC
The branch stable/14 has been updated by zlei:
URL: https://cgit.FreeBSD.org/src/commit/?id=7bdf066ad2123709cd190dc7610c21c8bb4df5e4
commit 7bdf066ad2123709cd190dc7610c21c8bb4df5e4
Author: Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2023-08-25 17:30:25 +0000
Commit: Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2026-02-05 18:10:35 +0000
ifconfig: fix logical error in interface matching for '-l ether'
This affects only ifconfig(8) compiled WITHOUT_NETLINK_SUPPORT, which
is not the default.
Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D41584
Fixes: d1cd0344f7b7d81beda04c3cb8cfee99351c3eb8
(cherry picked from commit 24a81a968d21b3eef1a0a2d786859b274546bd34)
---
sbin/ifconfig/ifconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sbin/ifconfig/ifconfig.c b/sbin/ifconfig/ifconfig.c
index ccc783c64ff9..f4ac045bccea 100644
--- a/sbin/ifconfig/ifconfig.c
+++ b/sbin/ifconfig/ifconfig.c
@@ -771,7 +771,7 @@ match_afp(const struct afswtch *afp, int sa_family, const struct sockaddr_dl *sd
return (true);
/* special case for "ether" address family */
if (!strcmp(afp->af_name, "ether")) {
- if (sdl == NULL && !match_ether(sdl))
+ if (sdl == NULL || !match_ether(sdl))
return (false);
return (true);
}