Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware
- Reply: Enji Cooper (yaneurabeya): "Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware"
- In reply to: Enji Cooper (yaneurabeya): "Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 04 Feb 2026 21:17:50 UTC
On Tue, Feb 03, 2026 at 10:25:27PM -0800, Enji Cooper (yaneurabeya) wrote: > > > On Feb 3, 2026, at 2:38 AM, Konstantin Belousov <kostikbel@gmail.com> wrote: > > > > On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote: > >> I agree that this should not be permanent verbosity. > >> > >> The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models. > >> > >> I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code. > > One sidenote: this is hidden behind bootverbose: it’s not always being displayed. > > I think it’s fine making the message more terse. It might clarify behavior on Apple platforms since the added behavior contradicts other OSI-related behavior and can result in a POLA violation. Can you fix it, please, instead thinking that it might be fine?