From nobody Tue Feb 03 19:10:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5CjW0LKwz6QbMw for ; Tue, 03 Feb 2026 19:10:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5CjV6DRFz3ZVk for ; Tue, 03 Feb 2026 19:10:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770145806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jQFs/yV6k4SmsQeuEk8uE3zCEukhllm4jpiVCGc6f64=; b=MWbzCuOyj/irg5TiTZnQLbqFK8Ae121Vje4cxFYf9Jc8LCgZhRRLfekvMzFXXhYKy66C8p VpZA75JtLQrmb/Hq1BcQcHVU/pe0398CP481sH19M8KxRuBswY1xLBZAT+Ca9MiPK8ukpc IoE/Lym6vMbryE6bYhM0lJLcaNkNXly49Fr8U1LQRpg6LqD7xPfXrDB6PMjNyumZ5BA5RR 33ZhbU0KgArEEvyH7cIqDBlLC7i6kxHITClkvGtnDzeV2/O3kWN+RrjMFySsnK1x5pYFMS i34Vz3pm2Sur/p1ZyHGNg3hJ473YX9TkPgP4AUJZNp0CmCaqb7+lY23qbKZeMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770145806; a=rsa-sha256; cv=none; b=IfyklePJSPVofUc4u1J4RY5K7WrEuYwi6DnJ8gae07y4fG8ej+vT5s4KldACJs84NSBXQ6 Ql5kAmFTBOcgAn37CMsVFopTREvFhTd3xehUsx0Nv+yHZcf94GaOoie4yjXvz7FBnHVybh tnDtyV+kOWCoPzJsPm19sQ6NFDX7p0b3G/lJxSqNPCzY0G5Ua2jseIwUf2SXJ314+FGO9F hamxKZ6rTYFPoKMbVID7yesUjM6WtRT/53OVljJIHQXa8/ZpH+CwhiQNurMFznB7Hj4KsC H+X6NssgNQWL/2yMhORO5rn+gDkQjOavk+BU73bNLjNxRETuwZVhY4tBlhXQRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770145806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jQFs/yV6k4SmsQeuEk8uE3zCEukhllm4jpiVCGc6f64=; b=L0RhljCztLgM1Mr/roFUm1TQFrksFln2oTPlOVcG1k1EBbDAgMcnu7Qy0WJTQjTcQqgVfq 2uyGim1JE8dqVGDJacNJfLCgsKVZLy9mGtM6Pl31bQ0SM1ctEPlEbI04ei3S3w5Gj5Fi57 tJFYfZ0yCK35vplm5Is+0YT+bA3K7VlYD3lNCnJcyOC8Lbi35J3qEhx9DCGVgQUn9IIIu0 iocpuhTXKkSlfkbPY/mpiJZ09iHWfY5jcybv1IEH/JYfgLU+x6ZwTUFD+xuT7dJNYG7usR FgaLl+elsnAW6E6LOjbPshJUks0v6RkR+e0A7wX+212x7DW9T2gsPloOlKrWKw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f5CjV5npVz9xB for ; Tue, 03 Feb 2026 19:10:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3097b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Feb 2026 19:10:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: John Baldwin From: Enji Cooper Subject: git: 70aab985c300 - stable/15 - heimdal: Pass the correct pointer to free in an error case List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 70aab985c30092483b5b32cdd3750570ec3d9364 Auto-Submitted: auto-generated Date: Tue, 03 Feb 2026 19:10:06 +0000 Message-Id: <6982480e.3097b.628edb67@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=70aab985c30092483b5b32cdd3750570ec3d9364 commit 70aab985c30092483b5b32cdd3750570ec3d9364 Author: John Baldwin AuthorDate: 2026-01-31 17:00:44 +0000 Commit: Enji Cooper CommitDate: 2026-02-03 19:09:55 +0000 heimdal: Pass the correct pointer to free in an error case This fixes a warning reported by GCC 14 on stable/14: crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] 241 | free(hist_keys); | ^~~~~~~~~~~~~~~ crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc' 234 | ext = calloc(1, sizeof (*ext)); | ^~~~~~~~~~~~~~~~~~~~~~~~ Reviewed by: rmacklem, cy Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54932 (cherry picked from commit b26a7af438f36dcde86f39a681123cc2140affb2) --- crypto/heimdal/lib/hdb/keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/hdb/keys.c b/crypto/heimdal/lib/hdb/keys.c index 9c0af5c47f23..ef6113610009 100644 --- a/crypto/heimdal/lib/hdb/keys.c +++ b/crypto/heimdal/lib/hdb/keys.c @@ -238,7 +238,7 @@ hdb_add_current_keys_to_history(krb5_context context, hdb_entry *entry) hist_keys = &ext->data.u.hist_keys; hist_keys->val = calloc(1, sizeof (*hist_keys->val)); if (hist_keys->val == NULL) { - free(hist_keys); + free(ext); return ENOMEM; } hist_keys->len = 1;