Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware

On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote:
> I agree that this should not be permanent verbosity.
> 
> The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models.
> 
> I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code.
> 
> 
> On Tue, 3 Feb 2026, at 08:56, Konstantin Belousov wrote:
> > On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote:
> > > 
> > > > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov <kostikbel@gmail.com> wrote:
> > > 
> > > ...
> > > 
> > > >> + if (ACPI_SUCCESS(status)) {
> > > >> + device_printf(dev,
> > > >> +    "Apple hardware: installed Darwin "
> > > >> +    "OSI and removed other vendor OSI "
> > > >> +    "(Windows, etc)\n");
> > > > Why this verbosity is needed?
> > > > 
> > > > I see no benefit from it, other then consuming kernel memory.
> > > 
> > > I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit.
> > 
> > Yes, I think that this verbosity is not warranted.  If you want something
> > to be printed, much shorter messages would be enough.  But I am not sure
> > that any messaging is needed.
> > 

Note that there are two things.
One is the overly long and IMO unhelpful musing about what happen: what is
installed, and what is removed, and especially the 'Windows, etc' part.
This can be shortened to simple informational message, that allows to
identify the successful action, without musing about its origin and possible
effects.
Another is the removal of the printing at all.

I am sure that the first issue should be fixed now, if some informational
printing is going to stay for (limited) time.