Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware
Date: Tue, 03 Feb 2026 07:56:12 UTC
On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote:
>
> > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov <kostikbel@gmail.com> wrote:
>
> ...
>
> >> + if (ACPI_SUCCESS(status)) {
> >> + device_printf(dev,
> >> + "Apple hardware: installed Darwin "
> >> + "OSI and removed other vendor OSI "
> >> + "(Windows, etc)\n");
> > Why this verbosity is needed?
> >
> > I see no benefit from it, other then consuming kernel memory.
>
> I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit.
Yes, I think that this verbosity is not warranted. If you want something
to be printed, much shorter messages would be enough. But I am not sure
that any messaging is needed.