From nobody Mon Aug 31 19:13:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hYdvV61cRz6rG3S for ; Mon, 31 Aug 2026 19:13:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hYdvV5QTFz3hWB for ; Mon, 31 Aug 2026 19:13:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788203638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=03wW3Ns1jNPSMBqCqKp0qYXUKy/p6caeZsrNzme1bS0=; b=JJdV5Mhd9J7nSSb+pJirfD+p83hc12CWKQ2EzEuiiRQXDyHpSOTVA9M6cFy834wUxcgeIw mVCtKniFDxBevK68KhKgUsNjdWEL1klF2FBXWwmzphefJa/Q5eSrpD3aKowy0jNBvrfG66 KlwgmZ81mTi+Au4pJVR6GyMazMxpRLT1T3W5kXNZSp3ABaP8uSaP1oVOhGoMVLGEZ9XMy8 2HGJ45qyB+cvTcAFkQbs5kgj8Fq1rXI+hV9VvVuUkZE4P8AdeY/QlQtF31wx8hRIPP8XRy z7NiMfHRz/7oZSaXodbKNdr7vjXwyg2YNbPKpbW7NIe2Fxnr7axJ6M9z8V8wbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788203638; a=rsa-sha256; cv=none; b=r7mSKZVXw3jFLcBTciHiI9/cG7asaRS8KdgsIufLzF+o1iZGLcMWTLq5rzTEtB/Mdt4QzI ownP4SmvR4sP1lSMOiVXYrnuxA1fw8WGpoiiuG5Kes8SpIjIzBXK4/C//4qIGej4RS96Al n9e+vlBew6ra3CjkEZY6Okf8aeb67uvmLhyUnZUAYhH5PkdUCjW8kQWdavfdkfVr6/Lcho 8Nr3OG9MFMCISFMD7LhLu0qxPr2UyMIJZyGMzsofaN399LgAsPFyAJMwMh13DYotmAYw1W 7lj5uk2MKbq85ijEc6V/YJDE2kPbBQ26eAIaUwbulbCcO78QrSuJF8xEsD96/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788203638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=03wW3Ns1jNPSMBqCqKp0qYXUKy/p6caeZsrNzme1bS0=; b=ML4wHbwGTehqhN6pbqwkNCz/8OGnIZ0k+xETwT5euf+3SCQuRxJDaIXi6yntxLJTQSpGyE CExEkWpvsnX9cWCgwUIP/YSnRN1ZGuAP5kNmwDCn8Nld/+lcm9NkVKJgDUQuqG998ZsUYe JXwYOHgybIcZzZ7QoX32EAbUKta6rHufgvmFS7iuvmnlIKCzleQ5inFgYPXhPDnGLoX8Dp BLBEOFL+tIFj1nV+qHTIWPR6VaUCIpPr5VW45WWXr9WUNZrdXqwV52IFtZc4bCR7tbzlKg PcggtyYmNkTatfSfTMybKci46PRPO+C2+Ul/5S92T3lF+hifXp+rshqQYYf/bg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hYdvV4P1Qz8ss for ; Mon, 31 Aug 2026 19:13:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43527 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 31 Aug 2026 19:13:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 6ddb10cf6b7f - main - gstat: Set errno = 0 before strtoul List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6ddb10cf6b7f870d749e96d2ae55976b18896f54 Auto-Submitted: auto-generated Date: Mon, 31 Aug 2026 19:13:58 +0000 Message-Id: <6a95d276.43527.27d78f18@gitrepo.freebsd.org> The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=6ddb10cf6b7f870d749e96d2ae55976b18896f54 commit 6ddb10cf6b7f870d749e96d2ae55976b18896f54 Author: Colin Percival AuthorDate: 2026-08-29 20:22:15 +0000 Commit: Colin Percival CommitDate: 2026-08-31 19:13:52 +0000 gstat: Set errno = 0 before strtoul The strtoul function sets errno on error, but does not clear it on success; when using strtoul and checking errno (as one should) for ERANGE / EINVAL afterwards, it's important to zero errno first. While here, remove a dead store. Reviewed by: phk Fixes: 4fe8c1b67be0 ("Add error and range checking ... ") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D59270 --- usr.sbin/gstat/gstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/gstat/gstat.c b/usr.sbin/gstat/gstat.c index 2b991788cd9e..44e5689733ad 100644 --- a/usr.sbin/gstat/gstat.c +++ b/usr.sbin/gstat/gstat.c @@ -440,7 +440,7 @@ main(int argc, char **argv) use_gb(); break; case 'I': - p = NULL; + errno = 0; i = strtoul(optarg, &p, 0); if (p == optarg || errno == EINVAL || errno == ERANGE) {