From nobody Sun Aug 30 01:04:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hXYnZ3245z6pnWb for ; Sun, 30 Aug 2026 01:05:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hXYnY66z7z3h9h for ; Sun, 30 Aug 2026 01:05:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-cc147d86bebso2543120a12.0 for ; Sat, 29 Aug 2026 18:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788051902; x=1788656702; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Zww1WplZs9AfbrLdvTo16k9jIHSL//b//gAiYGIwFLw=; b=jeRIwpjIDFNCUWGoqWe3KlhPokhzG1rwqapwzizVAKlWRHGE+LIVV5L2ygur0LivyZ j6ulsUT4x4WKkf6S7BiKQ3JmlPyQi3I6EkiGcpRWTSFFzTRU6VFxB/U5A+4BAIwdPir2 SKR9+miG4Rft2tQtWVCuy7SjfAAZl74GElJkyl4yb9JtPNJ9/LtkYVKQMGyvxyW37ge+ SIoPPEc1rN26SwGVIDG2LRVgKLnE5QxO3RSk3UHQ0oljWX8tNHBoK/JHBu9mv8EqaPLC 1trJasZ27EAvvInYE7nlQ8VVBZpMm2Ft05dX1At76dTodh+AEp7sxrcsNYatBIxuzBgK 8IJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788051902; x=1788656702; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zww1WplZs9AfbrLdvTo16k9jIHSL//b//gAiYGIwFLw=; b=ov/1v0bhRAtcQoBQUtPLcZ+yf8QkvpaZyr2ksrmdqcNNBqjrqOtIwX8QCQwej/0fW8 hPQQoTPXb7XogYGiagNU4Q2S//+1stbqyACbVMxOGxelWy5I/+x+CDT6+st2vrCl+UsJ aNDVeUFKFlXrM+FV0mNdwTOj1cxuV8m/CwPQno0DVxF4GYFHsehb3YYt4tmB0SD+SlXg aAHwB1sZ/CzIBxg0zpcUbwkwdYzhQXCcRm2kYYt3Z1/WC4fGPMkADUvcJiOpW/ugJ8wZ S+ABJIbQLWHrbAPAhdE58BdCJQmeOdL3gXhYylNaziQ6SC/hNo/Eix4SCBKKTo6g6b1q CY3A== X-Forwarded-Encrypted: i=1; AKwUvBx3uy7F7XutHlR5cJqTjRoWuv2/IHqGWj1QHX+n0xWH61UfBNHPjMC35oxNBvzGNt0bfnXB2CEhEWW7mSYcrW2STHbu@freebsd.org X-Gm-Message-State: AFuF++kRF6xjv9Yrx3mtOq2KY2eBDGsGQgZkyh2/G9cyBUcA2SYw/osV xgE9qjyWNMldukxwoKgR4mIBd2kvDVGDT91b5Il8w71ybKtGT0MJJHmMmZ4MFEsQQQw= X-Gm-Gg: AYBFou1YTat9OiyxhT5PMLXXAsy4mo3lDGpyHQhg9papyi2n4YBpBXichdHQGGkLoTP s29YeISd5WRdQoFEpK2FlO/GqHB9i00Ty5/UCVNfrkrL7hywefLvTAEoxSSufyT7QjeTlYv/74q IKJXIcfTPas7sdS8Y/g8SW37YdU7j9u5FXrTrxbIu9AHTp5M9edMPkcb174heX/+mZdbyvD/pFU 0gC+UX28rKQ5KBubFlvj/4R3BrzLh88aTB0SH6AZNnAbrYZoDL4JqHxf1lMdeHWuoWyMtbWFi3j xz6CtB5UTQT1PE/GIUNR7Ki3zhRSYnZb9RGZv3wfYQwkPy54QrvVfUCeSlTwHnR+vJJPLXIwNKL b4MX0t8kHxFKj2+G6pHk7IOgOo3jPWVyukDdkhC2JCn8KpB81RJcv5gbMahEDaCgjufQiHSQEgh 5x3saYsGkAD59xYZmhMP/RFGZlYJUN4CyVvpBOdqWme2iHdk3dSs8G4b2f6hFIJeD1ed6XPt/Ks C6vtBNGAD9qI3Zwho3KXA== X-Received: by 2002:a17:90b:2f0b:b0:398:ba46:1d9f with SMTP id 98e67ed59e1d1-398d8573905mr26014a91.13.1788051901868; Sat, 29 Aug 2026 18:05:01 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.53]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b19927a1sm14430011a91.14.2026.08.29.18.05.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Aug 2026 18:05:01 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <6EC5F46C-321D-4AAD-96A5-1D86E70131D9@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_7EC94EDB-FD1F-4A1D-8D97-F41627876432"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: edadc3f90515 - main - whereis(1): Respect PORTSDIR variable Date: Sat, 29 Aug 2026 18:04:48 -0700 In-Reply-To: <6a92f863.42fd6.5636da14@gitrepo.freebsd.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: =?utf-8?Q?Fernando_Apestegu=C3=ADa?= References: <6a92f863.42fd6.5636da14@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3864.600.51.1.1) X-Rspamd-Queue-Id: 4hXYnY66z7z3h9h X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- --Apple-Mail=_7EC94EDB-FD1F-4A1D-8D97-F41627876432 Content-Type: multipart/alternative; boundary="Apple-Mail=_151A5C3F-8B82-419A-923A-706CDB70D4D5" --Apple-Mail=_151A5C3F-8B82-419A-923A-706CDB70D4D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 29, 2026, at 8:18=E2=80=AFAM, Fernando Apestegu=C3=ADa = wrote: >=20 > The branch main has been updated by fernape: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dedadc3f9051595a9c2e693d8ab666a50= b9e7a21a >=20 > commit edadc3f9051595a9c2e693d8ab666a50b9e7a21a > Author: Fernando Apestegu=C3=ADa > AuthorDate: 2026-08-23 15:46:18 +0000 > Commit: Fernando Apestegu=C3=ADa > CommitDate: 2026-08-29 15:15:43 +0000 >=20 > whereis(1): Respect PORTSDIR variable >=20 > PORTSDIR is a very common variable that points to the location of a = ports > directory. Make whereis(1) respect this variable too. >=20 > Reviewed by: arrowd@, christos@ > Approved by: christos@ > Differential Revision: https://reviews.freebsd.org/D56845 Hi fernape@, This commit is referencing the wrong issue [1] and the code = change has not been approved [2]. Please revert this change and commit = the correct diff for [1]. Thank you, -Enji 1. https://reviews.freebsd.org/D56845 2. https://reviews.freebsd.org/D42156= --Apple-Mail=_151A5C3F-8B82-419A-923A-706CDB70D4D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On Aug 29, 2026, at 8:18=E2=80=AFAM, Fernando = Apestegu=C3=ADa <fernape@freebsd.org> wrote:

The branch main has been = updated by fernape:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dedadc3f9051595a9c2e693d8ab666a50= b9e7a21a

commit = edadc3f9051595a9c2e693d8ab666a50b9e7a21a
Author: =     Fernando Apestegu=C3=ADa = <fernape@FreeBSD.org>
AuthorDate: 2026-08-23 15:46:18 = +0000
Commit:     Fernando Apestegu=C3=ADa = <fernape@FreeBSD.org>
CommitDate: 2026-08-29 15:15:43 = +0000

   whereis(1): Respect PORTSDIR = variable

   PORTSDIR is a very common variable = that points to the location of a ports
   directory. = Make whereis(1) respect this variable too.

=    Reviewed by:    arrowd@, christos@
=    Approved by:    christos@
=    Differential Revision: =  https://reviews.freebsd.org/D56845

<= /div>
Hi fernape@,
This commit is referencing the = wrong issue [1] and the code change has not been approved [2]. Please = revert this change and commit the correct diff for = [1].
Thank = you,
-Enji

= --Apple-Mail=_151A5C3F-8B82-419A-923A-706CDB70D4D5-- --Apple-Mail=_7EC94EDB-FD1F-4A1D-8D97-F41627876432 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmqTgbAACgkQGpE5DjPs NJjzcg//YHVMNoFUkMZaV03kDe6R1oh3tpUC6QSi7v8TgS7NL+HOEy9PkzSm4SbK 84so3xZRHuyHSWxzH+rgbnWJoA8f666exkSzCWjFvzGy8VAqn/IcOFKWpc12WCv4 hOmkk6eOWVOx8fSe3e40RJwNrrz+mX/Y/MTXbj1X54VSQxypYrJKLGQa26cVd2Uz MXN8zi51kOXVdfHqfFaKEdJeDTNCHhkZtd9QcxqJEQn1MZz1wJ+rJ4KeSF8x728q 6z+AtqoW9liB2au5MUmZss9nJobuqhD6k0exoy2yKdHcE6fzKnUhH46ZsxCSvugf GguuwoeEqy4WLNeK2V4KyOd08d6o3vUrntqsI0HWJ6mGh8NwmrHGn/eiflz8VvHi 2hrSoUHkAecsS0Cp5f3lVUNhPMau8PPz4roEToLInvvdhSKImDT5az3XHfwslPS0 zVlFomihle5V1bPbBty6+06iGK1jB2B78bqI9AxCNA5uxXbCpoZpckTA+nIKfU+J SDzeEJa9xc+aTtLO3g6J3HPAbf8sdPBzsV+HC946lzQTdYDNeHR4kGuObaynVW+0 KVJFv7sJogZuV2LAwLZKT2PJ+pA/GYNPXwRJV9B8pvDqNhbDl9zSpgzYcY+AXjHN XiCg/cj7FgDCOCm/BLrxkunLKNazp7TnLJooTPBecKpaR41CqiM= =PbN6 -----END PGP SIGNATURE----- --Apple-Mail=_7EC94EDB-FD1F-4A1D-8D97-F41627876432--