From nobody Sat Aug 29 20:57:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hXSJ70YTVz6r6KX for ; Sat, 29 Aug 2026 20:57:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hXSJ64rnPz45Q5 for ; Sat, 29 Aug 2026 20:57:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788037062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GoXEeWBxlDPyZckA/ReRS2NtEizXrCcsojPneXHor2Y=; b=INBNMOs5CD73vYQtyI+gV/4/4w51IjJeoLmTxbls+G8M5dBxwazT+8dHihRZrZvtvxIRK9 qiAjjsJ2SbaXsdsxSgTxgkOoYVpJ0rVksUeOpmbKJf9f1BOBtg8duWoL32RsJBcjD2wXpQ KmbphBs7Cpv59YS1711DsodWgIn6sCM6JHIg1ApwXnG3AzS/TIV+6+VNHbIhUKn00UMEgh R7Z8LCcmBSmY2Ha8WEJrZYPHn5+uO9EzXltUcM91OK4VoOd7KhPstyli+un/b9aMJZA5cg SsKo2gIeMITvYzGuz4GAH/1FHapObe52FFqEqkcy0EIvSMki0MF/e2/biRa+qg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788037062; a=rsa-sha256; cv=none; b=HkZu/cjNEDwr9oygjDdJhlWN8UmZqqXZT+h6tcYeMP6ewMD9jN4j03AXAt587i89mabyeQ jBwA+xszWyYvsaLHN5jFYcYE2fdB7zCcuG0D0nEytmcUJoTwfkbwSjIrv7XI842TxMFc/N 3wpM0eMINU0wC53yEjMSsKwGs8T7hgZtaQLk+Tm2xyZQix/gK5DqNgRWJY2ws0nYuVG5/n uWY89es/PXAuigfrxtcH5VvZeFIX3vza7RbsAMDSSwGzfXgUpxCjHnehxCHKPlBDWcvQoc 00YkqSURKOVD+MUdUJpMw72ezQvivKvOBly0zK8adNw3aRK2f1Lxfn7ziDdXyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788037062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GoXEeWBxlDPyZckA/ReRS2NtEizXrCcsojPneXHor2Y=; b=d13fHXLXGIt+NX+Hd8/kvvvdIdcWIBzAE1lXIxn54mz2pRdYU8/1L232bhhL0k2jN4UvBs Z5w4Gc5+JirL3/jaTPhMuaxgnSQRILHLwV5Wr+MvBQBLjuP9wn2dKQHzzEaFVKo6TjdSs9 9SiCZwNqfH9GBPZrXDLGPD6Zocmu0d7BeDXJrK1nLVqhMKys8ywQxD0jUxeVfkvQ0de/br qMzuGO8YlkHFGr1qVESr+6hX3Q0aW7PklNQAnGvf/6n0HM4eKGGp4EG8CodyHuTgbN2mp5 xbwIt7QKHt18F2Ytqk4voak+hTyufmIfMzt3XYNste1HUsFkIq7rYYHbjtR07Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hXSJ63Qbzzw7H for ; Sat, 29 Aug 2026 20:57:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f5e2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 29 Aug 2026 20:57:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jose Luis Duran Subject: git: 3c6ea4597b26 - stable/15 - makefs: Fix atime tests on MS-DOS (FAT) file systems List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3c6ea4597b26e5c3d91f2ce62f10542fbf4021a0 Auto-Submitted: auto-generated Date: Sat, 29 Aug 2026 20:57:42 +0000 Message-Id: <6a9347c6.3f5e2.38b4f9f9@gitrepo.freebsd.org> The branch stable/15 has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=3c6ea4597b26e5c3d91f2ce62f10542fbf4021a0 commit 3c6ea4597b26e5c3d91f2ce62f10542fbf4021a0 Author: Jose Luis Duran AuthorDate: 2026-08-21 19:14:03 +0000 Commit: Jose Luis Duran CommitDate: 2026-08-29 20:57:24 +0000 makefs: Fix atime tests on MS-DOS (FAT) file systems On FAT file systems, access time has a resolution of 1 day, so it is really the access date. Strip the time component from the epoch timestamp in order to check the access time. Reference: https://learn.microsoft.com/en-us/windows/win32/sysinfo/file-times Reviewed by: ngie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54584 (cherry picked from commit 2916ae647303e3bd92e533002a8e6c476417fe7f) --- usr.sbin/makefs/tests/makefs_msdos_tests.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/usr.sbin/makefs/tests/makefs_msdos_tests.sh b/usr.sbin/makefs/tests/makefs_msdos_tests.sh index f800bbcd6925..3abf17528559 100644 --- a/usr.sbin/makefs/tests/makefs_msdos_tests.sh +++ b/usr.sbin/makefs/tests/makefs_msdos_tests.sh @@ -48,6 +48,8 @@ atf_test_case T_flag_dir cleanup T_flag_dir_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -56,8 +58,7 @@ T_flag_dir_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp } @@ -72,6 +73,9 @@ T_flag_F_flag_body() { timestamp_F=1742574908 # Even value, timestamp precision is 2s. timestamp_T=1742574910 + # FAT directory entries don't have an access time, just a date. + timestamp_F_atime=$((timestamp_F - timestamp_F % 86400)) + create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -82,8 +86,7 @@ T_flag_F_flag_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_F_atime atf_check_equal $st_mtime $timestamp_F atf_check_equal $st_ctime $timestamp_F } @@ -97,6 +100,8 @@ atf_test_case T_flag_mtree cleanup T_flag_mtree_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -106,8 +111,7 @@ T_flag_mtree_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp }