From nobody Sat Aug 29 10:26:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hXBJF34dpz6q5Vq for ; Sat, 29 Aug 2026 10:26:53 +0000 (UTC) (envelope-from wschnr@googlemail.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hXBJC1Wryz3mPf for ; Sat, 29 Aug 2026 10:26:51 +0000 (UTC) (envelope-from wschnr@googlemail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of wschnr@googlemail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=wschnr@googlemail.com Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47de0093c42so1773686f8f.3 for ; Sat, 29 Aug 2026 03:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787999209; cv=none; d=google.com; s=arc-20260327; b=BOCovray/ELvjqP6/FbWkca9awoJ5ovA0wfrc7AnILiiq2q5NvfTWIMsW5/juyRf98 WIxr6M/tCxMS4+l5B/A/RSdx8wwpNUw0ru46bbwTXi8f/RTCvNNAq6B/yyDPH8GA4gZI GekuxTmB0hhCUA/7bk6T8bNFGudh+ffYtklgadjUwv65g7WOb6pKL1WUwTTO6+ItXYiA VoUm7kHO8L3QwfSL6bbesNDsgs1hfpaBJzOGgj49XnxW9wo8RQdJhciGStC4W32CXMgp qddR3JPH/PTmPc0PiQLHL+JfBPI6pnDWGN4xLRzys7aCZcRvrST4zuSUvAgbgNo827XV nw7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=R7zF+w7BiVhZAAL9r0JESY8yq9hMxpnu7Tut5q8gO+M=; fh=53Apz4RSw3nJmOWHqfjDRdO6YxSWBfqwQR1n+s6A/I0=; b=XEuAbKd54csuSbAxYCi/wA8cKkQJspnGPFxj7bwyZlD7jg2UhPrlCLSx4bvNqphfLb T5ukgkJVTAw6RqbQv60UDnKNDZ8wR9bTExVU4Gx/Qt81YHkAUtQaVXciy++ha2SOi2dQ 5m1DGuGqIV13p4iiF23haShVFw6fJ+KFgSxL9HJSeu+3sSlyRAGg74058MqXwmddt68U NVQJBsodMgm6s2+qtYk3bXrsOw+1xvRG4v0Buwb8s+W5VITq2Pwx9EtTigiQSScRP/ZD xf6yslLbKzYKE7Yuf0oFvS1AnO+emRFDXOmows1bnBGnNNkM/cs3rVFYUNe2pJH16lFb vudA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787999209; x=1788604009; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=R7zF+w7BiVhZAAL9r0JESY8yq9hMxpnu7Tut5q8gO+M=; b=LzAIDqcAwVsovr4wI1pizTq2BUf1VYzwpXDusD8PLL/YpxNbz0I2IMQiPFtFE0W8hV Jjx7odTMakZC1WZ/DkY1O9tffDk9dBGohiqFmfk2dPxvS5mpocqv2KB50BkSL+v0LGiD R846QE1cl4wZFzwkRT9kOAavtrWISMPufANYmIAUkJfiASURMFYb87aPDPz8mq1FO+lw flzqK74LIPRyhxVJ0fUKJpyP2yhXGmT+/8UR2PwFrTJ1DrB+ufYjWoz7UQO3WQgtlB5I cB83eYeHO4SxlEQOcz5nExjb7zkPgwDGVBqkxb1rtjAnc3HeJdKPcmwKmY5kqv089mLL gNWw== X-Forwarded-Encrypted: i=1; AKwUvBzTO6GOJ2bsEdv1GY39kCNMRVM4BxUWGm9E6K8FQw8R9NFCZK3Gv0utbZL+DDLdfNZjXOXcSqHkaNWxH+MxwFFvcXZQ@freebsd.org X-Gm-Message-State: AFuF++lA1z1QP3pFt7VcV/NZwZ1fIp+5kmNzGpdyJowwD1eSOKKCcOSo r2Q2f8Mbm7O3lirgcTTgHi0bznkpw0rdZpRDuk+nIl/2blrZUJvfZHay48IoJJq7jlq5NOBVMBu FpGQ6EdfyaOdEWFId78v2ig9EtbTBZ3/C66Nt X-Gm-Gg: AYBFou3tuUNdtCSfGZ5xwsr4eCpYWgH3o/UccG3m50ktLjS7XUsHgUtDY6LPX5vrcbx dxBsTK/9t5fXDE/Qjk/B/688D4KMKLNSP2qQUGtFxl9xGJWSi9jSMfzxUrh+jYiZxiTSGng3CZS NxZPehfrDLBEEfOIaubR9c8AZyls2gH6UpbPA2b8mi8uwlSy886fTDSLfYCUFbq0GaB6FurPwLA 1Ak43lRb+EAn+HGmnj7zTs2/Ef1S/3duDR/5fLYExdlKiKBiOa3enIgZgJ22OONDal02+3ofW/A 6o6FQ9PWjIk8kxzlzBjjL/TPlG9woBk4ET6M325qY0lSjQxwOPWAIhf89BEemuHn9L82Ad0snxX wNVqC7hRsX78fuTIH04R/SdCq X-Received: by 2002:a05:6000:4905:b0:47f:eb37:fb7f with SMTP id ffacd0b85a97d-482f79befdamr23613912f8f.16.1787999208798; Sat, 29 Aug 2026 03:26:48 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <69f5387a.26bf3.36f56fa3@gitrepo.freebsd.org> In-Reply-To: From: Wolfram Schneider Date: Sat, 29 Aug 2026 12:26:36 +0200 X-Gm-Features: AcwNN1U52gc-NSyxYBZtj8ZfxpdqhV8Ng_egrH8wcYb8HSJ7TsHdOJB9f6h4yis Message-ID: Subject: Re: git: c4f08d46c7f7 - main - llvm-*: Move all LLVM_BINUTILS symlinks to toolchain package To: Ed Maste Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-2.72 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.967]; FORGED_SENDER(0.30)[wosch@freebsd.org,wschnr@googlemail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_SPAM_MEDIUM(0.15)[0.149]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[googlemail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.54:from]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[wosch@freebsd.org,wschnr@googlemail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; MISSING_XM_UA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.54:from]; RCPT_COUNT_THREE(0.00)[4]; R_DKIM_NA(0.00)[] X-Rspamd-Queue-Id: 4hXBJC1Wryz3mPf X-Spamd-Bar: -- On Tue, 30 Jun 2026 at 16:17, Wolfram Schneider wrote: > > After running buildworld, I now see stale symlinks: > > ./tools/build/stale-symlink-buildworld.sh > stale symlink detected: lrwxrwxr-x 1 wosch wheel 12 Jun 16 03:36 > /scratch/tmp/wosch/freebsd/home/wosch/projects/freebsd-src-dev/amd64.amd64/tmp/usr/bin/c++filt > -> llvm-cxxfilt > stale symlink detected: lrwxrwxr-x 1 wosch wheel 8 Jun 16 03:36 > /scratch/tmp/wosch/freebsd/home/wosch/projects/freebsd-src-dev/amd64.amd64/tmp/usr/bin/gcov > -> llvm-cov > stale symlink detected: lrwxrwxr-x 1 wosch wheel 12 Jun 16 03:36 > /scratch/tmp/wosch/freebsd/home/wosch/projects/freebsd-src-dev/amd64.amd64/tmp/usr/bin/objdump > -> llvm-objdump > stale symlink detected: lrwxrwxr-x 1 wosch wheel 12 Jun 16 03:36 > /scratch/tmp/wosch/freebsd/home/wosch/projects/freebsd-src-dev/amd64.amd64/tmp/usr/bin/readelf > -> llvm-readelf > > any idea why this happens? I still see the stale symlinks after running buildworld... -Wolfram > -Wolfram > > On Sat, 2 May 2026 at 01:34, Ed Maste wrote: > > > > The branch main has been updated by emaste: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c4f08d46c7f717cc8c66bf702c006765a5b6b1a9 > > > > commit c4f08d46c7f717cc8c66bf702c006765a5b6b1a9 > > Author: Ed Maste > > AuthorDate: 2026-03-06 14:46:18 +0000 > > Commit: Ed Maste > > CommitDate: 2026-05-01 23:33:51 +0000 > > > > llvm-*: Move all LLVM_BINUTILS symlinks to toolchain package > > > > Some of the LLVM binary utilities were included in the Clang package > > (because they did not set an explicit PACKAGE). > > > > Add a new Makefile under clang/toolchain to create the symlinks and man > > links for ar, c++filt, nm, and so on (without the llvm-* prefix) when > > LLVM_BINUTILS is enabled (as it is by default). > > > > PR: 293610 > > Reviewed by: bapt, ivy, brooks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D55692 > > --- > > Makefile.inc1 | 3 ++- > > packages/toolchain/Makefile | 6 ++++++ > > usr.bin/clang/Makefile | 2 ++ > > usr.bin/clang/llvm-ar/Makefile | 7 ------- > > usr.bin/clang/llvm-cxxfilt/Makefile | 5 ----- > > usr.bin/clang/llvm-nm/Makefile | 6 ------ > > usr.bin/clang/llvm-objcopy/Makefile | 7 ------- > > usr.bin/clang/llvm-readobj/Makefile | 5 ----- > > usr.bin/clang/llvm-size/Makefile | 6 ------ > > usr.bin/clang/llvm-symbolizer/Makefile | 5 ----- > > usr.bin/clang/toolchain/Makefile | 35 ++++++++++++++++++++++++++++++++++ > > 11 files changed, 45 insertions(+), 42 deletions(-) > > > > diff --git a/Makefile.inc1 b/Makefile.inc1 > > index 3c93159645fd..b07b5f9c1a65 100644 > > --- a/Makefile.inc1 > > +++ b/Makefile.inc1 > > @@ -3052,7 +3052,8 @@ _clang_libs= lib/clang > > _llvm_binutils= usr.bin/clang/llvm-ar \ > > usr.bin/clang/llvm-nm \ > > usr.bin/clang/llvm-objcopy \ > > - usr.bin/clang/llvm-size > > + usr.bin/clang/llvm-size \ > > + usr.bin/clang/toolchain > > .endif > > .if ${MK_USB} != "no" > > _usb_tools= stand/usb/tools > > diff --git a/packages/toolchain/Makefile b/packages/toolchain/Makefile > > index 344f0d250b79..b47d931c2c10 100644 > > --- a/packages/toolchain/Makefile > > +++ b/packages/toolchain/Makefile > > @@ -1,7 +1,13 @@ > > +.include > > + > > WORLDPACKAGE= toolchain > > SUBPACKAGES= dbg dev man > > COMPAT_PKGS= dev > > > > PKG_SETS= devel > > > > +.if ${MK_LLVM_BINUTILS} != "no" > > +PKG_DEPS.toolchain+= llvm > > +.endif > > + > > .include > > diff --git a/usr.bin/clang/Makefile b/usr.bin/clang/Makefile > > index ac92b08a54cb..d86508829533 100644 > > --- a/usr.bin/clang/Makefile > > +++ b/usr.bin/clang/Makefile > > @@ -22,6 +22,8 @@ SUBDIR+= llvm-readobj > > SUBDIR+= llvm-size > > SUBDIR+= llvm-strings > > SUBDIR+= llvm-symbolizer > > +SUBDIR+= .WAIT > > +SUBDIR+= toolchain > > .endif > > > > .if ${MK_CLANG_EXTRAS} != "no" > > diff --git a/usr.bin/clang/llvm-ar/Makefile b/usr.bin/clang/llvm-ar/Makefile > > index ee776a7c0d9e..10cd46bad4dc 100644 > > --- a/usr.bin/clang/llvm-ar/Makefile > > +++ b/usr.bin/clang/llvm-ar/Makefile > > @@ -1,6 +1,5 @@ > > .include > > > > -PACKAGE= toolchain > > PROG_CXX= llvm-ar > > MAN= llvm-ar.1 llvm-ranlib.1 > > > > @@ -10,10 +9,4 @@ SRCS+= llvm-ar.cpp > > > > LINKS+= ${BINDIR}/llvm-ar ${BINDIR}/llvm-ranlib > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-ar ${BINDIR}/ar > > -SYMLINKS+= llvm-ranlib ${BINDIR}/ranlib > > -MLINKS+= llvm-ar.1 ar.1 llvm-ar.1 ranlib.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-cxxfilt/Makefile b/usr.bin/clang/llvm-cxxfilt/Makefile > > index 26a5d9e8975d..7d49ccb0a8d0 100644 > > --- a/usr.bin/clang/llvm-cxxfilt/Makefile > > +++ b/usr.bin/clang/llvm-cxxfilt/Makefile > > @@ -22,9 +22,4 @@ DEPENDFILES+= ${TGHDRS:C/$/.d/} > > DPSRCS+= ${TGHDRS} > > CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS= llvm-cxxfilt ${BINDIR}/c++filt > > -MLINKS= llvm-cxxfilt.1 c++filt.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-nm/Makefile b/usr.bin/clang/llvm-nm/Makefile > > index 333513246cb6..68033ce3874f 100644 > > --- a/usr.bin/clang/llvm-nm/Makefile > > +++ b/usr.bin/clang/llvm-nm/Makefile > > @@ -1,6 +1,5 @@ > > .include > > > > -PACKAGE= toolchain > > PROG_CXX= llvm-nm > > > > SRCDIR= llvm/tools/llvm-nm > > @@ -23,9 +22,4 @@ DEPENDFILES+= ${TGHDRS:C/$/.d/} > > DPSRCS+= ${TGHDRS} > > CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-nm ${BINDIR}/nm > > -MLINKS+= llvm-nm.1 nm.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-objcopy/Makefile b/usr.bin/clang/llvm-objcopy/Makefile > > index 13bbab97899f..ee9b13b18f13 100644 > > --- a/usr.bin/clang/llvm-objcopy/Makefile > > +++ b/usr.bin/clang/llvm-objcopy/Makefile > > @@ -26,11 +26,4 @@ CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > LINKS= ${BINDIR}/llvm-objcopy ${BINDIR}/llvm-strip > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-objcopy ${BINDIR}/objcopy \ > > - llvm-strip ${BINDIR}/strip > > -MLINKS= llvm-objcopy.1 objcopy.1 \ > > - llvm-objcopy.1 strip.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-readobj/Makefile b/usr.bin/clang/llvm-readobj/Makefile > > index 3f705431e509..b669e4398fc3 100644 > > --- a/usr.bin/clang/llvm-readobj/Makefile > > +++ b/usr.bin/clang/llvm-readobj/Makefile > > @@ -35,9 +35,4 @@ CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > LINKS+= ${BINDIR}/llvm-readobj ${BINDIR}/llvm-readelf > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-readelf ${BINDIR}/readelf > > -MLINKS+= llvm-readelf.1 readelf.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-size/Makefile b/usr.bin/clang/llvm-size/Makefile > > index 1991065b61b2..c1b7c770acfb 100644 > > --- a/usr.bin/clang/llvm-size/Makefile > > +++ b/usr.bin/clang/llvm-size/Makefile > > @@ -1,6 +1,5 @@ > > .include > > > > -PACKAGE= toolchain > > PROG_CXX= llvm-size > > > > SRCDIR= llvm/tools/llvm-size > > @@ -23,9 +22,4 @@ DEPENDFILES+= ${TGHDRS:C/$/.d/} > > DPSRCS+= ${TGHDRS} > > CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-size ${BINDIR}/size > > -MLINKS+= llvm-size.1 size.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/llvm-symbolizer/Makefile b/usr.bin/clang/llvm-symbolizer/Makefile > > index 1a3a65c774c9..231aeec849c2 100644 > > --- a/usr.bin/clang/llvm-symbolizer/Makefile > > +++ b/usr.bin/clang/llvm-symbolizer/Makefile > > @@ -25,9 +25,4 @@ CLEANFILES+= ${TGHDRS} ${TGHDRS:C/$/.d/} > > > > LINKS+= ${BINDIR}/llvm-symbolizer ${BINDIR}/llvm-addr2line > > > > -.if ${MK_LLVM_BINUTILS} != "no" > > -SYMLINKS+= llvm-addr2line ${BINDIR}/addr2line > > -MLINKS+= llvm-addr2line.1 addr2line.1 > > -.endif > > - > > .include "../llvm.prog.mk" > > diff --git a/usr.bin/clang/toolchain/Makefile b/usr.bin/clang/toolchain/Makefile > > new file mode 100644 > > index 000000000000..1a7db32274e3 > > --- /dev/null > > +++ b/usr.bin/clang/toolchain/Makefile > > @@ -0,0 +1,35 @@ > > +.include > > + > > +.if ${MK_LLVM_BINUTILS} == yes > > +PACKAGE= toolchain > > + > > +SYMLINKS+= llvm-ar ${BINDIR}/ar > > +SYMLINKS+= llvm-ranlib ${BINDIR}/ranlib > > +MLINKS+= llvm-ar.1 ar.1 llvm-ar.1 ranlib.1 > > + > > +SYMLINKS+= llvm-cov ${BINDIR}/gcov > > + > > +SYMLINKS+= llvm-cxxfilt ${BINDIR}/c++filt > > +MLINKS+= llvm-cxxfilt.1 c++filt.1 > > + > > +SYMLINKS+= llvm-nm ${BINDIR}/nm > > +MLINKS+= llvm-nm.1 nm.1 > > + > > +SYMLINKS+= llvm-objcopy ${BINDIR}/objcopy > > +SYMLINKS+= llvm-strip ${BINDIR}/strip > > +MLINKS+= llvm-objcopy.1 objcopy.1 > > +MLINKS+= llvm-objcopy.1 strip.1 > > + > > +SYMLINKS+= llvm-objdump ${BINDIR}/objdump > > + > > +SYMLINKS+= llvm-readelf ${BINDIR}/readelf > > +MLINKS+= llvm-readelf.1 readelf.1 > > + > > +SYMLINKS+= llvm-size ${BINDIR}/size > > +MLINKS+= llvm-size.1 size.1 > > + > > +SYMLINKS+= llvm-addr2line ${BINDIR}/addr2line > > +MLINKS+= llvm-addr2line.1 addr2line.1 > > +.endif > > + > > +.include > > > > > -- > Wolfram Schneider https://wolfram.schneider.org -- Wolfram Schneider https://wolfram.schneider.org