From nobody Fri Aug 28 12:05:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hWcXL2db4z6qH4R for ; Fri, 28 Aug 2026 12:05:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hWcXK3wnqz3C17 for ; Fri, 28 Aug 2026 12:05:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787918721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rq3x6Ih/9CAuYbPfP/1o4ZZaJs7HQgI+t9MwjZKeyPY=; b=K91r9G8uF6Q4F7JeFz2G72aD6oxYliJUl3501B6yF/vaAJHXdh8dxWGzP+ofTLWz71rxcB suuI7MLDN5Vxcl2elGQMgBdDmUIB2auos4AcN7IO6uSWvCHxXeqfkKK3HKv3wcBNZC8Ig+ F2rBXzKqphqj6230PjQV9FA62gejmt59b2OL0lbQ5w6cOejR3PLuOXYXAhtfykf9ahCtkS BIaTpUuAXUA9D3iDZjjVctU8cjg2x5wI9riL1r9nEa0ZL9nKXbsV0cT7MC/MXTflaupcIs ZDk/Lt0DHsR1ymnypWKK2YBzml6yJcpeU5s3w38U4D04Io4D3WbKgKsHhl5beg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787918721; a=rsa-sha256; cv=none; b=KlfEDLxEFzAdL7FY9v8h5S9F7FxbkgcfFhAC/newJfGh119R8aWmWZnOGimVMYeJJWkOQO YlPflJzsZ8zyfZ0jyAsf8I4iKL4V96wRQqwQg1vt4dYmW98CBy4J+72k1y0UyY86b+C+U7 xGdJ9kQ2fZLI4/QJ8xDtWscVN4/QHoh/ljbG4nUpzDd4zhAxawUo7hauS7G1CSwQwhRg/M j9w3FaF5yzNJkloHockX678C/Br4NwVBy0r0kvcq+IyaBsRvU5s2im5+dzM/x3Q6MVblsW JmrY0iYW+cBBenODVLWIGoBY7TYSJw+BU7rK7w5wt6Fe/oI/FGIwGVTXMtX8mA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787918721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rq3x6Ih/9CAuYbPfP/1o4ZZaJs7HQgI+t9MwjZKeyPY=; b=UQIOWyx8n3IrJzwElf8Ja1m1MAmWXYymTNVCVHB5zwSm3KXGvw2vDU2r2vybMkdmvu9ctM yrhaorZFjXvHs942pSENRyvnFEpE19ppJnyNrZs1Dc0sJzm6x29fAtBrzHdf6sttFtLCuX HpR+QZMTmH2OH4eJDoXpumcWcZFq3sw7LyhoYXRbxrbqpDRC7LGJjoYKa22PzWIRKIpbKz iR1dEtClVzIbn8BhItOVzliD7NwTcw4dwqFRSyfna0Jm9jyyLBkLjT1+hnomdTaUDomOni LMC8kacxfJLu0cHxR1D3UT4viWXQDg+eQAAJuaOPkSnQBXYJCW6apFJkkQl+TQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hWcXK2sDlz18M0 for ; Fri, 28 Aug 2026 12:05:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 247b4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Aug 2026 12:05:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: ddf62c83fc0a - main - sys/tests/kern/pdopenpid: pdopenpid(2) is allowed in cap mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ddf62c83fc0aca39a1bfd8346ad6e925bfb2290e Auto-Submitted: auto-generated Date: Fri, 28 Aug 2026 12:05:21 +0000 Message-Id: <6a917981.247b4.56fb7cd3@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=ddf62c83fc0aca39a1bfd8346ad6e925bfb2290e commit ddf62c83fc0aca39a1bfd8346ad6e925bfb2290e Author: Konstantin Belousov AuthorDate: 2026-08-28 08:37:19 +0000 Commit: Konstantin Belousov CommitDate: 2026-08-28 11:55:11 +0000 sys/tests/kern/pdopenpid: pdopenpid(2) is allowed in cap mode Adjust test to check for ECAPMODE using grandchild instead of child. Childrens can be opened even in cap mode. Add test for the later. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D58989 --- tests/sys/kern/procdesc.c | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/tests/sys/kern/procdesc.c b/tests/sys/kern/procdesc.c index ef5746d544aa..862b8277913f 100644 --- a/tests/sys/kern/procdesc.c +++ b/tests/sys/kern/procdesc.c @@ -343,10 +343,10 @@ ATF_TC_BODY(pdopenpid_esrch, tc) } /* - * pdopenpid should fail in capability mode. + * pdopenpid works for children in capability mode. */ -ATF_TC_WITHOUT_HEAD(pdopenpid_capmode); -ATF_TC_BODY(pdopenpid_capmode, tc) +ATF_TC_WITHOUT_HEAD(pdopenpid_child); +ATF_TC_BODY(pdopenpid_child, tc) { pid_t child, parent; @@ -362,7 +362,36 @@ ATF_TC_BODY(pdopenpid_capmode, tc) } ATF_REQUIRE_MSG(cap_enter() == 0, "cap_enter: %s", strerror(errno)); - ATF_REQUIRE_ERRNO(ECAPMODE, pdopenpid(child, 0) < 0); + ATF_REQUIRE_MSG(pdopenpid(child, 0) >= 0, "pdopenpid: %s", + strerror(errno)); +} + +/* + * pdopenpid should fail in capability mode. + */ +ATF_TC_WITHOUT_HEAD(pdopenpid_capmode); +ATF_TC_BODY(pdopenpid_capmode, tc) +{ + pid_t child, grandchild; + + ATF_REQUIRE_FEATURE("security_capability_mode"); + + child = vfork(); + ATF_REQUIRE_MSG(child >= 0, "fork: %s", strerror(errno)); + if (child == 0) { + grandchild = fork(); + ATF_REQUIRE_MSG(grandchild >= 0, "fork: %s", strerror(errno)); + if (grandchild == 0) { + for (;;) + sleep(1); + } else { + _exit(0); + } + } + + ATF_REQUIRE_MSG(cap_enter() == 0, "cap_enter: %s", strerror(errno)); + ATF_REQUIRE_ERRNO(ECAPMODE, pdopenpid(grandchild, 0) < 0); + kill(grandchild, SIGKILL); } /* @@ -759,6 +788,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, pdopenpid_einval); ATF_TP_ADD_TC(tp, pdopenpid_emfile); ATF_TP_ADD_TC(tp, pdopenpid_esrch); + ATF_TP_ADD_TC(tp, pdopenpid_child); ATF_TP_ADD_TC(tp, pdopenpid_capmode); ATF_TP_ADD_TC(tp, pdopenpid_pdfork_then_open); ATF_TP_ADD_TC(tp, pdopenpid_fork_then_open);