From nobody Fri Aug 28 02:23:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hWMd148K5z6ptmD for ; Fri, 28 Aug 2026 02:23:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hWMd10z5Sz3KSZ for ; Fri, 28 Aug 2026 02:23:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787883813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X1SDQBR48CJHkv4iTjM+4KmMFzkO8NuUhybxq1fz1/I=; b=I5NeLT41sXu1l35gDhswsaCvICWT6YyfDlz01/HA3xH9AD+VGL7HV90Kr6flSEeQB3ZQqh aYRb8gJkXGsZ8ZFs8stJ5fGgYXvhg4zBEBwkgdLa7KnhNMyd2DgSJxKYXkzPoF0yvkRKn/ U+kvdImeVkzQa5vA2tdcZvqD4bFilOkUwdYXysyqvp/s/SFFUzZhL3tZGFrrP/NsZlYOKa +p78oaBKkmsF71NcZAjEiz08ytBa0AyrwQpNgpDEE6WW44HzMsBHAomX2KerZK9+0NZCFz PkM5XuRVqQYrHlLWVa3kGJX3tOjeRkFplULyoxi3NpijswMwLv7xunkICSjIkw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787883813; a=rsa-sha256; cv=none; b=NmBehbt6Fum7fFZiWB8vJeKE2qmRL78WUf8ZnA1adCpoPbDmBEprYeZzRGFaaOCPHBJ4Ru x78kE4xjbrWHCHEVaAtuR7e7X/gnC8DBPbXcunudYJ5Pri3+ucukTDJF1IdN4AZ2XduQE2 EqXNL9J76+k+PmVvKaGtIJm8x2oXNed5PRqOuiojJQN1uq6oFQCqdTBtSJco3UagWBwul3 QrPgwq5GxEvi0ls1zZnXMBfaTruDdnoXDyc3KUmA/c4qD92wYdffzOrUgccydTSgWNwE28 iBZ8mqMWd9pMfy5PaeA4Fhw/5WpXpo6ERlYOJtm8sGOUXpAL8bpz3RksbexUcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787883813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X1SDQBR48CJHkv4iTjM+4KmMFzkO8NuUhybxq1fz1/I=; b=Lk9v1PnsYCEh314GIJ/k1b9eNgVvfEtQMB50YqECgPoaATR/9+qkAAtx8P1cXeovFRdtY2 nCTIwvSR2igSRcKuas0KttnQ0aN0+/ViRSiepUBXqkFR/LdNZFOECF1MHC9ay3jeqW1N/9 3/Zp8dmVB/vT+u8ttm4BO8F4Gtb/o+uQKgqBcYpZriiGuvIQTLHhiQsguSTvDYL1EaxKs1 0pWMny5HuL11mDxJmTShmxAxbozX/XoKqvMA9nBqEFLGB2em+ESBdMMevth/XtVrv5bUjf Sn8eh93Fv6y/EltNxtrfORxgafytewAUW9CrTVQIABwpXVDWwTAl7UsJJlT6aA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hWMd06JcrzrS8 for ; Fri, 28 Aug 2026 02:23:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36fb4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Aug 2026 02:23:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Nick Price From: Kevin Bowling Subject: git: 546e2c0380c4 - stable/14 - iflib: Drain configuration tasks before interface detach List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 546e2c0380c48ad0a05db5386fc2952d2fe2f13c Auto-Submitted: auto-generated Date: Fri, 28 Aug 2026 02:23:32 +0000 Message-Id: <6a90f124.36fb4.25afb7db@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=546e2c0380c48ad0a05db5386fc2952d2fe2f13c commit 546e2c0380c48ad0a05db5386fc2952d2fe2f13c Author: Nick Price AuthorDate: 2026-08-08 06:17:16 +0000 Commit: Kevin Bowling CommitDate: 2026-08-28 02:20:56 +0000 iflib: Drain configuration tasks before interface detach iflib_device_deregister() sets IFC_IN_DETACH before removing the interface, but a task which already passed its detach check can still report a link change. This can re-arm if_linktask after ether_ifdetach() has drained it and leave work pending across queue teardown. Drain the entire private taskqueue before ether_ifdetach(). Drivers may register their own link-related configuration tasks there, so draining only the framework admin task leaves the same race for those drivers. Differential Revision: https://reviews.freebsd.org/D58452 Co-authored-by: Andrew Gallatin Co-authored-by: Kevin Bowling (cherry picked from commit ba353c8950d575f9d15b82c92658e660935fba25) --- sys/net/iflib.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 6889c91f3669..0eb4b86542cb 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5645,6 +5645,13 @@ iflib_device_deregister(if_ctx_t ctx) iflib_unregister_vlan_handlers(ctx); iflib_netmap_detach(ifp); + /* + * A task that passed its IFC_IN_DETACH check before the flag was set + * can still report a link change. Drain every private task before + * ether_ifdetach() performs the final if_linktask drain. Drivers may + * register their own link-related tasks on this taskqueue. + */ + taskqueue_drain_all(ctx->ifc_tq); ether_ifdetach(ifp); CTX_LOCK(ctx);