From nobody Fri Aug 28 02:12:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hWMN52zf9z6pskQ for ; Fri, 28 Aug 2026 02:12:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hWMN50Fp2z3GsZ for ; Fri, 28 Aug 2026 02:12:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787883141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KhrUugJrvLkUhlvZDf0fIT0kfszImd5n2FmEUkp0Byk=; b=XaqvHRKAs2+GZV4gOZ1IAXYFkQqxU/dX5jHTEh6ye616E9AUDSyb4ehkahL8qE/WgrUqs+ Wh9gdGZo3fYJDb7YGlYQoeldwp2yLQeE95/lankETBfJA5+J5hFZFrZfSyLQt3fi/Uj8Ig HBBm96lONq0hTVkgOylLDGltMNoMh5l3MzKLIEwN2hv5j5AJOo6pya/56v7uwsakma0zoE 9QdzgDlJVA9mB3yE5/axlkmsgZ/E1gMLiKXClep0BI3bjtCPhYXC/dsJPotrFCBaPwsEHl Ry8y1Wain/uKB+orl/n4TxDwHIAF/O1IaXY1rbTv0OziHFc9cFm86ay9JfFJdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787883141; a=rsa-sha256; cv=none; b=VUrs1UHep8W6L5tD3tFG/CdrcCN064KtKUjfMj3NDR8wGisSGFgWZN9fh0rRO9xWMTh/I9 0nPI6hnUD2yEFBptW8CtJZoIbNA8+h7ellPiualnqg0UM+tJe1eGuffw9MFASOQ0FR8M3B VHgG4lgtKYK5zLGFXB7+LOeM7TLTTJB7ulFpLXAW0IP1bIS9Ur/+C3ccnT117R8APprgHz n3gSmcEO0A8Bp2eDVISLfFLMDGKpzWc2Q+O40z2pCFUi4QoBGJ+vAZHOzJGiD5qYmO3384 XJXeGMeQHPpfHVfVJ4zu3T1Ban+WOjqwith31cKhz+mQcAnwWoY0i4b0eN/HuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787883141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KhrUugJrvLkUhlvZDf0fIT0kfszImd5n2FmEUkp0Byk=; b=y3eQRacr2yWZWxu4PWf6iv0dHIJVQhMLZR56NNn3iV5zieGqu+BUJkdFlM3oPxwrhzA69U LomMACePwrvs8crgRTqE3ZtXlNmz6fBPO12Fr6Hx9CkjK2AQg0p1Q/gLNrEuqfhv5iga2u 4mk1k31j9hOu+ZjOZaQ/E3zrmuDKJ9H+/WOiG79Xy9DfdvJlV7s62rlp+KmXLHkbRk66Bc Izc2eB5kiP5DwhiyTBtttZjLrnSuUVMyMQu903ADkS9zpPlC74b/0crhMYllfByCMP9BeE RhCoyrNpnrPY2ukTfocLAUqzIVw3v0brqWwHty51KzBV7dMRH3n95SProwRtGw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hWMN455vJzqH1 for ; Fri, 28 Aug 2026 02:12:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 370a2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Aug 2026 02:12:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Nick Price From: Kevin Bowling Subject: git: 92b851661bd0 - stable/15 - iflib: Drain configuration tasks before interface detach List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 92b851661bd024d2cb95e306537abaf2c972293f Auto-Submitted: auto-generated Date: Fri, 28 Aug 2026 02:12:20 +0000 Message-Id: <6a90ee84.370a2.60c3cbd3@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=92b851661bd024d2cb95e306537abaf2c972293f commit 92b851661bd024d2cb95e306537abaf2c972293f Author: Nick Price AuthorDate: 2026-08-08 06:17:16 +0000 Commit: Kevin Bowling CommitDate: 2026-08-28 02:11:33 +0000 iflib: Drain configuration tasks before interface detach iflib_device_deregister() sets IFC_IN_DETACH before removing the interface, but a task which already passed its detach check can still report a link change. This can re-arm if_linktask after ether_ifdetach() has drained it and leave work pending across queue teardown. Drain the entire private taskqueue before ether_ifdetach(). Drivers may register their own link-related configuration tasks there, so draining only the framework admin task leaves the same race for those drivers. Differential Revision: https://reviews.freebsd.org/D58452 Co-authored-by: Andrew Gallatin Co-authored-by: Kevin Bowling (cherry picked from commit ba353c8950d575f9d15b82c92658e660935fba25) --- sys/net/iflib.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index a89b627b114c..b4e44321194a 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5505,6 +5505,13 @@ iflib_device_deregister(if_ctx_t ctx) iflib_unregister_vlan_handlers(ctx); iflib_netmap_detach(ifp); + /* + * A task that passed its IFC_IN_DETACH check before the flag was set + * can still report a link change. Drain every private task before + * ether_ifdetach() performs the final if_linktask drain. Drivers may + * register their own link-related tasks on this taskqueue. + */ + taskqueue_drain_all(ctx->ifc_tq); ether_ifdetach(ifp); CTX_LOCK(ctx);