From nobody Wed Aug 26 17:04:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hVWH24PDMz6qMP2 for ; Wed, 26 Aug 2026 17:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hVWH23hd6z3nGK for ; Wed, 26 Aug 2026 17:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787763902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MC+ppvVzGBSkCjfQsDzlzZTIFqD1WhBYqFBZyGFE/Yw=; b=Fhxbl9faFtlkSgXMV27jLoHje26sspBDozpBqnA0Tk8DVL2UGemRAdMmrazKvXWBYyrt32 iPDp0bKBjbpJwO6TEoPSzTB2Dr5Mk2lyO/tIHVIEPymr9ek5l/Fb7L8PogxLVGl9AEvZKL aRSvNRvZDqDjNqZ1iEDbvyoAXL1DpmNWlZwgEXSOPZG5EpgNIe4TRyQwJGk0oAdBjrVJY5 jnWy99PCVQPOEbunVaObAyYovLhtPQJrExSSTmo4skWNNoyXfCp2Hg9iNDOIEk7isbkg86 Q+AMlxGvA27ikPdnlQtqpcjopyIXko5wF3JuysCydUJPtTNcJeTLVtXI59HtRA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787763902; a=rsa-sha256; cv=none; b=Dv6QXWApE8Pkvl1+ujCXV+G/ioQBjDfaiHq3jcMOj8qWN1MmwucqERF/UfFgvZCsjNQ+HU l7aku9COWz7PkidvrcaUJbGUIRlJzMpVKvRTowQse0iYc9VFoQpKTpKrWXvuSBAIIRSyiP Qo/NqE9IG0lsCnFGyo2Qs86esS+mNKQyQ6G85xOi4houArlkQJUuYUpcdxpQgUK6CDCYRR i47BS8rtk6yMS5O2e0t8qvhFAizS7qvZFVDpbju51Fr0w2xAVbkFscS/cH2n+Bt0m6kqDA yo3rCPfGRQA9qL+B5XtSoA3CU8WS2hdDvVmKVW2PVlMydlTOGIfjesOQxEKYRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787763902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MC+ppvVzGBSkCjfQsDzlzZTIFqD1WhBYqFBZyGFE/Yw=; b=IrtNOzYn9kbqXaWT1UGpx3qgeacJwhbZSofj7vH+aka0BrMEd5FiRxqF8gmt8M/6o/dSh8 MEgsHBcCvAzFsONfZWjw6YJ8j/tOKWsvm9I2eR2/2gUMLF4RB4FX+qa792BMtShirHY3u6 dJAw1sNz0FstUx5Of9PJtO7cw+3z0E02GROWAn8PnNiLbXqb7+Yq1sQZymKHVnaAzRjePa 8l/Nrbu+ruq6O71r/qZ3YzmZ7rZFWq7AqPwvX3vKrbkVvAS2VW3mFXmNagMZ4wzwpfa8OM WFnxUCW0areOGiQib+fBg2Fs25BArJ4C1V/yqzyQp556hiGU51UgsEjDv2lb1A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hVWH22XPnznDK for ; Wed, 26 Aug 2026 17:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a677 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 17:04:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Roman Bogorodskiy Subject: git: 8bd30a72e701 - main - bhyve: fix byte order for manually set NVMe eui64 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: novel X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8bd30a72e7012126a1c8d52b3ba32f844a88f8dc Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 17:04:57 +0000 Message-Id: <6a8f1cb9.3a677.6fff3311@gitrepo.freebsd.org> The branch main has been updated by novel: URL: https://cgit.FreeBSD.org/src/commit/?id=8bd30a72e7012126a1c8d52b3ba32f844a88f8dc commit 8bd30a72e7012126a1c8d52b3ba32f844a88f8dc Author: Roman Bogorodskiy AuthorDate: 2026-08-21 13:27:56 +0000 Commit: Roman Bogorodskiy CommitDate: 2026-08-26 16:26:37 +0000 bhyve: fix byte order for manually set NVMe eui64 Manually specified eui64 value gets converted to big endian twice: first using htobe64() and then using be64enc(). On little-endian hosts that results in a little-endian value instead of a big-endian. Fix by removing htobe64() for a user submitted value. Fixes: 409a80e5a434 ("bhyve: Create EUI64 for NVMe namespaces") Reviewed by: chuck Relnotes: yes Sponsored by: The FreeBSD Foundation MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D59080 --- UPDATING | 10 ++++++++++ usr.sbin/bhyve/pci_nvme.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/UPDATING b/UPDATING index fba3cf159402..93c6c9e358a3 100644 --- a/UPDATING +++ b/UPDATING @@ -27,6 +27,16 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 16.x IS SLOW: world, or to merely disable the most expensive debugging functionality at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20260826: + bhyve(8) users who explicitly set the eui64 option for an NVMe + device may need to update their configuration. Due to an incorrect + byte-order conversion, bhyve previously presented manually + configured EUI-64 values to the guest with their bytes reversed. + To preserve the identifier previously visible to the guest, + byte-reverse the value in the eui64 option. Automatically + generated EUI-64 values, used when the option is omitted, + are unaffected. + 20260814: libusb version has been upgraded to 1.0.27 compatible version. All of the missing parts have been implemented. diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index b2b9f0ff88a8..0e20122648a6 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3215,7 +3215,7 @@ pci_nvme_parse_config(struct pci_nvme_softc *sc, nvlist_t *nvl) } value = get_config_value_node(nvl, "eui64"); if (value != NULL) - sc->nvstore.eui64 = htobe64(strtoull(value, NULL, 0)); + sc->nvstore.eui64 = strtoull(value, NULL, 0); value = get_config_value_node(nvl, "dsm"); if (value != NULL) { if (strcmp(value, "auto") == 0)